From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75B5DC4332F for ; Wed, 23 Nov 2022 13:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jRULQelThIsupq4buztc60XhmBzADc7pbamKxBDAtU0=; b=Xj65bndKJ4J/8j nPmNiWMA4hvZzV6vSAAoghizn1ZQ2d+6XPpWLNL43sULrm3jxHzK5IJyUAMsWmoArlUKWEQ6ITmsf wR3BVud/udMScKf1h4e7cD+o+tm3zRXY3OIv8nXgekclWN1haHwmiF+klimBOqoELKSgGVgRMj4q0 ZxTg7FKqnpz35qEWVxXjbwC77kt4pLj/O9xM5GI00gyqT6X/NXjzSEbSbDPuioZ0MjS1VuMKfVucr dSPWiZiOeyJuVzOulMquOh8BXDvbg4bCrI0sT6CwaqM8nU/2cd4tiM6Ur3KIdpI6dFgTQeClWpsNr PvvI+ac6dOC+W95560Pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxq6N-00HLpQ-DE; Wed, 23 Nov 2022 13:47:47 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxq6C-00HLin-RD; Wed, 23 Nov 2022 13:47:38 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oxq5x-0008Ig-KZ; Wed, 23 Nov 2022 14:47:21 +0100 From: Heiko Stuebner To: Michael Riesch , Anand Moon Cc: Rob Herring , Krzysztof Kozlowski , Chukun Pan , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [linux-next-v2 2/5] arm64: dts: rockchip: Add support of external clock to ethernet node on Rock 3A SBC Date: Wed, 23 Nov 2022 14:47:20 +0100 Message-ID: <14662283.uLZWGnKmhe@phil> In-Reply-To: References: <20221116200150.4657-1-linux.amoon@gmail.com> <3e4e601b-e7f8-e9df-0ec5-4f4b629d9c0c@wolfvision.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_054736_904888_186AFEC7 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 23. November 2022, 14:00:50 CET schrieb Anand Moon: > Hi Michael, Heiko > > On Tue, 22 Nov 2022 at 16:48, Michael Riesch > wrote: > > > > Hi Anand, > > > > On 11/16/22 21:01, Anand Moon wrote: > > > Add support of external clock gmac1_clkin which is used as input clock > > > to ethernet node. > > > > Indeed this operating mode is defined in the schematics, thanks for the fix. > > > > > > > > Signed-off-by: Anand Moon > > > > Reviewed-by: Michael Riesch > > Tested-by: Michael Riesch > > > > Actually, I wanted to drop these changes since looking into clk_summary > gmac1 CLK gets wrongly configured with PLL and the reference count is > not correct. > > Plz do the patches, I will send the correct changes next version. as you might've seen, I've applied this patch yesterday. When doing patches also please always take into account, that devicetree describes the hardware situation, not what the Linux-kernel does. But assigned-clock* fixups in a next version are ok to do. Thanks Heiko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90721C4332F for ; Wed, 23 Nov 2022 13:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x73r3ufTf3+d6yUMjdSO23PHf/ecWxxXDN8C9XI5SBE=; b=wleFWSnVbPxycg MD0hWwrcqhGQcYvsnDI0NRQ5J1dko9GHQSNrfO/pwYmgiaYMa9HlkTtkFWFJWhgB4IgbAfR++6bGW JG+6uyzb6mDSOH4eR1bfmnDhpvl/bfokk8Vv+qw+ePCRQU/prV+legyJzNrMLB3pgDlf/FZOOWt4a 7wTr7ExcpLe+/ef82WjRFiXE9pczVNzKItaTpI1+gRbEoRYM0VD9zdPYxRRKYPkFTJhB6FB7/lxUr kPKlsNd8FYAJDPLNrZWzxuxphbysxoBPlYDOnA+BWn+rFFqI6uUXlo1S7Ugs32hRg447nAvib8UE0 jfP9vWbRTLhdDhU3qkqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxq6F-00HLlg-9O; Wed, 23 Nov 2022 13:47:39 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxq6C-00HLin-RD; Wed, 23 Nov 2022 13:47:38 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oxq5x-0008Ig-KZ; Wed, 23 Nov 2022 14:47:21 +0100 From: Heiko Stuebner To: Michael Riesch , Anand Moon Cc: Rob Herring , Krzysztof Kozlowski , Chukun Pan , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [linux-next-v2 2/5] arm64: dts: rockchip: Add support of external clock to ethernet node on Rock 3A SBC Date: Wed, 23 Nov 2022 14:47:20 +0100 Message-ID: <14662283.uLZWGnKmhe@phil> In-Reply-To: References: <20221116200150.4657-1-linux.amoon@gmail.com> <3e4e601b-e7f8-e9df-0ec5-4f4b629d9c0c@wolfvision.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_054736_904888_186AFEC7 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 23. November 2022, 14:00:50 CET schrieb Anand Moon: > Hi Michael, Heiko > > On Tue, 22 Nov 2022 at 16:48, Michael Riesch > wrote: > > > > Hi Anand, > > > > On 11/16/22 21:01, Anand Moon wrote: > > > Add support of external clock gmac1_clkin which is used as input clock > > > to ethernet node. > > > > Indeed this operating mode is defined in the schematics, thanks for the fix. > > > > > > > > Signed-off-by: Anand Moon > > > > Reviewed-by: Michael Riesch > > Tested-by: Michael Riesch > > > > Actually, I wanted to drop these changes since looking into clk_summary > gmac1 CLK gets wrongly configured with PLL and the reference count is > not correct. > > Plz do the patches, I will send the correct changes next version. as you might've seen, I've applied this patch yesterday. When doing patches also please always take into account, that devicetree describes the hardware situation, not what the Linux-kernel does. But assigned-clock* fixups in a next version are ok to do. Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC615C4332F for ; Wed, 23 Nov 2022 13:53:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236717AbiKWNxp (ORCPT ); Wed, 23 Nov 2022 08:53:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236344AbiKWNxO (ORCPT ); Wed, 23 Nov 2022 08:53:14 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 896BCB7F8; Wed, 23 Nov 2022 05:47:37 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oxq5x-0008Ig-KZ; Wed, 23 Nov 2022 14:47:21 +0100 From: Heiko Stuebner To: Michael Riesch , Anand Moon Cc: Rob Herring , Krzysztof Kozlowski , Chukun Pan , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [linux-next-v2 2/5] arm64: dts: rockchip: Add support of external clock to ethernet node on Rock 3A SBC Date: Wed, 23 Nov 2022 14:47:20 +0100 Message-ID: <14662283.uLZWGnKmhe@phil> In-Reply-To: References: <20221116200150.4657-1-linux.amoon@gmail.com> <3e4e601b-e7f8-e9df-0ec5-4f4b629d9c0c@wolfvision.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, Am Mittwoch, 23. November 2022, 14:00:50 CET schrieb Anand Moon: > Hi Michael, Heiko > > On Tue, 22 Nov 2022 at 16:48, Michael Riesch > wrote: > > > > Hi Anand, > > > > On 11/16/22 21:01, Anand Moon wrote: > > > Add support of external clock gmac1_clkin which is used as input clock > > > to ethernet node. > > > > Indeed this operating mode is defined in the schematics, thanks for the fix. > > > > > > > > Signed-off-by: Anand Moon > > > > Reviewed-by: Michael Riesch > > Tested-by: Michael Riesch > > > > Actually, I wanted to drop these changes since looking into clk_summary > gmac1 CLK gets wrongly configured with PLL and the reference count is > not correct. > > Plz do the patches, I will send the correct changes next version. as you might've seen, I've applied this patch yesterday. When doing patches also please always take into account, that devicetree describes the hardware situation, not what the Linux-kernel does. But assigned-clock* fixups in a next version are ok to do. Thanks Heiko