From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Sun, 19 Jun 2016 14:53:22 -0700 Message-ID: <1466373202.2280.3.camel@HansenPartnership.com> References: <1464638381.2240.3.camel@HansenPartnership.com> <871t4ibr7k.fsf@intel.com> <1464701638.2234.1.camel@HansenPartnership.com> <87mvmp9z03.fsf@intel.com> <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1466204815.2199.2.camel@HansenPartnership.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Daniel Vetter Cc: intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyMDE2LTA2LTE3IGF0IDE2OjA2IC0wNzAwLCBKYW1lcyBCb3R0b21sZXkgd3JvdGU6 Cj4gT24gRnJpLCAyMDE2LTA2LTE3IGF0IDE2OjM0ICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToK PiA+IE9uIEZyaSwgMTcgSnVuIDIwMTYsIERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4g d3JvdGU6Cj4gPiA+IE9uIFRodSwgSnVuIDE2LCAyMDE2IGF0IDAzOjQyOjEyUE0gLTA3MDAsIEph bWVzIEJvdHRvbWxleSB3cm90ZToKPiA+ID4gPiBPbiBUaHUsIDIwMTYtMDYtMTYgYXQgMTQ6Mjkg LTA3MDAsIEphbWVzIEJvdHRvbWxleSB3cm90ZToKPiA+ID4gPiA+IE9uIFRodSwgMjAxNi0wNi0x NiBhdCAyMzoyNCArMDIwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ID4gPiA+ID4gSSBndWVz cyB3ZSdsbCBuZWVkIHRoZSBiaXNlY3Qgb24gdGhpcyBvbmUgdG8gbWFrZSBwcm9ncmVzcy4KPiA+ ID4gPiA+IAo+ID4gPiA+ID4gU2lnaCwgSSB3YXMgYWZyYWlkIHRoYXQgbWlnaHQgYmUgdGhlIG5l eHQgc3RlcC4KPiA+ID4gPiAKPiA+ID4gPiBPSywgSSBoYXZlIGEgY3VyaW91cyBkYXRhIHBvaW50 LiAgSSBhc3N1bWVkIHRoZSBwcm9ibGVtIHdvdWxkCj4gPiA+ID4gYmUKPiA+ID4gPiBzb21ld2hl cmUgaW4gdGhlIGRybSB1cGRhdGUsIHNvIEkgc3RhcnRlZCBiaXNlY3RpbmcgdGhhdCBhdCB0aGUK PiA+ID4gPiB0b3AuIAo+ID4gPiA+ICBIb3dldmVyLCB0aGUgdG9wIG1vc3QgY29tbWl0Ogo+ID4g PiA+IAo+ID4gPiA+IGNvbW1pdCAxZDZkYTg3YTMyNDFkZWIxM2QwNzNjNDEyNWQxOWVkMGU1YTBj NjJjCj4gPiA+ID4gTWVyZ2U6IDFmNDBjNDkgYTM5ZWQ2OAo+ID4gPiA+IEF1dGhvcjogTGludXMg VG9ydmFsZHMgPHRvcnZhbGRzQGxpbnV4LWZvdW5kYXRpb24ub3JnPgo+ID4gPiA+IERhdGU6ICAg TW9uIE1heSAyMyAxMTo0ODo0OCAyMDE2IC0wNzAwCj4gPiA+ID4gCj4gPiA+ID4gICAgIE1lcmdl IGJyYW5jaCAnZHJtLW5leHQnIG9mCj4gPiA+ID4gZ2l0Oi8vcGVvcGxlLmZyZWVkZXNrdG9wLm9y Zy9+YWlybGllZC9saW51eAo+ID4gPiA+IAo+ID4gPiA+IElzbid0IGFjdHVhbGx5IGJhZC4gIFRo ZXJlJ3Mgbm8gZmxpY2tlciBoZXJlLCBzbyB3aGF0ZXZlcgo+ID4gPiA+IGNhdXNlZAo+ID4gPiA+ IHRoZQo+ID4gPiA+IHByb2JsZW0gY2FtZSBmcm9tIHNvbWUgdXBkYXRlIGFmdGVyIHRoaXMuCj4g PiA+IAo+ID4gPiBUaGVyZSB3YXMgYSBmaXhlcyBwdWxsIGFmdGVyIHRoaXMuIE1pZ2h0IGJlIHdv cnRoIGl0IHRvIHJlc3RyaWN0Cj4gPiA+IHRvCj4gPiA+IGp1c3QKPiA+ID4gdGhlIGk5MTUgY2hh bmdlcywgd2hpY2ggYXJlIGp1c3QKPiA+ID4gNWI0ZmQ1YjExMTFiMTIzMGNkMDM3Li4xNTdkMmM3 ZmFkMDg2MzIyMgo+ID4gPiAKPiA+ID4gTG9va2luZyBhdCB0aG9zZSBub3RoaW5nIHNlZW1zIHRv IHN0aWNrIG91dCB3aGljaCBtaWdodCBleHBsYWluCj4gPiA+IHdoYXQncwo+ID4gPiBoYXBwZW5p bmcgZm9yIHlvdS4KPiAKPiBPSywgc28ganVzdCBvbiB0aGUgZmlybXdhcmUsIHRoZSBzeXN0ZW0g c2VlbXMgbGVzcyBmbGlja2VyeSB3aXRoIHRoZQo+IG5ldyAxLjQuMyBVRUZJLCBzbyBJJ20gc3Rh cnRpbmcgdG8gdGhpbmsgaXQgaXMgYSBTa3lsYWtlIGVycmF0YSAKPiBpc3N1ZS4gIFRoZSBmbGlj a2VyIGlzbid0IGdvbmUgZm9yIGdvb2QsIGJ1dCBzZWVtcyB0byBiZSByZWJvb3QgCj4gZGVwZW5k ZW50IChpdCdzIHRoZXJlIGluIHNvbWUgYm9vdHMsIGJ1dCBnb25lIG9uIGEgcmVib290KS4KPiAK PiA+IFRoaXMgc2hvdWxkIGJlIGVhc3kgZW5vdWdoIHRvIHRyeSBiZWZvcmUgYmlzZWN0aW5nOgo+ ID4gaHR0cDovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNnaWQvMTQ2NjE2MjA4 MS0xMjA0Mi0xLWdpdAo+ID4gLXMKPiA+IGVuZC1lbWFpbC1taWthLmthaG9sYUBpbnRlbC5jb20K PiAKPiBBcHBseWluZyB0aGlzIGRpZG4ndCBzZWVtIHRvIG1ha2UgYSBkaWZmZXJlbmNlOiBzdGls bCB0aGVyZSBvbiBzb21lIAo+IGFuZCBnb25lIG9uIG90aGVyIHJlYm9vdHMuCgpPSywgbXkgY2Fu ZGlkYXRlIGJhZCBjb21taXQgaXMgdGhpcyBvbmU6Cgpjb21taXQgYTA1NjI4MTk1YTBkOWYzMTcz ZGQ5YWE3NmY0ODJhZWY2OTJlNDZlZQpBdXRob3I6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+CkRhdGU6ICAgTW9uIEFwciAxMSAxMDoyMzo1MSAyMDE2ICsw MzAwCgogICAgZHJtL2k5MTU6IEdldCBwYW5lbF90eXBlIGZyb20gT3BSZWdpb24gcGFuZWwgZGV0 YWlscwoKQWZ0ZXIgYmVpbmcgbW9yZSBjYXJlZnVsIGFib3V0IHdhaXRpbmcgdG8gaWRlbnRpZnkg ZmxpY2tlciwgdGhpcyBvbmUKc2VlbXMgdG8gYmUgdGhlIG9uZSB0aGUgYmlzZWN0IGZpbmRzLiAg SSdtIG5vdyBydW5uaW5nIHY0LjctcmMzIHdpdGgKdGhpcyBvbmUgcmV2ZXJ0ZWQgYW5kIGFtIGN1 cnJlbnRseSBzZWVpbmcgbm8gZmxpY2tlciBwcm9ibGVtcy4gIEl0IGlzLApob3dldmVyLCBlYXJs eSBkYXlzIGJlY2F1c2UgdGhlIGZsaWNrZXIgY2FuIGhpZGUgZm9yIGxvbmcgcGVyaW9kcywgc28g SQonbGwgd2FpdCB1bnRpbCBNb25kYXkgZXZlbmluZyBhbmQgYSBmZXcgcmVib290cyBiZWZvcmUg ZGVjbGFyaW5nCnZpY3RvcnkuCgpKYW1lcwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751639AbcFSWKQ (ORCPT ); Sun, 19 Jun 2016 18:10:16 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:56736 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbcFSWKM (ORCPT ); Sun, 19 Jun 2016 18:10:12 -0400 Message-ID: <1466373202.2280.3.camel@HansenPartnership.com> Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window From: James Bottomley To: Jani Nikula , Daniel Vetter Cc: intel-gfx , dri-devel , linux-kernel , Rodrigo Vivi Date: Sun, 19 Jun 2016 14:53:22 -0700 In-Reply-To: <1466204815.2199.2.camel@HansenPartnership.com> References: <1464638381.2240.3.camel@HansenPartnership.com> <871t4ibr7k.fsf@intel.com> <1464701638.2234.1.camel@HansenPartnership.com> <87mvmp9z03.fsf@intel.com> <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-06-17 at 16:06 -0700, James Bottomley wrote: > On Fri, 2016-06-17 at 16:34 +0300, Jani Nikula wrote: > > On Fri, 17 Jun 2016, Daniel Vetter wrote: > > > On Thu, Jun 16, 2016 at 03:42:12PM -0700, James Bottomley wrote: > > > > On Thu, 2016-06-16 at 14:29 -0700, James Bottomley wrote: > > > > > On Thu, 2016-06-16 at 23:24 +0200, Daniel Vetter wrote: > > > > > > I guess we'll need the bisect on this one to make progress. > > > > > > > > > > Sigh, I was afraid that might be the next step. > > > > > > > > OK, I have a curious data point. I assumed the problem would > > > > be > > > > somewhere in the drm update, so I started bisecting that at the > > > > top. > > > > However, the top most commit: > > > > > > > > commit 1d6da87a3241deb13d073c4125d19ed0e5a0c62c > > > > Merge: 1f40c49 a39ed68 > > > > Author: Linus Torvalds > > > > Date: Mon May 23 11:48:48 2016 -0700 > > > > > > > > Merge branch 'drm-next' of > > > > git://people.freedesktop.org/~airlied/linux > > > > > > > > Isn't actually bad. There's no flicker here, so whatever > > > > caused > > > > the > > > > problem came from some update after this. > > > > > > There was a fixes pull after this. Might be worth it to restrict > > > to > > > just > > > the i915 changes, which are just > > > 5b4fd5b1111b1230cd037..157d2c7fad0863222 > > > > > > Looking at those nothing seems to stick out which might explain > > > what's > > > happening for you. > > OK, so just on the firmware, the system seems less flickery with the > new 1.4.3 UEFI, so I'm starting to think it is a Skylake errata > issue. The flicker isn't gone for good, but seems to be reboot > dependent (it's there in some boots, but gone on a reboot). > > > This should be easy enough to try before bisecting: > > http://patchwork.freedesktop.org/patch/msgid/1466162081-12042-1-git > > -s > > end-email-mika.kahola@intel.com > > Applying this didn't seem to make a difference: still there on some > and gone on other reboots. OK, my candidate bad commit is this one: commit a05628195a0d9f3173dd9aa76f482aef692e46ee Author: Ville Syrjälä Date: Mon Apr 11 10:23:51 2016 +0300 drm/i915: Get panel_type from OpRegion panel details After being more careful about waiting to identify flicker, this one seems to be the one the bisect finds. I'm now running v4.7-rc3 with this one reverted and am currently seeing no flicker problems. It is, however, early days because the flicker can hide for long periods, so I 'll wait until Monday evening and a few reboots before declaring victory. James