All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yannick Brosseau <scientist@fb.com>
To: <shuahkh@osg.samsung.com>, <linux-kselftest@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <emunson@akamai.com>,
	<treding@nvidia.com>
Cc: <kernel-team@fb.com>, Yannick Brosseau <scientist@fb.com>
Subject: [PATCH] selftests/vm: Don't mlockall MCL_CURRENT in on-fault-limit test
Date: Mon, 20 Jun 2016 14:27:10 -0700	[thread overview]
Message-ID: <1466458030-17524-1-git-send-email-scientist@fb.com> (raw)

The default MEMLOCK limit is not big enough to accomodate all the
current pages of the test program process, so the test fails
at this step.
By removing the MCL_CURRENT flag, we allow the mlockall
call to succeed. The mmap is twice the size of the current limit,
so it will still fail as expected.

Signed-off-by: Yannick Brosseau <scientist@fb.com>
---
 tools/testing/selftests/vm/on-fault-limit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/vm/on-fault-limit.c b/tools/testing/selftests/vm/on-fault-limit.c
index 245accc..0ae458f 100644
--- a/tools/testing/selftests/vm/on-fault-limit.c
+++ b/tools/testing/selftests/vm/on-fault-limit.c
@@ -20,7 +20,7 @@ static int test_limit(void)
 		return ret;
 	}
 
-	if (mlockall(MCL_CURRENT | MCL_ONFAULT | MCL_FUTURE)) {
+	if (mlockall(MCL_ONFAULT | MCL_FUTURE)) {
 		perror("mlockall");
 		return ret;
 	}
-- 
2.8.1

             reply	other threads:[~2016-06-20 22:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 21:27 Yannick Brosseau [this message]
2016-06-27 17:54 ` [PATCH] selftests/vm: Don't mlockall MCL_CURRENT in on-fault-limit test Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466458030-17524-1-git-send-email-scientist@fb.com \
    --to=scientist@fb.com \
    --cc=emunson@akamai.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuahkh@osg.samsung.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.