From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rYS3H686TzDq5c for ; Tue, 21 Jun 2016 09:38:19 +1000 (AEST) Message-ID: <1466465899.437.0.camel@ellerman.id.au> Subject: Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF From: Michael Ellerman To: "Naveen N. Rao" Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, Matt Evans , Daniel Borkmann , Alexei Starovoitov , Denis Kirjanov , Paul Mackerras , "David S. Miller" , Ananth N Mavinakayanahalli Date: Tue, 21 Jun 2016 09:38:19 +1000 In-Reply-To: <20160619173642.GB8886@naverao1-tp.localdomain> References: <908d3552b5eb240b28f70aee7c4c86e2b600aa02.1465304785.git.naveen.n.rao@linux.vnet.ibm.com> <3rWKtT2tSrz9t2G@ozlabs.org> <20160619173642.GB8886@naverao1-tp.localdomain> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote: > On 2016/06/17 10:53PM, Michael Ellerman wrote: > > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > > > diff --git a/arch/powerpc/net/bpf_jit_comp64.c b/arch/powerpc/net/bpf_jit_comp64.c > > > new file mode 100644 > > > index 0000000..954ff53 > > > --- /dev/null > > > +++ b/arch/powerpc/net/bpf_jit_comp64.c > > > @@ -0,0 +1,956 @@ > > ... > > > + > > > +static void bpf_jit_fill_ill_insns(void *area, unsigned int size) > > > +{ > > > + int *p = area; > > > + > > > + /* Fill whole space with trap instructions */ > > > + while (p < (int *)((char *)area + size)) > > > + *p++ = BREAKPOINT_INSTRUCTION; > > > +} > > > > This breaks the build for some configs, presumably you're missing a header: > > > > arch/powerpc/net/bpf_jit_comp64.c:30:10: error: 'BREAKPOINT_INSTRUCTION' undeclared (first use in this function) > > > > http://kisskb.ellerman.id.au/kisskb/buildresult/12720611/ > > Oops. Yes, I should have caught that. I need to add: > > #include > > in bpf_jit_comp64.c > > Can you please check if it resolves the build error? Can you? :D cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF Date: Tue, 21 Jun 2016 09:38:19 +1000 Message-ID: <1466465899.437.0.camel@ellerman.id.au> References: <908d3552b5eb240b28f70aee7c4c86e2b600aa02.1465304785.git.naveen.n.rao@linux.vnet.ibm.com> <3rWKtT2tSrz9t2G@ozlabs.org> <20160619173642.GB8886@naverao1-tp.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Matt Evans , Daniel Borkmann , Alexei Starovoitov , netdev@vger.kernel.org, Denis Kirjanov , linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Ananth N Mavinakayanahalli To: "Naveen N. Rao" Return-path: In-Reply-To: <20160619173642.GB8886@naverao1-tp.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: netdev.vger.kernel.org T24gU3VuLCAyMDE2LTA2LTE5IGF0IDIzOjA2ICswNTMwLCBOYXZlZW4gTi4gUmFvIHdyb3RlOgo+ IE9uIDIwMTYvMDYvMTcgMTA6NTNQTSwgTWljaGFlbCBFbGxlcm1hbiB3cm90ZToKPiA+IE9uIFR1 ZSwgMjAxNi0wNy0wNiBhdCAxMzozMjoyMyBVVEMsICJOYXZlZW4gTi4gUmFvIiB3cm90ZToKPiA+ ID4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9uZXQvYnBmX2ppdF9jb21wNjQuYyBiL2FyY2gv cG93ZXJwYy9uZXQvYnBmX2ppdF9jb21wNjQuYwo+ID4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ ID4gPiBpbmRleCAwMDAwMDAwLi45NTRmZjUzCj4gPiA+IC0tLSAvZGV2L251bGwKPiA+ID4gKysr IGIvYXJjaC9wb3dlcnBjL25ldC9icGZfaml0X2NvbXA2NC5jCj4gPiA+IEBAIC0wLDAgKzEsOTU2 IEBACj4gPiAuLi4KCj4gPiA+ICsKPiA+ID4gK3N0YXRpYyB2b2lkIGJwZl9qaXRfZmlsbF9pbGxf aW5zbnModm9pZCAqYXJlYSwgdW5zaWduZWQgaW50IHNpemUpCj4gPiA+ICt7Cj4gPiA+ICsJaW50 ICpwID0gYXJlYTsKPiA+ID4gKwo+ID4gPiArCS8qIEZpbGwgd2hvbGUgc3BhY2Ugd2l0aCB0cmFw IGluc3RydWN0aW9ucyAqLwo+ID4gPiArCXdoaWxlIChwIDwgKGludCAqKSgoY2hhciAqKWFyZWEg KyBzaXplKSkKPiA+ID4gKwkJKnArKyA9IEJSRUFLUE9JTlRfSU5TVFJVQ1RJT047Cj4gPiA+ICt9 Cj4gPiAKPiA+IFRoaXMgYnJlYWtzIHRoZSBidWlsZCBmb3Igc29tZSBjb25maWdzLCBwcmVzdW1h Ymx5IHlvdSdyZSBtaXNzaW5nIGEgaGVhZGVyOgo+ID4gCj4gPiAgIGFyY2gvcG93ZXJwYy9uZXQv YnBmX2ppdF9jb21wNjQuYzozMDoxMDogZXJyb3I6ICdCUkVBS1BPSU5UX0lOU1RSVUNUSU9OJyB1 bmRlY2xhcmVkIChmaXJzdCB1c2UgaW4gdGhpcyBmdW5jdGlvbikKPiA+IAo+ID4gaHR0cDovL2tp c3NrYi5lbGxlcm1hbi5pZC5hdS9raXNza2IvYnVpbGRyZXN1bHQvMTI3MjA2MTEvCj4gCj4gT29w cy4gWWVzLCBJIHNob3VsZCBoYXZlIGNhdWdodCB0aGF0LiBJIG5lZWQgdG8gYWRkOgo+IAo+ICNp bmNsdWRlIDxhc20va3Byb2Jlcy5oPgo+IAo+IGluIGJwZl9qaXRfY29tcDY0LmMKPiAKPiBDYW4g eW91IHBsZWFzZSBjaGVjayBpZiBpdCByZXNvbHZlcyB0aGUgYnVpbGQgZXJyb3I/CgpDYW4geW91 PyA6RAoKY2hlZXJzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMu b3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY=