From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lekensteyn Subject: Re: [PATCH] i915: initialize CADL in opregion Date: Thu, 28 Jun 2012 01:24:37 +0200 Message-ID: <1466476.5JoFf03NtD@al> References: <1574631.uSlQXEJRId@al> <1406538.9ve8iYH0Aa@al> <20120627162737.GF5326@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id C6ACC9E789 for ; Wed, 27 Jun 2012 16:24:45 -0700 (PDT) Received: by werc12 with SMTP id c12so1234883wer.36 for ; Wed, 27 Jun 2012 16:24:45 -0700 (PDT) In-Reply-To: <20120627162737.GF5326@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wednesday 27 June 2012 18:27:37 Daniel Vetter wrote: > On Wed, Jun 27, 2012 at 05:09:02PM +0200, Lekensteyn wrote: > > On Wednesday 27 June 2012 17:03:02 Daniel Vetter wrote: > > > On Tue, Jun 26, 2012 at 11:07:55PM +0200, Daniel Vetter wrote: > > > > On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote: > > > > > On Tue, 26 Jun 2012 00:36:24 +0200 > > > > > > > > > > Lekensteyn wrote: > > > > > > This is rather a hack to fix brightness hotkeys on a Clevo laptop. > > > > > > CADL is not used anywhere in the driver code at the moment, but it > > > > > > could be used in BIOS as is the case with the Clevo laptop. > > > > > > > > > > > > The Clevo B7130 requires the CADL field to contain at least the ID > > > > > > of > > > > > > the LCD device. If this field is empty, the ACPI methods that are > > > > > > called > > > > > > on pressing brightness / display switching hotkeys will not > > > > > > trigger a > > > > > > notification. As a result, it appears as no hotkey has been > > > > > > pressed. > > > > > > > > > > Not ideal, but definitely better than nothing. > > > > > > > > > > Acked-by: Jesse Barnes > > > > > > > > Queued for -next, thanks for the patch. > > > > > > Unfortunately this results in a neat black screen on my ivb zenbook. > > > Until > > > I've figured out what exactly's going on, I have to drop this from -next > > > again. > > > -Daniel > > > > Can you share your acpidump on > > https://bugs.freedesktop.org/show_bug.cgi?id=45452 ? > > Attached. > -Daniel Thank you, I've now written a partial analysis which is available at https://github.com/Lekensteyn/acpi- stuff/blob/HEAD/dsl/Asus_Zenbook_DanielVetter/analysis.txt (note: URL is cut in two parts in this mail, concat them as needed). Question: can you try disabling the asus-laptop module and try booting again w/ and w/o the CADL patch applied? - Does it boot in both cases? - Do the brightness hotkeys work? - Can you change brightness via /sys/class/backlight? Can you SSH in it and check the logs? Any ACPI warnings/errors or messages from the asus-laptop module? (or whatever asus module(s) is/are loaded) Can you also generate dmidecode.txt? (peek in http://lekensteyn.nl/files/get- acpi-info.sh, you do not have to run all of the commands since I already have your acpidump) Thanks, Peter