All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
	Ben Greear <greearb@candelatech.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: NL80211_ATTR_PAD question
Date: Tue, 21 Jun 2016 11:36:27 +0200	[thread overview]
Message-ID: <1466501787.3170.12.camel@sipsolutions.net> (raw)
In-Reply-To: <575F089C.3020201@broadcom.com> (sfid-20160613_212518_019571_6F7C96F1)

On Mon, 2016-06-13 at 21:25 +0200, Arend van Spriel wrote:
> 
> On 10-06-16 23:08, Johannes Berg wrote:
> > On Fri, 2016-06-10 at 12:47 -0700, Ben Greear wrote:
> > > I see this was added sometime recently:  NL80211_ATTR_PAD
> > > 
> > > If another enum member is added, should it replace the PAD enum?
> > 
> > No.
> > 
> > > At the least, I think we need some comments about how this is to
> > > be
> > > dealt with.
> > > 
> > 
> > You simply ignore it :)
> 
> So do you know why the caller of nla_put_u64_64bit() would need to
> specify the padattr. I mean, why is this not an generic attribute
> that
> netlink deals with internally. It has probably been discussed on the
> netdev list but I could not find the right thread.
> 

Netlink attribute numbers are always specific to the (generic) netlink
family used. There was a discussion about using the attribute number 0
since that's reserved, but unfortunately it's only reserved in *most*
families, some actually use it (despite that being broken with libnl.)

johannes

      reply	other threads:[~2016-06-21 11:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 19:47 NL80211_ATTR_PAD question Ben Greear
2016-06-10 20:28 ` Arend van Spriel
2016-06-10 21:08 ` Johannes Berg
2016-06-10 22:40   ` Ben Greear
2016-06-13 19:25   ` Arend van Spriel
2016-06-21  9:36     ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466501787.3170.12.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.