From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:8558 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751638AbcFUOph (ORCPT ); Tue, 21 Jun 2016 10:45:37 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5LEicDs033741 for ; Tue, 21 Jun 2016 10:45:36 -0400 Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) by mx0b-001b2d01.pphosted.com with ESMTP id 23q701sqav-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 21 Jun 2016 10:45:36 -0400 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Jun 2016 08:45:33 -0600 Subject: Re: SCSI fix (a621bac3)missing in stable From: James Bottomley To: Jinpu Wang Cc: "Martin K. Petersen" , Christoph Hellwig , Greg KH , stable , Jiri Slaby , Sebastian Parschauer , Yun Wang , Gi-Oh Kim Date: Tue, 21 Jun 2016 10:45:18 -0400 In-Reply-To: References: <20160614200314.GA3267@kroah.com> <1466178718.2271.25.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Message-Id: <1466520318.2291.4.camel@linux.vnet.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, 2016-06-20 at 12:23 +0200, Jinpu Wang wrote: > On Fri, Jun 17, 2016 at 5:51 PM, James Bottomley > wrote: > > On Fri, 2016-06-17 at 17:29 +0200, Jinpu Wang wrote: > > > On Wed, Jun 15, 2016 at 10:04 AM, Jinpu Wang > > > wrote: > > > > On Tue, Jun 14, 2016 at 10:03 PM, Greg KH < > > > > gregkh@linuxfoundation.org> wrote: > > > > > On Wed, Jun 08, 2016 at 06:47:40PM +0200, Jinpu Wang wrote: > > > > > > Hi all, > > > > > > > > > > > > We found the SCSI fix is missing in any stable only in > > > > > > linux > > > > > > 4.7-rc2 > > > > > > [PATCH] scsi_lib: correctly retry failed zero length > > > > > > REQ_TYPE_FS > > > > > > commands > > > > > > > > > > > > commit a621bac3044ed6f7ec5fa0326491b2d4838bfa93 upstream. > > > > > > > > > > > > So we backport & tested on linux-3.12 (as we're using this > > > > > > kernel). > > > > > > Could you review if we did it right? > > > > > > > > > > This "backport" includes a bunch of checks and comments that > > > > > are > > > > > not in > > > > > the upstream kernel, so I don't really want to include it in > > > > > the > > > > > 3.14-stable queue unless you get the scsi maintainers to ack > > > > > it. > > > > > > > > > > thanks, > > > > > > > > > > greg k-h > > > > > > > > Thanks Greg! > > > > > > > > Hi James, hi Martin > > > > > > > > Could you give your Ack on the patch? > > > > > > > > -- > > > > > > Ping? > > > > How can I review this? What you're proposing certainly isn't a > > backport. What you're actually trying to do is to port around this > > commit: > > > > ommit bc85dc500f9df9b2eec15077e5046672c46adeaa > > Author: Christoph Hellwig > > Date: Thu May 1 16:51:03 2014 +0200 > > > > scsi: remove scsi_end_request > > > > Have you tried simply backporting that to your tree and then > > applying > > to work around? > > > > James > > > > Thanks James for suggestions. > I did backport bc85dc500, and backport a621bac3, it passed my local > tests. > > Could you review patches attached? I'm afraid 3.12 is way too old for me to remember the current state of play. However, if those two patches backport unmodified and you've tested it, then you're good to go. James