From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kani, Toshimitsu" Subject: Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Date: Tue, 21 Jun 2016 15:44:54 +0000 Message-ID: <1466523280.3504.262.camel@hpe.com> References: <1465856497-19698-1-git-send-email-toshi.kani@hpe.com> <20160613225756.GA18417@redhat.com> <20160620180043.GA21261@redhat.com> <1466446861.3504.243.camel@hpe.com> <20160620194026.GA21657@redhat.com> <20160620195217.GB21657@redhat.com> <1466452883.3504.244.camel@hpe.com> <1466457467.3504.249.camel@hpe.com> <20160620222236.GA22461@redhat.com> <20160621134147.GA26392@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160621134147.GA26392-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Content-ID: <3237E4E187B56D43BE612A6598212E91-mmYPd6ayCNGroOM5E8FhRbjFIynDaujOfM0AETQt39g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "axboe-b10kYP2dOMg@public.gmane.org" , "snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org" , "sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org" , "agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" List-Id: dm-devel.ids T24gVHVlLCAyMDE2LTA2LTIxIGF0IDA5OjQxIC0wNDAwLCBNaWtlIFNuaXR6ZXIgd3JvdGU6DQo+ IE9uIE1vbiwgSnVuIDIwIDIwMTYgYXTCoMKgNjoyMnBtIC0wNDAwLA0KPiBNaWtlIFNuaXR6ZXIg PHNuaXR6ZXJAcmVkaGF0LmNvbT4gd3JvdGU6DQo+ID4gDQo+ID4gT24gTW9uLCBKdW4gMjAgMjAx NiBhdMKgwqA1OjI4cG0gLTA0MDAsDQo+ID4gS2FuaSwgVG9zaGltaXRzdSA8dG9zaGkua2FuaUBo cGUuY29tPiB3cm90ZToNCj4gPiANCsKgOg0KPiA+IExvb2tzIGdvb2QsIEkgZm9sZGVkIGl0IGlu IGFuZCB0ZXN0ZWQgaXQgdG8gd29yay7CoMKgUHVzaGVkIHRvIG15ICd3aXAnDQo+ID4gYnJhbmNo Lg0KPiA+IA0KPiA+IE5vIGxvbmdlciBzZWVpbmcgYW55IGNvcnJ1cHRpb24gaW4gbXkgdGVzdCB0 aGF0IHdhcyB1c2luZyBwYXJ0aXRpb25zIHRvDQo+ID4gc3BhbiBwbWVtIGRldmljZXMgd2l0aCBh IGRtLWxpbmVhciBkZXZpY2UuDQo+ID4gDQo+ID4gSmVucywgYW55IGNoYW5jZSB5b3UnZCBiZSBv cGVuIHRvIHBpY2tpbmcgdXAgdGhlIGZpcnN0IDIgcGF0Y2hlcyBpbiB0aGlzDQo+ID4gc2VyaWVz P8KgwqBPciB3b3VsZCB5b3UgbGlrZSB0byBzZWUgdGhlbSBmb2xkZWQgb3Igc29tZXRoaW5nIGRp ZmZlcmVudD8NCj4NCj4gSSdtIG5vdyB3b25kZXJpbmcgaWYgd2UnZCBiZSBiZXR0ZXIgb2ZmIHNl dHRpbmcgYSBuZXcgUVVFVUVfRkxBR19EQVgNCj4gcmF0aGVyIHRoYW4gZXN0YWJsaXNoIEdFTkhE X0ZMX0RBWCBvbiB0aGUgZ2VuaGQ/DQo+IA0KPiBJdCdkIGJlIHF1aXRlIGEgYml0IGVhc2llciB0 byBhbGxvdyB1cHBlciBsYXllcnMgKGUuZy4gWEZTIGFuZCBleHQ0KSB0bw0KPiBjaGVjayBmb3Ig YSBxdWV1ZSBmbGFnLg0KDQpJIHRoaW5rIEdFTkhEX0ZMX0RBWCBpcyBtb3JlIGFwcHJvcHJpYXRl IHNpbmNlIERBWCBkb2VzIG5vdCB1c2UgYSByZXF1ZXN0DQpxdWV1ZSwgZXhjZXB0IGZvciBwcm90 ZWN0aW5nIHRoZSB1bmRlcmxpbmluZyBkZXZpY2UgYmVpbmcgZGlzYWJsZWQgd2hpbGUNCmRpcmVj dF9hY2Nlc3MoKSBpcyBjYWxsZWQgKGIyZTBkMTYyNWUxOSkuIMKgDQoNCkFib3V0IHByb3RlY3Rp bmcgZGlyZWN0X2FjY2VzcywgdGhpcyBwYXRjaCBhc3N1bWVzIHRoYXQgdGhlIHVuZGVybGluaW5n DQpkZXZpY2UgY2Fubm90IGJlIGRpc2FibGVkIHVudGlsIGR0cigpIGlzIGNhbGxlZC4gwqBJcyB0 aGlzIGNvcnJlY3Q/IMKgSWYgbm90LA0KSSB3aWxsIG5lZWQgdG8gY2FsbMKgZGF4X21hcF9hdG9t aWMoKS4NCg0KVGhhbmtzLA0KLVRvc2hpwqAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1A bGlzdHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt bnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbcFUQAt (ORCPT ); Tue, 21 Jun 2016 12:00:49 -0400 Received: from mail-bn1bon0111.outbound.protection.outlook.com ([157.56.111.111]:48736 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750707AbcFUQAq (ORCPT ); Tue, 21 Jun 2016 12:00:46 -0400 X-Greylist: delayed 69254 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Jun 2016 12:00:46 EDT From: "Kani, Toshimitsu" To: "axboe@fb.com" , "snitzer@redhat.com" CC: "linux-kernel@vger.kernel.org" , "sandeen@redhat.com" , "linux-nvdimm@ml01.01.org" , "agk@redhat.com" , "linux-raid@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "dan.j.williams@intel.com" , "axboe@kernel.dk" , "ross.zwisler@linux.intel.com" , "dm-devel@redhat.com" Subject: Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Thread-Topic: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Thread-Index: AQHRxcNvFc0gDtWw/UKSuO/qIYbBN5/oAoaAgAqtRoCAAAWsgIAAFjAAgAADUICAAAKLgIAAFViAgAASHACAAQDRgIAAH4oA Date: Tue, 21 Jun 2016 15:44:54 +0000 Message-ID: <1466523280.3504.262.camel@hpe.com> References: <1465856497-19698-1-git-send-email-toshi.kani@hpe.com> <20160613225756.GA18417@redhat.com> <20160620180043.GA21261@redhat.com> <1466446861.3504.243.camel@hpe.com> <20160620194026.GA21657@redhat.com> <20160620195217.GB21657@redhat.com> <1466452883.3504.244.camel@hpe.com> <1466457467.3504.249.camel@hpe.com> <20160620222236.GA22461@redhat.com> <20160621134147.GA26392@redhat.com> In-Reply-To: <20160621134147.GA26392@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 12d6cbcf-021c-49e9-c7f0-08d399eafd79 x-microsoft-exchange-diagnostics: 1;CS1PR84MB0007;6:hvPJQKOkt/+a5SftVWLQIy5ZpRgXKz/1X09NUnDw5IYyZpW5tgvmQyClFdSDE/M0Sxl/8rGaQSlckfXkdRBVkM/FIkASPnHxq4LQcF5fXdO3GNUjVoilxDg1szuXeVQ+W0FN6utTwqK5myZFrcGYzEyNI6Id3lygdT+IItimle0thkJUfsj0Bna/JKbbnTu2sRoHLMO358BsZx99oOl8Oeq8LXAtOpG7kty2YzXLcRugmYzoSdwCzkO2PmYSwdHXBFTLTi/FnA5EYwWOw2USq5VQHIRSI7I8sYYLNcTtLEk=;5:PIgIjhlgigwhsLuCYDX4IxulMfe+R6jGS+g42K1/K/3AUpzbKvoEr+Jz+0GP1ImR69USqdUmgwnMH4LpY2f3caaAqIlQb8f8BpRz9NFhA3n7EFyHdRZfFTMdI0N7Ei5Kz2aDFg6pLns3MzvOBIT9+g==;24:upeDpTIbM7JLdz581R+CB87YWX09Xy/niohfSIG8j1tMnNvhFPAHKZOdSr9vGhYe3AG8rUgqbn7WuW/yzN6nA0b5s7znq60mRqCavH2mspo=;7:C+lnxj0QWtnd/a4d5f9+eFFPW/bRPrTzZJTvoNk9dP0xz4eeQuZWJ9AHQl5SlyCl8IFoTUagN0Sl9vOVhdwIl76tD61CHlTQUPtACcvTZkrS5xf4Atttkv+8hd/AGJNqGvSUk4fbdRkOqkrECRUi8D78ulfjI/GwFuRGcLhso1Np5n8NQuXtyfB9RoerC7at19A7zYr64bA4ivg3ei1aNXxyRNEZoZZ2Hikybtvq570oc1wd1FF5kfOdeH9+i4wX x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:CS1PR84MB0007;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-forefront-prvs: 098076C36C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(24454002)(377424004)(199003)(189002)(87936001)(11100500001)(8676002)(101416001)(2501003)(575784001)(103116003)(86362001)(93886004)(189998001)(36756003)(122556002)(81156014)(3280700002)(76176999)(50986999)(7736002)(106116001)(54356999)(66066001)(105586002)(68736007)(7846002)(106356001)(92566002)(8936002)(99286002)(19580405001)(19580395003)(33646002)(5002640100001)(6116002)(77096005)(3846002)(102836003)(5001770100001)(2906002)(10400500002)(97736004)(3660700001)(2950100001)(81166006)(4326007)(2900100001)(586003);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0007;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <3237E4E187B56D43BE612A6598212E91@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2016 15:44:54.2825 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0007 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5LG0tKn002572 On Tue, 2016-06-21 at 09:41 -0400, Mike Snitzer wrote: > On Mon, Jun 20 2016 at  6:22pm -0400, > Mike Snitzer wrote: > > > > On Mon, Jun 20 2016 at  5:28pm -0400, > > Kani, Toshimitsu wrote: > >  : > > Looks good, I folded it in and tested it to work.  Pushed to my 'wip' > > branch. > > > > No longer seeing any corruption in my test that was using partitions to > > span pmem devices with a dm-linear device. > > > > Jens, any chance you'd be open to picking up the first 2 patches in this > > series?  Or would you like to see them folded or something different? > > I'm now wondering if we'd be better off setting a new QUEUE_FLAG_DAX > rather than establish GENHD_FL_DAX on the genhd? > > It'd be quite a bit easier to allow upper layers (e.g. XFS and ext4) to > check for a queue flag. I think GENHD_FL_DAX is more appropriate since DAX does not use a request queue, except for protecting the underlining device being disabled while direct_access() is called (b2e0d1625e19).   About protecting direct_access, this patch assumes that the underlining device cannot be disabled until dtr() is called.  Is this correct?  If not, I will need to call dax_map_atomic(). Thanks, -Toshi