From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kani, Toshimitsu" Subject: Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Date: Tue, 21 Jun 2016 16:56:03 +0000 Message-ID: <1466527550.3504.273.camel@hpe.com> References: <1465856497-19698-1-git-send-email-toshi.kani@hpe.com> <20160613225756.GA18417@redhat.com> <20160620180043.GA21261@redhat.com> <1466446861.3504.243.camel@hpe.com> <20160620194026.GA21657@redhat.com> <20160620195217.GB21657@redhat.com> <1466452883.3504.244.camel@hpe.com> <1466457467.3504.249.camel@hpe.com> <20160620222236.GA22461@redhat.com> <20160621134147.GA26392@redhat.com> <1466523280.3504.262.camel@hpe.com> <1466526342.3504.270.camel@hpe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" Cc: "axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org" , "sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "axboe-b10kYP2dOMg@public.gmane.org" , "linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org" , "agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" List-Id: dm-devel.ids T24gVHVlLCAyMDE2LTA2LTIxIGF0IDA5OjQ1IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IE9uIFR1ZSwgSnVuIDIxLCAyMDE2IGF0IDk6MzUgQU0sIEthbmksIFRvc2hpbWl0c3UgPHRvc2hp LmthbmlAaHBlLmNvbT4NCj4gd3JvdGU6DQo+ID4gT24gVHVlLCAyMDE2LTA2LTIxIGF0IDA5OjI1 IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ID4gPiBPbiBUdWUsIEp1biAyMSwgMjAxNiBh dCA4OjQ0IEFNLCBLYW5pLCBUb3NoaW1pdHN1IDx0b3NoaS5rYW5pQGhwZS5jb20+DQo+ID4gPiB3 cm90ZToNCj4gPiA+ID4gDQrCoDoNCj4gPiA+ID4gSSB0aGluayBHRU5IRF9GTF9EQVggaXMgbW9y ZSBhcHByb3ByaWF0ZSBzaW5jZSBEQVggZG9lcyBub3QgdXNlIGENCj4gPiA+ID4gcmVxdWVzdCBx dWV1ZSwgZXhjZXB0IGZvciBwcm90ZWN0aW5nIHRoZSB1bmRlcmxpbmluZyBkZXZpY2UgYmVpbmcN Cj4gPiA+ID4gZGlzYWJsZWQgd2hpbGUgZGlyZWN0X2FjY2VzcygpIGlzIGNhbGxlZCAoYjJlMGQx NjI1ZTE5KS4NCj4gPiA+ID4gDQo+ID4gPiA+IEFib3V0IHByb3RlY3RpbmcgZGlyZWN0X2FjY2Vz cywgdGhpcyBwYXRjaCBhc3N1bWVzIHRoYXQgdGhlDQo+ID4gPiA+IHVuZGVybGluaW5nIGRldmlj ZSBjYW5ub3QgYmUgZGlzYWJsZWQgdW50aWwgZHRyKCkgaXMgY2FsbGVkLsKgwqBJcyB0aGlzDQo+ ID4gPiA+IGNvcnJlY3Q/wqDCoElmIG5vdCwgSSB3aWxsIG5lZWQgdG8gY2FsbCBkYXhfbWFwX2F0 b21pYygpLg0KPiA+ID4NCj4gPiA+IEtlcm5lbCBpbnRlcm5hbCB1c2FnZXMgb2YgZGF4IHNob3Vs ZCBiZSB1c2luZyBkYXhfbWFwX2F0b21pYygpIHRvDQo+ID4gPiBzYWZlbHkgcmVzb2x2ZSBkZXZp Y2UgcmVtb3ZhbCByYWNlcy4NCj4gPg0KPiA+IFdpbGwgZG8uwqDCoEluIHN1Y2ggY2FzZSwgc2hh bGwgSSBtb3ZlIGRheF9bdW5dbWFwX2F0b21pYygpIHRvIGJsb2NrX2Rldi5jDQo+ID4gYW5kIHJl bmFtZSB0aGVtIHRvIGJkZXZfZGF4X1t1bl1tYXBfYXRvbWljKCk/DQo+DQo+IFNvdW5kcyBnb29k IHRvIG1lLsKgwqBJIGtub3cgSmVmZiBhbmQgQ2hyaXN0b3BoIGRvbid0IGxpa2UgdGhlIGN1cnJl bnQNCj4gY2FsbGluZyBjb252ZW50aW9uIG9mIHBhc3NpbmcgaW4gYSBzdHJ1Y3R1cmUuwqDCoEp1 c3Qgbm90ZSB0aGF0IHRoZXkNCj4gbWlnaHQgYXNrIHlvdSB0byBjaGFuZ2UgaXQgYmFjayB0byBh IGxpc3Qgb2YgcGFyYW1ldGVycyBpZiBpdCBtb3ZlcyB0bw0KPiBiZGV2X2RheF9tYXBfYXRvbWlj KCkuDQoNCk9LLCBJIHdpbGwgY2hhbmdlIGl0IGJhY2sgdG8gYSBsaXN0IG9mIHBhcmFtZXRlcnMg YXMgd2VsbC4NCg0KVGhhbmtzLA0KLVRvc2hpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5nIGxpc3QKTGludXgtbnZkaW1t QGxpc3RzLjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LW52ZGltbQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752927AbcFURPi (ORCPT ); Tue, 21 Jun 2016 13:15:38 -0400 Received: from mail-bl2on0147.outbound.protection.outlook.com ([65.55.169.147]:18017 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752027AbcFUROQ (ORCPT ); Tue, 21 Jun 2016 13:14:16 -0400 X-Greylist: delayed 72340 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Jun 2016 13:13:38 EDT From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" CC: "linux-kernel@vger.kernel.org" , "sandeen@redhat.com" , "linux-nvdimm@ml01.01.org" , "agk@redhat.com" , "linux-raid@vger.kernel.org" , "snitzer@redhat.com" , "viro@zeniv.linux.org.uk" , "axboe@kernel.dk" , "axboe@fb.com" , "ross.zwisler@linux.intel.com" , "dm-devel@redhat.com" Subject: Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Thread-Topic: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Thread-Index: AQHRxcNvFc0gDtWw/UKSuO/qIYbBN5/oAoaAgAqtRoCAAAWsgIAAFjAAgAADUICAAAKLgIAAFViAgAASHACAAQDRgIAAH4oAgAAOIQCAAAAhAIAABYyAgAAAFQA= Date: Tue, 21 Jun 2016 16:56:03 +0000 Message-ID: <1466527550.3504.273.camel@hpe.com> References: <1465856497-19698-1-git-send-email-toshi.kani@hpe.com> <20160613225756.GA18417@redhat.com> <20160620180043.GA21261@redhat.com> <1466446861.3504.243.camel@hpe.com> <20160620194026.GA21657@redhat.com> <20160620195217.GB21657@redhat.com> <1466452883.3504.244.camel@hpe.com> <1466457467.3504.249.camel@hpe.com> <20160620222236.GA22461@redhat.com> <20160621134147.GA26392@redhat.com> <1466523280.3504.262.camel@hpe.com> <1466526342.3504.270.camel@hpe.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 7643a52c-114f-4f98-c71c-08d399f4ee3e x-microsoft-exchange-diagnostics: 1;CS1PR84MB0007;6:oAa+f6bhUmB42OB1ztl6CuD54RHr2kzGtWQd/dflceXqUBzTEnOiaa+PB43u9/w/DuEHdei8gHDYIze/sb/Uz+qeCb0yyiaQvBaUUhTsn7QnTub/3XnjN1dshYFDjuK0saWQEUv4OJzSK2RM842zvN9FAewYdwC+BRY+hY0OwBiRTHt72qM/QTq4wCsJkUiCrlco/Hy1swS+1rFGQcm8Cmbdju1JguVNngKOa2rvTvC5ZJYPkJSJ32m+T3E8Begns5cOBr9uzomXuglb7EI71LiYfKg5Vz444s9usYOYmg4=;5:BtCDOP0eBrodcxAlvwl+0MD5t629mPTOpZRPi0YPSejdwWrTF7eYh2pffqIHAQF4EEUY+lMXk4UvA4iUMgYH6BtLHXuHxZlkd0p2H+ybOiQn3jo4XdFGCgpkJng525PTToZMuLxdjLoCiOYFz9nYHA==;24:dkGI3cuDbxICImAhTc7xc7ACIl1yR+ZvijTmew3fgRhhVM7Q1yzQWMF+Xyoc/7XsdYnNrL4TzNG1+klH/ajEV/HbBxX1HOmrJ9o0F8IVPOA=;7:IGb/h0WKzmvjakcQd38eRHG3EiTF52Wu+VdRd/fo6Q93SY94o+f7JbrIKSQPvkUtc5HgIJs6tY0bwQGQGj8gxZknU5AjBBUVQduMVt1/u1czn1M4cC5ojCHReracScS/rrZNVtgiWL0p+EX7bxY6u36/WDhSjOPEaVXWUhTARdEeiilXzTKSqJiZsWUeyFizSyXd267u+Nwgk5EpWHQ9xChwkb8x0sV6B2nFPHRwGXgIHZoj4lWvwLR0PqrdbPQ5 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:CS1PR84MB0007;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-forefront-prvs: 098076C36C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(199003)(189002)(377454003)(377424004)(24454002)(6116002)(5002640100001)(33646002)(102836003)(3846002)(77096005)(99286002)(19580405001)(19580395003)(2900100001)(4326007)(81166006)(586003)(10400500002)(2906002)(110136002)(3660700001)(2950100001)(97736004)(189998001)(36756003)(81156014)(3280700002)(122556002)(101416001)(11100500001)(87936001)(5640700001)(8676002)(86362001)(93886004)(103116003)(575784001)(2501003)(106356001)(105586002)(7846002)(68736007)(92566002)(8936002)(76176999)(50986999)(66066001)(2351001)(7736002)(54356999)(106116001);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0007;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2016 16:56:03.6712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0007 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5LHFhhd003262 On Tue, 2016-06-21 at 09:45 -0700, Dan Williams wrote: > On Tue, Jun 21, 2016 at 9:35 AM, Kani, Toshimitsu > wrote: > > On Tue, 2016-06-21 at 09:25 -0700, Dan Williams wrote: > > > On Tue, Jun 21, 2016 at 8:44 AM, Kani, Toshimitsu > > > wrote: > > > >  : > > > > I think GENHD_FL_DAX is more appropriate since DAX does not use a > > > > request queue, except for protecting the underlining device being > > > > disabled while direct_access() is called (b2e0d1625e19). > > > > > > > > About protecting direct_access, this patch assumes that the > > > > underlining device cannot be disabled until dtr() is called.  Is this > > > > correct?  If not, I will need to call dax_map_atomic(). > > > > > > Kernel internal usages of dax should be using dax_map_atomic() to > > > safely resolve device removal races. > > > > Will do.  In such case, shall I move dax_[un]map_atomic() to block_dev.c > > and rename them to bdev_dax_[un]map_atomic()? > > Sounds good to me.  I know Jeff and Christoph don't like the current > calling convention of passing in a structure.  Just note that they > might ask you to change it back to a list of parameters if it moves to > bdev_dax_map_atomic(). OK, I will change it back to a list of parameters as well. Thanks, -Toshi