From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kani, Toshimitsu" Subject: Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Date: Wed, 22 Jun 2016 22:59:10 +0000 Message-ID: <1466635735.3504.344.camel@hpe.com> References: <20160620195217.GB21657@redhat.com> <1466452883.3504.244.camel@hpe.com> <1466457467.3504.249.camel@hpe.com> <20160620222236.GA22461@redhat.com> <20160621134147.GA26392@redhat.com> <1466523280.3504.262.camel@hpe.com> <20160621181728.GA27821@redhat.com> <1466616868.3504.320.camel@hpe.com> <1466625958.3504.340.camel@hpe.com> <20160622223842.GA34512@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160622223842.GA34512-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Content-ID: <7375D22EC77408429172735B74BB16D5-mmYPd6ayCNGroOM5E8FhRbjFIynDaujOfM0AETQt39g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org" , "sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "axboe-b10kYP2dOMg@public.gmane.org" , "linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org" , "agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" List-Id: dm-devel.ids T24gV2VkLCAyMDE2LTA2LTIyIGF0IDE4OjM4IC0wNDAwLCBNaWtlIFNuaXR6ZXIgd3JvdGU6DQo+ IE9uIFdlZCwgSnVuIDIyIDIwMTYgYXTCoMKgNDoxNlAgLTA0MDAsDQo+IEthbmksIFRvc2hpbWl0 c3UgPHRvc2hpLmthbmlAaHBlLmNvbT4gd3JvdGU6DQo+ID4gDQo+ID4gT24gV2VkLCAyMDE2LTA2 LTIyIGF0IDEyOjE1IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ID4gPiANCj4gPiA+IE9u IFdlZCwgSnVuIDIyLCAyMDE2IGF0IDEwOjQ0IEFNLCBLYW5pLCBUb3NoaW1pdHN1IDx0b3NoaS5r YW5pQGhwZS5jb20+DQo+ID4gPiB3cm90ZToNCj4gPiA+ID4gDQo+ID4gPiA+IE9uIFR1ZSwgMjAx Ni0wNi0yMSBhdCAxNDoxNyAtMDQwMCwgTWlrZSBTbml0emVyIHdyb3RlOg0KPiA+ID4gPiA+IA0K PiA+ID4gPiA+IE9uIFR1ZSwgSnVuIDIxIDIwMTYgYXQgMTE6NDRhbSAtMDQwMCwNCj4gPiA+ID4g PiBLYW5pLCBUb3NoaW1pdHN1IDx0b3NoaS5rYW5pQGhwZS5jb20+IHdyb3RlOg0KPiA+ID4gPiA+ ID4gDQo+ID4gPiA+ID4gPiBPbiBUdWUsIDIwMTYtMDYtMjEgYXQgMDk6NDEgLTA0MDAsIE1pa2Ug U25pdHplciB3cm90ZToNCj4gPiA+ID4gPiA+ID7CoA0KPiA+ID4gPiA+IFRoZSBkZXZpY2VzIGlu IHF1ZXN0aW9uIGhhdmUgYSByZXF1ZXN0X3F1ZXVlLsKgwqBBbGwgYmlvLWJhc2VkIGRldmljZQ0K PiA+ID4gPiA+IGhhdmUgYSByZXF1ZXN0X3F1ZXVlLg0KPiA+ID4gPsKgDQo+ID4gPiA+IERBWC1j YXBhYmxlIGRldmljZXMgaGF2ZSB0d28gb3BlcmF0aW9uIG1vZGVzLCBiaW8tYmFzZWQgYW5kIERB WC7CoMKgSQ0KPiA+ID4gPiBhZ3JlZSB0aGF0IGJpby1iYXNlZCBvcGVyYXRpb24gaXMgYXNzb2Np YXRlZCB3aXRoIGEgcmVxdWVzdCBxdWV1ZSwgYW5kDQo+ID4gPiA+IGl0cyBjYXBhYmlsaXRpZXMg c2hvdWxkIGJlIHNldCB0byBpdC7CoMKgREFYLCBvbiB0aGUgb3RoZXIgaGFuZCwgaXMNCj4gPiA+ ID4gcmF0aGVyIGluZGVwZW5kZW50IGZyb20gYSByZXF1ZXN0IHF1ZXVlLg0KPiA+ID4gPiANCj4g PiA+ID4gPiANCj4gPiA+ID4gPiBJIGRvbid0IGhhdmUgYSBiaWcgcHJvYmxlbSB3aXRoIEdFTkhE X0ZMX0RBWC7CoMKgSnVzdCB3YW50ZWQgdG8gcG9pbnQNCj4gPiA+ID4gPiBvdXQgdGhhdCBzdWNo IGJsb2NrIGRldmljZSBjYXBhYmlsaXRpZXMgYXJlIGdlbmVyYWxseSBhZHZlcnRpc2VkIGluDQo+ ID4gPiA+ID4gdGVybXMgb2YgYSBRVUVVRV9GTEFHLg0KPiA+ID4gPsKgDQo+ID4gPiA+IEkgZG8g bm90IGhhdmUgYSBzdHJvbmcgb3BpbmlvbiwgYnV0IGZlZWwgYSBiaXQgb2RkIHRvIGFzc29jaWF0 ZSBEQVggdG8NCj4gPiA+ID4gYSByZXF1ZXN0IHF1ZXVlLg0KPiA+ID4NCj4gPiA+IEdpdmVuIHRo YXQgd2UgZG8gbm90IHN1cHBvcnQgZGF4IHRvIGEgcmF3IGJsb2NrIGRldmljZSBbMV0gaXQgc2Vl bXMgYQ0KPiA+ID4gZ2VuZGlzayBmbGFnIGlzIG1vcmUgbWlzbGVhZGluZyB0aGFuIHJlcXVlc3Rf cXVldWUgZmxhZyB0aGF0IHNwZWNpZmllcw0KPiA+ID4gd2hhdCByZXF1ZXN0cyBjYW4gYmUgbWFk ZSBvZiB0aGUgZGV2aWNlLg0KPiA+ID4gDQo+ID4gPiBbMV06IGFjYzkzZDMwZDdkNCBSZXZlcnQg ImJsb2NrOiBlbmFibGUgZGF4IGZvciByYXcgYmxvY2sgZGV2aWNlcyINCj4gPg0KPiA+IE9oLCBJ IHNlZS4gwqBJIHdpbGwgY2hhbmdlIHRvIHVzZSByZXF1ZXN0X3F1ZXVlIGZsYWcuDQo+DQo+IEkg aW1wbGVtZW50ZWQgdGhlIGJsb2NrIHBhdGNoIGZvciB0aGlzIHllc3RlcmRheSBidXQgYmFzZWQg b24geW91cg0KPiBmZWVkYmFjayBJIHN0b3BwZWQgdGhlcmUgKGRpZG4ndCBjYXJyeSB0aGUgY2hh bmdlIHRocm91Z2ggdG8gdGhlIERNIGNvcmUNCj4gYW5kIERNIGxpbmVhciAtLSBjYW4gZWFzaWx5 IGRvIHNvIHRvbW9ycm93IHRob3VnaCkuDQo+IA0KPiBGZWVsIGZyZWUgdG8gdXNlIHRoaXMgYXMg YSBzdGFydGluZyBwb2ludCBhbmQgZml4L2V4dGVuZCBhbmQgYWRkIGENCj4gcHJvcGVyIGhlYWRl cjoNCg0KVGhhbmtzIE1pa2UhIEkgbWFkZSBzaW1pbGFyIGNoYW5nZXMgYXMgd2VsbC4gSSB3aWxs IHRha2UgeW91cnMgYW5kIGZpbmlzaCB1cA0KdGhlIHJlc3QuIDopDQotVG9zaGkKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxp bmcgbGlzdApMaW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbcFVXP2 (ORCPT ); Wed, 22 Jun 2016 19:15:28 -0400 Received: from mail-bn1bon0141.outbound.protection.outlook.com ([157.56.111.141]:36736 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752413AbcFVXOg (ORCPT ); Wed, 22 Jun 2016 19:14:36 -0400 From: "Kani, Toshimitsu" To: "snitzer@redhat.com" CC: "linux-kernel@vger.kernel.org" , "sandeen@redhat.com" , "linux-nvdimm@ml01.01.org" , "agk@redhat.com" , "linux-raid@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "dan.j.williams@intel.com" , "axboe@fb.com" , "axboe@kernel.dk" , "ross.zwisler@linux.intel.com" , "dm-devel@redhat.com" Subject: Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Thread-Topic: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Thread-Index: AQHRxcNvFc0gDtWw/UKSuO/qIYbBN5/oAoaAgAqtRoCAAAWsgIAAFjAAgAADUICAAAKLgIAAFViAgAASHACAAQDRgIAAH4oAgAAtfQCAAYZRAIAAHDSAgAAOIACAACqsAIAAAtuA Date: Wed, 22 Jun 2016 22:59:10 +0000 Message-ID: <1466635735.3504.344.camel@hpe.com> References: <20160620195217.GB21657@redhat.com> <1466452883.3504.244.camel@hpe.com> <1466457467.3504.249.camel@hpe.com> <20160620222236.GA22461@redhat.com> <20160621134147.GA26392@redhat.com> <1466523280.3504.262.camel@hpe.com> <20160621181728.GA27821@redhat.com> <1466616868.3504.320.camel@hpe.com> <1466625958.3504.340.camel@hpe.com> <20160622223842.GA34512@redhat.com> In-Reply-To: <20160622223842.GA34512@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 8b611fb2-a308-4762-8fe4-08d39af0d294 x-microsoft-exchange-diagnostics: 1;CS1PR84MB0008;6:9q2Tz67bgxo1hT5FoZUtFV1CFN7Uj/Gz5tzttJ/NLuBXtN+wxNxWikKBXkKyFdZtboRnKqwPYwxNT+ITfZ2a+Aa55ceaxdw6Q98eKISCOYef5uYYiOt4sYf1AU3eq8G+j3URIVd0llEyaXlTeEZkxCKICo/d/fSHFrjidr6lVPA05Aq3u8JfzXhykt7b+6zJmYV4srRA7ppKg433FTqXrfy+dtCthBj97KoZyC1dEJ5222PmE9OZgUnQvRGtoxK0EclXhqgWPJ0/ezoDjTWLVnmyW7M4WNkdgTJJwlWqxMT+DGIP4RupGOP4RjuQnpgK;5:u2a06x8vLqASLeNzwN+E1XGuvtLqL/0Z7f3lcCz89b2E0lFkeXJdgItuPtJBSC+kO8X/VZBilusi3SDtwEE+wLsnLiiL+yuOfO++KHAyzYAxoVyOSl7t0gslzyA9OLz+8ZYYVS/m/DgO6AcQ6ZzhIw==;24:oZEtNq5ehrBuDk2J06VvFnFvCbRb8F3ax19vzqZCh3UyINxr041KBar6slyDIPgee9nVFOetvr5pRrakMaKHZQcq56acR4sOpmmywyp1cLA=;7:DCMYKgldp5i0Lt1NMuujl+2OltiQr2yulWbjMfvQFag39DteX5eKkvFhYM4kfsgP5yxYspW+ILDh2bkhJmW+lJ1BHfxToBqf/5aRcSJFmYX+gyQ4DJaSCgJFI3R/QL3PGkH2bJ3Wvf+VBdYZTLHqly7b6wsJgTTET/EzCV2GLha7K+NY/mHXpTkTCEF/oqEqUSAFazfYfUsUhqQxczYPKUStSExWiUXg2/b+MoCvpvDKvl6J84cu+QPFW3Fg8KONlxDJpEtPTiyIbs6S71WQqQ== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0008; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CS1PR84MB0008;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0008; x-forefront-prvs: 0981815F2F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(377424004)(189002)(199003)(24454002)(52044002)(51694002)(377454003)(92566002)(1730700003)(8676002)(2501003)(2950100001)(4326007)(81166006)(189998001)(68736007)(81156014)(6116002)(2906002)(66066001)(87936001)(7846002)(86362001)(5002640100001)(50986999)(3280700002)(2900100001)(76176999)(2351001)(3660700001)(77096005)(11100500001)(54356999)(122556002)(586003)(10400500002)(106356001)(101416001)(110136002)(97736004)(19580395003)(105586002)(8936002)(103116003)(19580405001)(36756003)(33646002)(3846002)(102836003)(5640700001)(99286002)(106116001)(93886004)(7736002)(305945005);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0008;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <7375D22EC77408429172735B74BB16D5@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2016 22:59:10.1999 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0008 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5MNFYBP014448 On Wed, 2016-06-22 at 18:38 -0400, Mike Snitzer wrote: > On Wed, Jun 22 2016 at  4:16P -0400, > Kani, Toshimitsu wrote: > > > > On Wed, 2016-06-22 at 12:15 -0700, Dan Williams wrote: > > > > > > On Wed, Jun 22, 2016 at 10:44 AM, Kani, Toshimitsu > > > wrote: > > > > > > > > On Tue, 2016-06-21 at 14:17 -0400, Mike Snitzer wrote: > > > > > > > > > > On Tue, Jun 21 2016 at 11:44am -0400, > > > > > Kani, Toshimitsu wrote: > > > > > > > > > > > > On Tue, 2016-06-21 at 09:41 -0400, Mike Snitzer wrote: > > > > > > >  > > > > > The devices in question have a request_queue.  All bio-based device > > > > > have a request_queue. > > > >  > > > > DAX-capable devices have two operation modes, bio-based and DAX.  I > > > > agree that bio-based operation is associated with a request queue, and > > > > its capabilities should be set to it.  DAX, on the other hand, is > > > > rather independent from a request queue. > > > > > > > > > > > > > > I don't have a big problem with GENHD_FL_DAX.  Just wanted to point > > > > > out that such block device capabilities are generally advertised in > > > > > terms of a QUEUE_FLAG. > > > >  > > > > I do not have a strong opinion, but feel a bit odd to associate DAX to > > > > a request queue. > > > > > > Given that we do not support dax to a raw block device [1] it seems a > > > gendisk flag is more misleading than request_queue flag that specifies > > > what requests can be made of the device. > > > > > > [1]: acc93d30d7d4 Revert "block: enable dax for raw block devices" > > > > Oh, I see.  I will change to use request_queue flag. > > I implemented the block patch for this yesterday but based on your > feedback I stopped there (didn't carry the change through to the DM core > and DM linear -- can easily do so tomorrow though). > > Feel free to use this as a starting point and fix/extend and add a > proper header: Thanks Mike! I made similar changes as well. I will take yours and finish up the rest. :) -Toshi