Re: [Qemu-devel] [PATCH 2/5] curses: Use cursesw when available

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

>  ##########################################
> +# cursesw probe
> +if test "$cursesw" != "no" ; then
> +  if test "$mingw32" = "yes" ; then
> +    cursesw_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):"
> +    cursesw_lib_list="$($pkg_config --libs ncursesw 2>/dev/null):-lpdcurses"
> +  else
> +    cursesw_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):"
> +    cursesw_lib_list="$($pkg_config --libs ncursesw 2>/dev/null):-lncursesw:-lcursesw:-lncurses:-lcurses"
> +  fi
> [ ... ]

Do we *really* want this mess?

Is there any curses implementation without wide char support which is
still relevant today?

Is there any curses implementation beside ncurses still relevant today?

/me boots the freebsd guest.
/me finds libcurses being symlinks to libncurses.

I'm tempted to say just require ncursesw and be done with it.
That will also avoid the #ifdef mess in the following patches.

cheers,
  Gerd