All of lore.kernel.org
 help / color / mirror / Atom feed
From: Allen Hung <allen_hung@dell.com>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Allen Hung <allen_hung@dell.com>
Subject: [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage"
Date: Thu, 23 Jun 2016 16:31:29 +0800	[thread overview]
Message-ID: <1466670690-77458-1-git-send-email-allen_hung@dell.com> (raw)

This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection
if device implements confidence usage")

The commit enables palm rejection for Win8 Precision Touchpad devices but
the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very
properly. This quirk is originally designed for some WIn7 touchscreens. Use
of this for a Win8 Precision Touchpad will cause unexpected pointer jumping
problem.

Signed-off-by: Allen Hung <allen_hung@dell.com>
---
 drivers/hid/hid-multitouch.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 95b7d61..4ef7006 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
 			mt_store_field(usage, td, hi);
 			return 1;
 		case HID_DG_CONFIDENCE:
-			if (cls->name == MT_CLS_WIN_8 &&
-				field->application == HID_DG_TOUCHPAD) {
-				cls->quirks &= ~MT_QUIRK_ALWAYS_VALID;
-				cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE;
-			}
 			mt_store_field(usage, td, hi);
 			return 1;
 		case HID_DG_TIPSWITCH:
-- 
2.7.4


             reply	other threads:[~2016-06-23  8:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23  8:31 Allen Hung [this message]
2016-06-23  8:31 ` [PATCH 2/2] HID: multitouch: enable palm rejection for Windows Precision Touchpad Allen Hung
2016-06-27 14:18   ` Benjamin Tissoires
2016-06-27 17:55 ` [PATCH 1/2] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" Andy Lutomirski
2016-06-27 22:25   ` Andy Lutomirski
2016-06-28 17:38     ` Andy Lutomirski
2016-06-28 11:26   ` Jiri Kosina
2016-06-27 22:13 ` [1/2] " Mario Limonciello
2016-06-29 18:31 ` Mario Limonciello
2016-06-30  7:39   ` Jiri Kosina
2016-06-30 14:43     ` Mario_Limonciello
2016-06-30 14:43       ` Mario_Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466670690-77458-1-git-send-email-allen_hung@dell.com \
    --to=allen_hung@dell.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.