From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Thu, 23 Jun 2016 07:25:32 -0400 Message-ID: <1466681132.2421.70.camel@HansenPartnership.com> References: <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <1466542819.2441.5.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1466542819.2441.5.camel@HansenPartnership.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: "Syrjala, Ville" , intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDE2LTA2LTIxIGF0IDE3OjAwIC0wNDAwLCBKYW1lcyBCb3R0b21sZXkgd3JvdGU6 Cj4gT24gVHVlLCAyMDE2LTA2LTIxIGF0IDE4OjQ0ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3Jv dGU6Cj4gPiBPbiBUdWUsIEp1biAyMSwgMjAxNiBhdCAwOTo1MzoxNUFNIC0wNDAwLCBKYW1lcyBC b3R0b21sZXkgd3JvdGU6Cj4gPiA+IE9uIE1vbiwgMjAxNi0wNi0yMCBhdCAxMTowMyArMDMwMCwg SmFuaSBOaWt1bGEgd3JvdGU6Cj4gPiA+ID4gQ2M6IFZpbGxlCj4gPiA+ID4gCj4gPiA+ID4gT24g TW9uLCAyMCBKdW4gMjAxNiwgSmFtZXMgQm90dG9tbGV5IDwKPiA+ID4gPiBKYW1lcy5Cb3R0b21s ZXlASGFuc2VuUGFydG5lcnNoaXAuY29tPiB3cm90ZToKPiA+ID4gPiA+IE9LLCBteSBjYW5kaWRh dGUgYmFkIGNvbW1pdCBpcyB0aGlzIG9uZToKPiA+ID4gPiA+IAo+ID4gPiA+ID4gY29tbWl0IGEw NTYyODE5NWEwZDlmMzE3M2RkOWFhNzZmNDgyYWVmNjkyZTQ2ZWUKPiA+ID4gPiA+IEF1dGhvcjog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gPiA+ IERhdGU6ICAgTW9uIEFwciAxMSAxMDoyMzo1MSAyMDE2ICswMzAwCj4gPiA+ID4gPiAKPiA+ID4g PiA+ICAgICBkcm0vaTkxNTogR2V0IHBhbmVsX3R5cGUgZnJvbSBPcFJlZ2lvbiBwYW5lbCBkZXRh aWxzCj4gPiA+ID4gPiAKPiA+ID4gPiA+IEFmdGVyIGJlaW5nIG1vcmUgY2FyZWZ1bCBhYm91dCB3 YWl0aW5nIHRvIGlkZW50aWZ5IGZsaWNrZXIsIAo+ID4gPiA+ID4gdGhpcyBvbmUgc2VlbXMgdG8g YmUgdGhlIG9uZSB0aGUgYmlzZWN0IGZpbmRzLiAgSSdtIG5vdyAKPiA+ID4gPiA+IHJ1bm5pbmcg djQuNy1yYzMgd2l0aCB0aGlzIG9uZSByZXZlcnRlZCBhbmQgYW0gY3VycmVudGx5IAo+ID4gPiA+ ID4gc2VlaW5nIG5vIGZsaWNrZXIgcHJvYmxlbXMuICAgSXQgaXMsIGhvd2V2ZXIsIGVhcmx5IGRh eXMgCj4gPiA+ID4gPiBiZWNhdXNlIHRoZSBmbGlja2VyIGNhbiBoaWRlIGZvciBsb25nIHBlcmlv ZHMsIHNvIEkgJ2xsIHdhaXQgCj4gPiA+ID4gPiB1bnRpbCBNb25kYXkgZXZlbmluZyBhbmQgYSBm ZXcgcmVib290cyBiZWZvcmUgZGVjbGFyaW5nCj4gPiA+ID4gPiB2aWN0b3J5Lgo+ID4gPiA+IAo+ ID4gPiA+IElmIHRoYXQgdHVybnMgb3V0IHRvIGJlIHRoZSBiYWQgY29tbWl0LCBpdCBkb2Vzbid0 IHJlYWxseSAKPiA+ID4gPiBzdXJwcmlzZSBtZSwgYW5kIHRoYXQgaW4gaXRzZWxmIGlzIGRlcHJl c3NpbmcuCj4gPiA+IAo+ID4gPiBBcyBmYXIgYXMgSSBjYW4gdGVsbCwgYWZ0ZXIgcnVubmluZyBm b3IgYSBkYXkgd2l0aCB0aGlzIHJldmVydGVkLAo+ID4gPiB0aGlzIGlzIHRoZSBwcm9ibGVtLiAg VGhlIGZsaWNrZXIgaGFzbid0IGFwcGVhcmVkIHdpdGggaXQgCj4gPiA+IHJldmVydGVkLiAgSXQn cyBwcmV0dHkgbm90aWNlYWJsZSB3aXRoIHRoaXMgY29tbWl0IGluY2x1ZGVkLgo+ID4gCj4gPiBI bW0uIFRoZSBvbmx5IGRpZmZlcmVuY2UgSSBjYW4gc2VlIGlzIGxvdyB2cy4gbm9ybWFsIHZzd2lu Zy4gUGFuZWwgCj4gPiAwIGhhcyBsb3csIHBhbmVsIDIgaGFzIG5vcm1hbC4gU28gZWl0aGVyIHRo ZSBWQlQgb3Igb3ByZWdpb24gaXMKPiA+IHRlbGxpbmcgdXR0ZXIgbGllcywgb3IgdGhlcmUncyBz b21lIG90aGVyIGJ1ZyBpbiBvdXIgbG93IHZzd2luZwo+ID4gc3VwcG9ydC4KPiA+IAo+ID4gVG8g Y29uZmlybSBpdCdzIHJlYWxseSBhIHZzd2luZyBpc3N1ZSwgeW91IHNob3VsZCBiZSBhYmxlIHRv IHJ1biAKPiA+IHdpdGggaTkxNS5lZHBfdnN3aW5nPTIgd2l0aG91dCBmbGlja2VycyBvbiB0aGUg YnJva2VuIGtlcm5lbC4KPiAKPiBQcmVsaW1pbmFyeSBib290IGluZGljYXRlcyBubyBmbGlja2Vy IHdpdGggdGhlIGJhZCBjb21taXQgaW5jbHVkZWQgCj4gYW5kIHRoaXMgb3B0aW9uLCBidXQgSSds bCBoYXZlIHRvIHJ1biBmb3IgcXVpdGUgYSBiaXQgbG9uZ2VyIHRvIAo+IHZlcmlmeSwgc2luY2Ug aXQgY2FuIHNvbWV0aW1lcyBiZSBlbHVzaXZlLgoKVHdvIGRheXMgb2YgcnVudGltZSBzZWVtcyB0 byBjb25maXJtIHRoaXMgaXMgdGhlIHByb2JsZW0gKHN0aWxsIG5vCmZsaWNrZXIgaXNzdWVzKS4K CkphbWVzCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751447AbcFWLZh (ORCPT ); Thu, 23 Jun 2016 07:25:37 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:52222 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbcFWLZg (ORCPT ); Thu, 23 Jun 2016 07:25:36 -0400 Message-ID: <1466681132.2421.70.camel@HansenPartnership.com> Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window From: James Bottomley To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: Jani Nikula , Daniel Vetter , intel-gfx , "Syrjala, Ville" , linux-kernel , dri-devel , Rodrigo Vivi Date: Thu, 23 Jun 2016 07:25:32 -0400 In-Reply-To: <1466542819.2441.5.camel@HansenPartnership.com> References: <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <1466542819.2441.5.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-06-21 at 17:00 -0400, James Bottomley wrote: > On Tue, 2016-06-21 at 18:44 +0300, Ville Syrjälä wrote: > > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > > Cc: Ville > > > > > > > > On Mon, 20 Jun 2016, James Bottomley < > > > > James.Bottomley@HansenPartnership.com> wrote: > > > > > OK, my candidate bad commit is this one: > > > > > > > > > > commit a05628195a0d9f3173dd9aa76f482aef692e46ee > > > > > Author: Ville Syrjälä > > > > > Date: Mon Apr 11 10:23:51 2016 +0300 > > > > > > > > > > drm/i915: Get panel_type from OpRegion panel details > > > > > > > > > > After being more careful about waiting to identify flicker, > > > > > this one seems to be the one the bisect finds. I'm now > > > > > running v4.7-rc3 with this one reverted and am currently > > > > > seeing no flicker problems. It is, however, early days > > > > > because the flicker can hide for long periods, so I 'll wait > > > > > until Monday evening and a few reboots before declaring > > > > > victory. > > > > > > > > If that turns out to be the bad commit, it doesn't really > > > > surprise me, and that in itself is depressing. > > > > > > As far as I can tell, after running for a day with this reverted, > > > this is the problem. The flicker hasn't appeared with it > > > reverted. It's pretty noticeable with this commit included. > > > > Hmm. The only difference I can see is low vs. normal vswing. Panel > > 0 has low, panel 2 has normal. So either the VBT or opregion is > > telling utter lies, or there's some other bug in our low vswing > > support. > > > > To confirm it's really a vswing issue, you should be able to run > > with i915.edp_vswing=2 without flickers on the broken kernel. > > Preliminary boot indicates no flicker with the bad commit included > and this option, but I'll have to run for quite a bit longer to > verify, since it can sometimes be elusive. Two days of runtime seems to confirm this is the problem (still no flicker issues). James