Re: [PATCH 1/2] xen: sched: rtds refactor code

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1349 bytes --]

On Thu, 2016-06-23 at 11:42 +0100, George Dunlap wrote:
> On 22/06/16 17:16, Meng Xu wrote:
> > 
> > I think he is trying to align those comments to make them start
> > from
> > the same column. I was confused at the reason at the very
> > beginning.
> > Then I pulled his repo and checked this change.
> Right -- well neither you as a reviewer nor anyone in the future
> looking
> back at this changeset should have to try to guess what the purpose
> was;
> if he did want to align them, that's perfectly fine, it just needs a
> brief mention in the changelog. :-)
> 
Indeed. BTW, I don't recall if we discussed this alignment
previously,neither, in case we did, what my position was back then :-P

In any case, I (now) think that having these comments aligned on a
per-struct base is just fine, and there really is no need to have _all_
of them aligned, across all structs.

I don't have a super strong opinion on this, and I'd be fine with it,
if Meng is. I just think it's not worth the effort (of patching,
reviewing, checking in, etc.)

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel