All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minfei Huang <mnghuan@gmail.com>
To: mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, Minfei Huang <mnghuan@gmail.com>,
	Minfei Huang <minfei.hmf@alibaba-inc.com>
Subject: [PATCH] virtio: Return correct errno for function init_vq's failure
Date: Mon, 27 Jun 2016 10:09:18 +0800	[thread overview]
Message-ID: <1466993358-12064-1-git-send-email-mnghuan@gmail.com> (raw)

The error number -ENOENT or 0 will be returned, if we can not allocate
more memory in function init_vq. If host can support multiple virtual
queues, and we fails to allocate necessary memory structures for vq,
kernel may crash due to incorrect returning.

To fix it, kernel will return correct value in init_vq.

Signed-off-by: Minfei Huang <mnghuan@gmail.com>
Signed-off-by: Minfei Huang <minfei.hmf@alibaba-inc.com>
---
 drivers/block/virtio_blk.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 42758b5..40ecb2b 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -393,11 +393,10 @@ static int init_vq(struct virtio_blk *vblk)
 	if (err)
 		num_vqs = 1;
 
+	err = -ENOMEM;
 	vblk->vqs = kmalloc(sizeof(*vblk->vqs) * num_vqs, GFP_KERNEL);
-	if (!vblk->vqs) {
-		err = -ENOMEM;
+	if (!vblk->vqs)
 		goto out;
-	}
 
 	names = kmalloc(sizeof(*names) * num_vqs, GFP_KERNEL);
 	if (!names)
-- 
2.7.4 (Apple Git-66)

             reply	other threads:[~2016-06-27  2:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27  2:09 Minfei Huang [this message]
2016-07-06  9:18 ` [PATCH] virtio: Return correct errno for function init_vq's failure Cornelia Huck
2016-07-13 11:54   ` Minfei Huang
2016-07-13 11:54     ` Minfei Huang
2016-07-13 12:05     ` Cornelia Huck
2016-07-13 12:05       ` Cornelia Huck
2016-07-06  9:18 ` Cornelia Huck
  -- strict thread matches above, loose matches on Subject: below --
2016-06-27  2:09 Minfei Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466993358-12064-1-git-send-email-mnghuan@gmail.com \
    --to=mnghuan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minfei.hmf@alibaba-inc.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.