From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750894AbcF0EBf (ORCPT ); Mon, 27 Jun 2016 00:01:35 -0400 Received: from smtprelay0005.hostedemail.com ([216.40.44.5]:50141 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750705AbcF0EBe (ORCPT ); Mon, 27 Jun 2016 00:01:34 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3872:4321:5007:6119:7875:7903:9707:10004:10400:10848:11658:11783:11914:12048:12517:12519:12555:12740:13069:13311:13357:13439:13894:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: shade36_d532143a6817 X-Filterd-Recvd-Size: 1810 Message-ID: <1467000090.1847.81.camel@perches.com> Subject: Re: [PATCH 2/2] mm: workingset: printk missing log level, use pr_info() From: Joe Perches To: Anton Blanchard , akpm@linux-foundation.org, oleg@redhat.com, hannes@cmpxchg.org, mingo@kernel.org, fweisbec@gmail.com, jkosina@suse.com Cc: linux-kernel@vger.kernel.org Date: Sun, 26 Jun 2016 21:01:30 -0700 In-Reply-To: <1466982072-29836-2-git-send-email-anton@ozlabs.org> References: <1466982072-29836-1-git-send-email-anton@ozlabs.org> <1466982072-29836-2-git-send-email-anton@ozlabs.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-27 at 09:01 +1000, Anton Blanchard wrote: > commit 612e44939c3c ("mm: workingset: eviction buckets for bigmem/lowbit > machines") added a printk without a log level. Quieten it by using > pr_info(). [] > diff --git a/mm/workingset.c b/mm/workingset.c [] > @@ -491,7 +491,7 @@ static int __init workingset_init(void) >   max_order = fls_long(totalram_pages - 1); >   if (max_order > timestamp_bits) >   bucket_order = max_order - timestamp_bits; > - printk("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n", > + pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n", >          timestamp_bits, max_order, bucket_order); Because it's possible to have more printks added, perhaps it's better to add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt before any #include and remove the "workingset: " prefix here.