diff for duplicates of <1467028835.30123.287.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 3933208..5ee1570 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -10,29 +10,29 @@ On Mon, 2016-06-27 at 04:49 -0700, Joe Perches wrote: > [] > > @@ -2567,15 +2567,15 @@ static char > > *hns_dsaf_get_node_stats_strings(char *data, int node, -> > ? buff += ETH_GSTRING_LEN; -> > ? if (node < DSAF_SERVICE_NW_NUM && !is_ver1) { -> > ? for (i = 0; i < DSAF_PRIO_NR; i++) { +> > buff += ETH_GSTRING_LEN; +> > if (node < DSAF_SERVICE_NW_NUM && !is_ver1) { +> > for (i = 0; i < DSAF_PRIO_NR; i++) { > > - snprintf(buff, ETH_GSTRING_LEN, -> > - ?"inod%d_pfc_prio%d_pkts", node, +> > - "inod%d_pfc_prio%d_pkts", node, > > i); > > - buff += ETH_GSTRING_LEN; > > - } > > - for (i = 0; i < DSAF_PRIO_NR; i++) { > > - snprintf(buff, ETH_GSTRING_LEN, -> > - ?"onod%d_pfc_prio%d_pkts", node, +> > - "onod%d_pfc_prio%d_pkts", node, > > i); > > + snprintf(buff + 0 * ETH_GSTRING_LEN * > > DSAF_PRIO_NR, -> > + ?ETH_GSTRING_LEN, +> > + ETH_GSTRING_LEN, > > "inod%d_pfc_prio%d_pkts", -> > + ?node, i); +> > + node, i); > > + snprintf(buff + 1 * ETH_GSTRING_LEN * > > DSAF_PRIO_NR, -> > + ?ETH_GSTRING_LEN, +> > + ETH_GSTRING_LEN, > > "onod%d_pfc_prio%d_pkts", -> > + ?node, i); -> > ? buff += ETH_GSTRING_LEN; +> > + node, i); +> > buff += ETH_GSTRING_LEN; > > This looks odd and likely incorrect. @@ -41,9 +41,9 @@ Why? the idea is to print stats for Rx and Tx at once. I hope it was tested. > -> > ? } +> > } > > + buff += 1 * DSAF_PRIO_NR * ETH_GSTRING_LEN; -> > ? } +> > } > -- diff --git a/a/content_digest b/N1/content_digest index 3226d09..ae9e9b5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,26 @@ "ref\01467021255-95900-1-git-send-email-Yisen.Zhuang@huawei.com\0" "ref\01467021255-95900-7-git-send-email-Yisen.Zhuang@huawei.com\0" "ref\01467028161.1847.101.camel@perches.com\0" - "From\0andriy.shevchenko@linux.intel.com (Andy Shevchenko)\0" - "Subject\0[PATCH net-next 6/9] net: hns: normalize two different loop\0" + "From\0Andy Shevchenko <andriy.shevchenko@linux.intel.com>\0" + "Subject\0Re: [PATCH net-next 6/9] net: hns: normalize two different loop\0" "Date\0Mon, 27 Jun 2016 15:00:35 +0300\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Joe Perches <joe@perches.com>" + Yisen Zhuang <Yisen.Zhuang@huawei.com> + davem@davemloft.net + salil.mehta@huawei.com + " yankejian@huawei.com\0" + "Cc\0liguozhu@huawei.com" + huangdaode@hisilicon.com + arnd@arndb.de + andrew@lunn.ch + geliangtang@163.com + ivecera@redhat.com + fengguang.wu@intel.com + charles.chenxin@huawei.com + netdev@vger.kernel.org + linux-kernel@vger.kernel.org + linux-arm-kernel@lists.infradead.org + " linuxarm@huawei.com\0" "\00:1\0" "b\0" "On Mon, 2016-06-27 at 04:49 -0700, Joe Perches wrote:\n" @@ -19,29 +35,29 @@ "> []\n" "> > @@ -2567,15 +2567,15 @@ static char\n" "> > *hns_dsaf_get_node_stats_strings(char *data, int node,\n" - "> > ?\tbuff += ETH_GSTRING_LEN;\n" - "> > ?\tif (node < DSAF_SERVICE_NW_NUM && !is_ver1) {\n" - "> > ?\t\tfor (i = 0; i < DSAF_PRIO_NR; i++) {\n" + "> > \302\240\tbuff += ETH_GSTRING_LEN;\n" + "> > \302\240\tif (node < DSAF_SERVICE_NW_NUM && !is_ver1) {\n" + "> > \302\240\t\tfor (i = 0; i < DSAF_PRIO_NR; i++) {\n" "> > -\t\t\tsnprintf(buff, ETH_GSTRING_LEN,\n" - "> > -\t\t\t\t?\"inod%d_pfc_prio%d_pkts\", node,\n" + "> > -\t\t\t\t\302\240\"inod%d_pfc_prio%d_pkts\", node,\n" "> > i);\n" "> > -\t\t\tbuff += ETH_GSTRING_LEN;\n" "> > -\t\t}\n" "> > -\t\tfor (i = 0; i < DSAF_PRIO_NR; i++) {\n" "> > -\t\t\tsnprintf(buff, ETH_GSTRING_LEN,\n" - "> > -\t\t\t\t?\"onod%d_pfc_prio%d_pkts\", node,\n" + "> > -\t\t\t\t\302\240\"onod%d_pfc_prio%d_pkts\", node,\n" "> > i);\n" "> > +\t\t\tsnprintf(buff + 0 * ETH_GSTRING_LEN *\n" "> > DSAF_PRIO_NR,\n" - "> > +\t\t\t\t?ETH_GSTRING_LEN,\n" + "> > +\t\t\t\t\302\240ETH_GSTRING_LEN,\n" "> > \"inod%d_pfc_prio%d_pkts\",\n" - "> > +\t\t\t\t?node, i);\n" + "> > +\t\t\t\t\302\240node, i);\n" "> > +\t\t\tsnprintf(buff + 1 * ETH_GSTRING_LEN *\n" "> > DSAF_PRIO_NR,\n" - "> > +\t\t\t\t?ETH_GSTRING_LEN,\n" + "> > +\t\t\t\t\302\240ETH_GSTRING_LEN,\n" "> > \"onod%d_pfc_prio%d_pkts\",\n" - "> > +\t\t\t\t?node, i);\n" - "> > ?\t\t\tbuff += ETH_GSTRING_LEN;\n" + "> > +\t\t\t\t\302\240node, i);\n" + "> > \302\240\t\t\tbuff += ETH_GSTRING_LEN;\n" "> \n" "> This looks odd and likely incorrect.\n" "\n" @@ -50,9 +66,9 @@ "I hope it was tested.\n" "\n" "> \n" - "> > ?\t\t}\n" + "> > \302\240\t\t}\n" "> > +\t\tbuff += 1 * DSAF_PRIO_NR * ETH_GSTRING_LEN;\n" - "> > ?\t}\n" + "> > \302\240\t}\n" "> \n" "\n" "-- \n" @@ -60,4 +76,4 @@ "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" Intel Finland Oy -9489de81bda40aca0fb6266937b995cdf34cf408b74dcc88ccb8733164416103 +51418ca9f70f13502d6fa22180c5be2fd06f96249a1234a7ce764cee3692d777
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.