diff for duplicates of <1467029589.30123.288.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index e5925c7..f6f03db 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,31 +18,31 @@ On Mon, 2016-06-27 at 05:08 -0700, Joe Perches wrote: > > > > > > > > @@ -2567,15 +2567,15 @@ static char > > > > *hns_dsaf_get_node_stats_strings(char *data, int node, -> > > > ? buff += ETH_GSTRING_LEN; -> > > > ? if (node < DSAF_SERVICE_NW_NUM && !is_ver1) { -> > > > ? for (i = 0; i < DSAF_PRIO_NR; i++) { +> > > > buff += ETH_GSTRING_LEN; +> > > > if (node < DSAF_SERVICE_NW_NUM && !is_ver1) { +> > > > for (i = 0; i < DSAF_PRIO_NR; i++) { > > > > - snprintf(buff, ETH_GSTRING_LEN, -> > > > - ?"inod%d_pfc_prio%d_pkts", +> > > > - "inod%d_pfc_prio%d_pkts", > > > > node, > > > > i); > > > > - buff += ETH_GSTRING_LEN; > > > > - } > > > > - for (i = 0; i < DSAF_PRIO_NR; i++) { > > > > - snprintf(buff, ETH_GSTRING_LEN, -> > > > - ?"onod%d_pfc_prio%d_pkts", +> > > > - "onod%d_pfc_prio%d_pkts", > > > > node, > > > > i); > > > > + snprintf(buff + 0 * ETH_GSTRING_LEN * > > > > DSAF_PRIO_NR, -> > > > + ?ETH_GSTRING_LEN, +> > > > + ETH_GSTRING_LEN, > > > > "inod%d_pfc_prio%d_pkts", -> > > > + ?node, i); +> > > > + node, i); > > > > + snprintf(buff + 1 * ETH_GSTRING_LEN * > > > > DSAF_PRIO_NR, -> > > > + ?ETH_GSTRING_LEN, +> > > > + ETH_GSTRING_LEN, > > > > "onod%d_pfc_prio%d_pkts", -> > > > + ?node, i); -> > > > ? buff += ETH_GSTRING_LEN; +> > > > + node, i); +> > > > buff += ETH_GSTRING_LEN; > > > This looks odd and likely incorrect. > > Why? the idea is to print stats for Rx and Tx at once. > > diff --git a/a/content_digest b/N1/content_digest index fbc6a3b..e500c45 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,10 +3,26 @@ "ref\01467028161.1847.101.camel@perches.com\0" "ref\01467028835.30123.287.camel@linux.intel.com\0" "ref\01467029338.1847.106.camel@perches.com\0" - "From\0andriy.shevchenko@linux.intel.com (Andy Shevchenko)\0" - "Subject\0[PATCH net-next 6/9] net: hns: normalize two different loop\0" + "From\0Andy Shevchenko <andriy.shevchenko@linux.intel.com>\0" + "Subject\0Re: [PATCH net-next 6/9] net: hns: normalize two different loop\0" "Date\0Mon, 27 Jun 2016 15:13:09 +0300\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Joe Perches <joe@perches.com>" + Yisen Zhuang <Yisen.Zhuang@huawei.com> + davem@davemloft.net + salil.mehta@huawei.com + " yankejian@huawei.com\0" + "Cc\0liguozhu@huawei.com" + huangdaode@hisilicon.com + arnd@arndb.de + andrew@lunn.ch + geliangtang@163.com + ivecera@redhat.com + fengguang.wu@intel.com + charles.chenxin@huawei.com + netdev@vger.kernel.org + linux-kernel@vger.kernel.org + linux-arm-kernel@lists.infradead.org + " linuxarm@huawei.com\0" "\00:1\0" "b\0" "On Mon, 2016-06-27 at 05:08 -0700, Joe Perches wrote:\n" @@ -29,31 +45,31 @@ "> > > > \n" "> > > > @@ -2567,15 +2567,15 @@ static char\n" "> > > > *hns_dsaf_get_node_stats_strings(char *data, int node,\n" - "> > > > ?\tbuff += ETH_GSTRING_LEN;\n" - "> > > > ?\tif (node < DSAF_SERVICE_NW_NUM && !is_ver1) {\n" - "> > > > ?\t\tfor (i = 0; i < DSAF_PRIO_NR; i++) {\n" + "> > > > \302\240\tbuff += ETH_GSTRING_LEN;\n" + "> > > > \302\240\tif (node < DSAF_SERVICE_NW_NUM && !is_ver1) {\n" + "> > > > \302\240\t\tfor (i = 0; i < DSAF_PRIO_NR; i++) {\n" "> > > > -\t\t\tsnprintf(buff, ETH_GSTRING_LEN,\n" - "> > > > -\t\t\t\t?\"inod%d_pfc_prio%d_pkts\",\n" + "> > > > -\t\t\t\t\302\240\"inod%d_pfc_prio%d_pkts\",\n" "> > > > node,\n" "> > > > i);\n" "> > > > -\t\t\tbuff += ETH_GSTRING_LEN;\n" "> > > > -\t\t}\n" "> > > > -\t\tfor (i = 0; i < DSAF_PRIO_NR; i++) {\n" "> > > > -\t\t\tsnprintf(buff, ETH_GSTRING_LEN,\n" - "> > > > -\t\t\t\t?\"onod%d_pfc_prio%d_pkts\",\n" + "> > > > -\t\t\t\t\302\240\"onod%d_pfc_prio%d_pkts\",\n" "> > > > node,\n" "> > > > i);\n" "> > > > +\t\t\tsnprintf(buff + 0 * ETH_GSTRING_LEN *\n" "> > > > DSAF_PRIO_NR,\n" - "> > > > +\t\t\t\t?ETH_GSTRING_LEN,\n" + "> > > > +\t\t\t\t\302\240ETH_GSTRING_LEN,\n" "> > > > \"inod%d_pfc_prio%d_pkts\",\n" - "> > > > +\t\t\t\t?node, i);\n" + "> > > > +\t\t\t\t\302\240node, i);\n" "> > > > +\t\t\tsnprintf(buff + 1 * ETH_GSTRING_LEN *\n" "> > > > DSAF_PRIO_NR,\n" - "> > > > +\t\t\t\t?ETH_GSTRING_LEN,\n" + "> > > > +\t\t\t\t\302\240ETH_GSTRING_LEN,\n" "> > > > \"onod%d_pfc_prio%d_pkts\",\n" - "> > > > +\t\t\t\t?node, i);\n" - "> > > > ?\t\t\tbuff += ETH_GSTRING_LEN;\n" + "> > > > +\t\t\t\t\302\240node, i);\n" + "> > > > \302\240\t\t\tbuff += ETH_GSTRING_LEN;\n" "> > > This looks odd and likely incorrect.\n" "> > Why? the idea is to print stats for Rx and Tx at once.\n" "> > \n" @@ -75,4 +91,4 @@ "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" Intel Finland Oy -bffa2bb14a6e7cdc895195766163fbdf47d0b105a87db15d8923fd0bc0b7515b +12c9ce3df35ee25c9c5767a604ebb21b43b6aece53189459b8c02dec86f2756b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.