From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Jisheng Zhang <jszhang@marvell.com>,
lenb@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] intel_pstate: Fix incorrect placement of __initdata
Date: Mon, 27 Jun 2016 10:19:04 -0700 [thread overview]
Message-ID: <1467047944.8970.79.camel@linux.intel.com> (raw)
In-Reply-To: <1467022038-924-2-git-send-email-jszhang@marvell.com>
On Mon, 2016-06-27 at 18:07 +0800, Jisheng Zhang wrote:
> __initdata should be placed between the variable name and equal sign
> (if there is) for the variable to be placed in the intended section.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index fe9dc17..44099e9 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1574,9 +1574,9 @@ static struct cpufreq_driver
> intel_pstate_driver = {
> .name = "intel_pstate",
> };
>
> -static int __initdata no_load;
> -static int __initdata no_hwp;
> -static int __initdata hwp_only;
> +static int no_load __initdata;
> +static int no_hwp __initdata;
> +static int hwp_only __initdata;
> static unsigned int force_load;
>
> static int intel_pstate_msrs_not_valid(void)
next prev parent reply other threads:[~2016-06-27 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 10:07 [PATCH v2 0/3] cpufreq: intel_pstate: trivial improvements Jisheng Zhang
2016-06-27 10:07 ` Jisheng Zhang
2016-06-27 10:07 ` [PATCH v2 1/3] intel_pstate: Fix incorrect placement of __initdata Jisheng Zhang
2016-06-27 10:07 ` Jisheng Zhang
2016-06-27 17:19 ` Srinivas Pandruvada [this message]
2016-06-27 10:07 ` [PATCH v2 2/3] intel_pstate: add __init/__initdata marker to some functions/variables Jisheng Zhang
2016-06-27 10:07 ` Jisheng Zhang
2016-06-27 17:26 ` Srinivas Pandruvada
2016-06-27 10:07 ` [PATCH v2 3/3] intel_pstate: Declare pid_params/pstate_funcs/hwp_active __read_mostly Jisheng Zhang
2016-06-27 10:07 ` Jisheng Zhang
2016-06-27 17:29 ` Srinivas Pandruvada
2016-06-28 2:29 ` Jisheng Zhang
2016-06-28 2:29 ` Jisheng Zhang
2016-06-28 11:43 ` Rafael J. Wysocki
2016-07-04 13:03 ` [PATCH v2 0/3] cpufreq: intel_pstate: trivial improvements Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467047944.8970.79.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=jszhang@marvell.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.