From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kani, Toshimitsu" Subject: Re: [PATCH 1/2] dm: update table type check for dax Date: Tue, 28 Jun 2016 20:23:24 +0000 Message-ID: <1467145398.3504.439.camel@hpe.com> References: <1467142636-21094-1-git-send-email-toshi.kani@hpe.com> <1467142636-21094-2-git-send-email-toshi.kani@hpe.com> <20160628200714.GC8300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160628200714.GC8300-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" List-Id: dm-devel.ids T24gVHVlLCAyMDE2LTA2LTI4IGF0IDE2OjA3IC0wNDAwLCBNaWtlIFNuaXR6ZXIgd3JvdGU6DQo+ IE9uIFR1ZSwgSnVuIDI4IDIwMTYgYXTCoMKgMzozN3BtIC0wNDAwLA0KPiBUb3NoaSBLYW5pIDx0 b3NoaS5rYW5pQGhwZS5jb20+IHdyb3RlOg0KwqA6DQo+IFlvdSBzYWlkIGluIHRoZSAwdGggaGVh ZGVyOiAiUGF0Y2ggMSBzb2x2ZXMgYW4gZXJyb3Igd2hlbiBsdnJlbW92ZSBpcw0KPiBtYWRlIHRv IGEgc25hcHNob3QgZGV2aWNlLiINCj4gDQo+IEknbSBub3Qgc2VlaW5nIHdoeSB0aGlzIHBhdGNo IDEgZml4ZXMgYW55dGhpbmcgc3BlY2lmaWMgdG8gc25hcHNob3QNCj4gZGV2aWNlIHJlbW92YWwg KGJ1dCBJIGNhbiBzZWUgd2h5IHBhdGNoIDIgbWFrZXMgc25hcHNob3QgY3JlYXRpb24NCj4gIndv cmsiKS7CoMKgSSdsbCBhcHBseSB5b3VyIDJuZCBwYXRjaCBhbmQgc2VlIGlmIEkgY2FuIHNlZSB3 aGF0IHlvdSBtZWFuLg0KPiANCj4gSSBhY3R1YWxseSBzZWUgdGhpcyBlcnJvciwgd2l0aG91dCBl aXRoZXIgb2YgeW91ciAyIHByb3Bvc2VkIHBhdGNoZXMNCj4gYXBwbGllZCwgd2hlbiBJIHRyeSB0 byBjcmVhdGUgYSBzbmFwc2hvdCBvZiBhIERBWCBjYXBhYmxlIExWOg0KPiANCj4gIyBsdmNyZWF0 ZSAtcyAtbiBzbmFwIC1MIDEwME0gcG1lbS9sdg0KPiDCoCBkZXZpY2UtbWFwcGVyOiByZWxvYWQg aW9jdGwgb24gKDI1Mzo3KSBmYWlsZWQ6IEludmFsaWQgYXJndW1lbnQNCj4gwqAgRmFpbGVkIHRv IGxvY2sgbG9naWNhbCB2b2x1bWUgcG1lbS9sdi4NCj4gwqAgQWJvcnRpbmcuIE1hbnVhbCBpbnRl cnZlbnRpb24gcmVxdWlyZWQuDQo+IEp1biAyOCAxNTo1NzoyOCByaGVsLXN0b3JhZ2UtMDIga2Vy bmVsOiBkZXZpY2UtbWFwcGVyOiBpb2N0bDogY2FuJ3QgY2hhbmdlDQo+IGRldmljZSB0eXBlIGFm dGVyIGluaXRpYWwgdGFibGUgbG9hZC4NCg0KWWVzLCBwYXRjaCAyIGZpeGVzIHRoaXMgZXJyb3Iu DQoNCkkgaGF2ZSBub3QgbG9va2VkIGludG8gd2h5IGx2cmVtb3ZlIGRvZXMgdGhpcywgYnV0IGx2 cmVtb3ZlIHRvIGEgc25hcHNob3QNCmRldmljZSBmYWlscyB0byByZWxvYWQgRE0gdGFibGUgb2Yg IjxkZXY+LWx2c25hcCIgZGV2aWNlICh3aGljaCBpcyBtYXJrZWQgYXMNCkRNX1RZUEVfQklPX0JB U0VEKSB3aXRoIERNX1RZUEVfREFYX0JJT19CQVNFRC4gwqBQYXRjaCAxIGZpeGVzIHRoaXMgZXJy b3IuIMKgSQ0KdGhpbmsgaXQgYWxzbyBnZW5lcmFsbHkgbWFrZXMgc2Vuc2UgdG8gYWxsb3cgdGhp cyBjYXNlLg0KDQpUaGFua3MsDQotVG9zaGkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1A bGlzdHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt bnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbcF1UXa (ORCPT ); Tue, 28 Jun 2016 16:23:30 -0400 Received: from mail-bl2on0126.outbound.protection.outlook.com ([65.55.169.126]:47424 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752571AbcF1UX2 (ORCPT ); Tue, 28 Jun 2016 16:23:28 -0400 From: "Kani, Toshimitsu" To: "snitzer@redhat.com" CC: "linux-raid@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dan.j.williams@intel.com" , "dm-devel@redhat.com" , "linux-nvdimm@ml01.01.org" , "agk@redhat.com" Subject: Re: [PATCH 1/2] dm: update table type check for dax Thread-Topic: [PATCH 1/2] dm: update table type check for dax Thread-Index: AQHR0XSKLq06tkq2ZUOWgsP7GEmeG5//TmuAgAAEfAA= Date: Tue, 28 Jun 2016 20:23:24 +0000 Message-ID: <1467145398.3504.439.camel@hpe.com> References: <1467142636-21094-1-git-send-email-toshi.kani@hpe.com> <1467142636-21094-2-git-send-email-toshi.kani@hpe.com> <20160628200714.GC8300@redhat.com> In-Reply-To: <20160628200714.GC8300@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 85bf6139-c3e1-4373-c568-08d39f920ebf x-microsoft-exchange-diagnostics: 1;CS1PR84MB0005;6:x+Hx+fZKFdaUTQ9nASMt0+quc4UL+WHmXf3nAOBuufPzzSkTxncREMsxFYB6Sw116SEx1utdlabrmQcOxiEdpNbpXVHTp9zqQMlpNn9Lh/JeWaT2EvL6/SoYm1M42dHZubSUFMvhIWz6UBTQmkXkXr95rgIm5CRagljcRyznVFu63+36Z4Ky3aA9wd7GzsryvpN1xb10/SsRMLGJPFSrSKSQo9s30pYs3gaON0cgwSxURA25jp3HKdAtDxwJQ+z8SNKB/5mpzXc+fLhDj1Gy1B9zS8IG5alHW/pY4Pm9ODQ=;5:/BAgUeNZGTsE4rCEd8VpP5P+68mKWSYo8Dezp8E7Q4Ig1S7Bz1jquKKnqf1D6+oqCTKWaKegbnR3qK7a86SxlPKxiK2VVa/OL5rKWRjxepwihTa9dpmn8EgIK3LIg6RwXe8+LThL0phTZ00Dj6f+6Q==;24:Bz3PKGuZ/SNoLZt+ntUAKL4Nad8CvcNc0pa2rln9aOPQs8L52raNtrCJmyyn26hgbQgOzbGVtYDgLXNM4rTP1d6Z3XjCffAiTi0MpRxEWhI=;7:wieDWwLVb6/w5CFcu5MTeF8Xj6zLaCPptYV29DIrilMNoVuBHfhNuJPXaYWRDW+HZGVPTwP34IZwfCJIX9xcmEgiSEPEp6FVc5LbN+WZvexgor92D3kNcEFf9kyLZXVSXDN19VpvkiyEv+L2pMABim765yoOLIJ8wYdvoNbUeOFvW8hNvIcEDcfrwwTRZaxI9eq/E1wdQ08OqDsR3Dz0szNIO2o7dx6eMvpD44+4jdNOuelYM7c2AHh5eBXbTg57 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0005; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CS1PR84MB0005;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0005; x-forefront-prvs: 0987ACA2E2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(199003)(24454002)(189002)(377424004)(33646002)(50986999)(8936002)(54356999)(76176999)(6116002)(102836003)(3846002)(586003)(2501003)(110136002)(2950100001)(68736007)(92566002)(19580395003)(7846002)(7736002)(86362001)(5640700001)(189998001)(97736004)(2900100001)(2906002)(3660700001)(3280700002)(4326007)(305945005)(19580405001)(8676002)(87936001)(77096005)(99286002)(5002640100001)(81166006)(1730700003)(81156014)(11100500001)(101416001)(122556002)(105586002)(10400500002)(66066001)(36756003)(103116003)(2351001)(106356001)(106116001);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0005;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2016 20:23:24.9881 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0005 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5SKNeX7015406 On Tue, 2016-06-28 at 16:07 -0400, Mike Snitzer wrote: > On Tue, Jun 28 2016 at  3:37pm -0400, > Toshi Kani wrote:  : > You said in the 0th header: "Patch 1 solves an error when lvremove is > made to a snapshot device." > > I'm not seeing why this patch 1 fixes anything specific to snapshot > device removal (but I can see why patch 2 makes snapshot creation > "work").  I'll apply your 2nd patch and see if I can see what you mean. > > I actually see this error, without either of your 2 proposed patches > applied, when I try to create a snapshot of a DAX capable LV: > > # lvcreate -s -n snap -L 100M pmem/lv >   device-mapper: reload ioctl on (253:7) failed: Invalid argument >   Failed to lock logical volume pmem/lv. >   Aborting. Manual intervention required. > Jun 28 15:57:28 rhel-storage-02 kernel: device-mapper: ioctl: can't change > device type after initial table load. Yes, patch 2 fixes this error. I have not looked into why lvremove does this, but lvremove to a snapshot device fails to reload DM table of "-lvsnap" device (which is marked as DM_TYPE_BIO_BASED) with DM_TYPE_DAX_BIO_BASED.  Patch 1 fixes this error.  I think it also generally makes sense to allow this case. Thanks, -Toshi