From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Franck Bui" <fbui@suse.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages on release
Date: Wed, 29 Jun 2016 03:24:44 -0700 [thread overview]
Message-ID: <1467195884.24287.111.camel@perches.com> (raw)
In-Reply-To: <1467194161-1472-2-git-send-email-bp@alien8.de>
On Wed, 2016-06-29 at 11:56 +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Extend the ratelimiting facility to print the amount of suppressed lines
> when it is being released.
>
> Separated from a previous patch by Linus.
[]
> diff --git a/include/linux/ratelimit.h b/include/linux/ratelimit.h
[]
> @@ -15,6 +19,7 @@ struct ratelimit_state {
> int printed;
> int missed;
> unsigned long begin;
> + unsigned long flags;
> };
There are a lot of ratelimit_state structs used in the kernel.
Every printk like <foo>_ratelimited uses a static one.
It'd likely be better to reduce the struct ratelimit_state
size rather than expand it.
burst and printed could probably become s16 or even s8.
flags could be u8 until necessary to expand.
next prev parent reply other threads:[~2016-06-29 10:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 9:55 [PATCH -v2 0/2] printk.kmsg: Ratelimit it by default Borislav Petkov
2016-06-29 9:56 ` [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov
2016-06-29 10:24 ` Joe Perches [this message]
2016-06-29 14:25 ` Borislav Petkov
2016-07-01 8:22 ` Ingo Molnar
2016-07-01 9:07 ` Borislav Petkov
2016-07-01 10:17 ` Ingo Molnar
2016-07-01 10:29 ` Borislav Petkov
2016-07-01 10:38 ` Ingo Molnar
2016-06-29 9:56 ` [PATCH -v2 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Borislav Petkov
2016-07-01 9:04 ` Ingo Molnar
2016-07-01 9:17 ` Borislav Petkov
2016-07-01 10:20 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467195884.24287.111.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=fbui@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.