From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kani, Toshimitsu" Subject: Re: [PATCH 1/2] dm: update table type check for dax Date: Wed, 29 Jun 2016 15:19:05 +0000 Message-ID: <1467213538.3504.442.camel@hpe.com> References: <1467142636-21094-1-git-send-email-toshi.kani@hpe.com> <1467142636-21094-2-git-send-email-toshi.kani@hpe.com> <20160628200714.GC8300@redhat.com> <1467145398.3504.439.camel@hpe.com> <20160629004049.GA9721@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160629004049.GA9721-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Content-ID: <55DC4A9F57B87C4B8A7431721C9D1254-mmYPd6ayCNGroOM5E8FhRbjFIynDaujOfM0AETQt39g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" List-Id: dm-devel.ids T24gVHVlLCAyMDE2LTA2LTI4IGF0IDIwOjQwIC0wNDAwLCBNaWtlIFNuaXR6ZXIgd3JvdGU6DQo+ IE9uIFR1ZSwgSnVuIDI4IDIwMTYgYXTCoMKgNDoyM3BtIC0wNDAwLA0KPiBLYW5pLCBUb3NoaW1p dHN1IDx0b3NoaS5rYW5pQGhwZS5jb20+IHdyb3RlOg0KPiANCj4gPiBPbiBUdWUsIDIwMTYtMDYt MjggYXQgMTY6MDcgLTA0MDAsIE1pa2UgU25pdHplciB3cm90ZToNCj4gPiA+IA0KPiA+ID4gT24g VHVlLCBKdW4gMjggMjAxNiBhdMKgwqAzOjM3cG0gLTA0MDAsDQo+ID4gPiBUb3NoaSBLYW5pIDx0 b3NoaS5rYW5pQGhwZS5jb20+IHdyb3RlOg0KPiA+IMKgOg0KPiA+ID4gDQo+ID4gPiBZb3Ugc2Fp ZCBpbiB0aGUgMHRoIGhlYWRlcjogIlBhdGNoIDEgc29sdmVzIGFuIGVycm9yIHdoZW4gbHZyZW1v dmUgaXMNCj4gPiA+IG1hZGUgdG8gYSBzbmFwc2hvdCBkZXZpY2UuIg0KPiA+ID4gDQo+ID4gPiBJ J20gbm90IHNlZWluZyB3aHkgdGhpcyBwYXRjaCAxIGZpeGVzIGFueXRoaW5nIHNwZWNpZmljIHRv IHNuYXBzaG90DQo+ID4gPiBkZXZpY2UgcmVtb3ZhbCAoYnV0IEkgY2FuIHNlZSB3aHkgcGF0Y2gg MiBtYWtlcyBzbmFwc2hvdCBjcmVhdGlvbg0KPiA+ID4gIndvcmsiKS7CoMKgSSdsbCBhcHBseSB5 b3VyIDJuZCBwYXRjaCBhbmQgc2VlIGlmIEkgY2FuIHNlZSB3aGF0IHlvdSBtZWFuLg0KPiA+ID4g DQo+ID4gPiBJIGFjdHVhbGx5IHNlZSB0aGlzIGVycm9yLCB3aXRob3V0IGVpdGhlciBvZiB5b3Vy IDIgcHJvcG9zZWQgcGF0Y2hlcw0KPiA+ID4gYXBwbGllZCwgd2hlbiBJIHRyeSB0byBjcmVhdGUg YSBzbmFwc2hvdCBvZiBhIERBWCBjYXBhYmxlIExWOg0KPiA+ID4gDQo+ID4gPiAjIGx2Y3JlYXRl IC1zIC1uIHNuYXAgLUwgMTAwTSBwbWVtL2x2DQo+ID4gPiDCoCBkZXZpY2UtbWFwcGVyOiByZWxv YWQgaW9jdGwgb24gKDI1Mzo3KSBmYWlsZWQ6IEludmFsaWQgYXJndW1lbnQNCj4gPiA+IMKgIEZh aWxlZCB0byBsb2NrIGxvZ2ljYWwgdm9sdW1lIHBtZW0vbHYuDQo+ID4gPiDCoCBBYm9ydGluZy4g TWFudWFsIGludGVydmVudGlvbiByZXF1aXJlZC4NCj4gPiA+IEp1biAyOCAxNTo1NzoyOCByaGVs LXN0b3JhZ2UtMDIga2VybmVsOiBkZXZpY2UtbWFwcGVyOiBpb2N0bDogY2FuJ3QNCj4gPiA+IGNo YW5nZSBkZXZpY2UgdHlwZSBhZnRlciBpbml0aWFsIHRhYmxlIGxvYWQuDQo+ID4NCj4gPiBZZXMs IHBhdGNoIDIgZml4ZXMgdGhpcyBlcnJvci4NCj4gPiANCj4gPiBJIGhhdmUgbm90IGxvb2tlZCBp bnRvIHdoeSBsdnJlbW92ZSBkb2VzIHRoaXMsIGJ1dCBsdnJlbW92ZSB0byBhIHNuYXBzaG90DQo+ ID4gZGV2aWNlIGZhaWxzIHRvIHJlbG9hZCBETSB0YWJsZSBvZiAiPGRldj4tbHZzbmFwIiBkZXZp Y2UgKHdoaWNoIGlzIG1hcmtlZA0KPiA+IGFzIERNX1RZUEVfQklPX0JBU0VEKSB3aXRoIERNX1RZ UEVfREFYX0JJT19CQVNFRC4gwqBQYXRjaCAxIGZpeGVzIHRoaXMNCj4gPiBlcnJvci4NCj4NCj4g SXQgbG9va3MgbGlrZSBhIHN0cmFuZ2UgaW50ZXJtZWRpYXRlIHN0YXRlIHRoYXQgbHZtMiB1c2Vz IGR1cmluZw0KPiBzbmFwc2hvdCByZW1vdmFsLg0KPiANCj4gRnVsbCBsaXN0aW5nIG9mIHNuYXBz aG90IHJlbGF0ZWQgRE0gdGFibGVzIChiZWZvcmUgbHZyZW1vdmUpOg0KPiANCj4gcG1lbS1sdi1y ZWFsOiAwIDYwODY2NTYgbGluZWFyIDI1OTowIDIwNDgNCj4gcG1lbS1sdjogMCA2MDg2NjU2IHNu YXBzaG90LW9yaWdpbiAyNTM6NQ0KPiBwbWVtLXNuYXAtY293OiAwIDIwNDgwMCBsaW5lYXIgMjU5 OjAgNjA4ODcwNA0KPiBwbWVtLXNuYXA6IDAgNjA4NjY1NiBzbmFwc2hvdCAyNTM6NSAyNTM6NiBQ IDgNCj4gDQo+IFdoZW4gcmVtb3ZpbmcgdGhpcyBzbmFwc2hvdCB3ZSdyZSB3YW50aW5nIHRvIGJl IGxlZnQgd2l0aDoNCj4gDQo+IHBtZW0tbHY6IDAgNjA4NjY1NiBsaW5lYXIgMjU5OjAgMjA0OA0K PiANCj4gSSBhdWdtZW50ZWQgdGhlIERNIGNvcmUgZXJyb3IgdG8gYmUgbW9yZSBleHByZXNzaXZl LCByZXN1bHRpbmcgaW46DQo+IMKgIGRldmljZS1tYXBwZXI6IGlvY3RsOiAyNTM6NzogY2FuJ3Qg Y2hhbmdlIGRldmljZSB0eXBlIChmcm9tIDEgdG8gNCkgYWZ0ZXINCj4gaW5pdGlhbCB0YWJsZSBs b2FkLg0KPiANCj4gMSBpcyBETV9UWVBFX0JJT19CQVNFRCBhbmQgNCBpcyBETV9UWVBFX0RBWF9C SU9fQkFTRUQgLS0gd2hpY2ggbWFrZXMNCj4gc2Vuc2UgZ2l2ZW4gdGhlIGxpbmVhciB0YXJnZXQg aXMgRE1fVFlQRV9EQVhfQklPX0JBU0VELg0KPiANCj4gVGhlIHByZXZpb3VzIERNIHRhYmxlIGZv ciAyNTM6NyB3YXM6DQo+IMKgIHBtZW0tc25hcDogMCA2MDg2NjU2IHNuYXBzaG90IDI1Mzo1IDI1 Mzo2IFAgOA0KPiANCj4gVGhlIGludGVybWVkaWF0ZSB0YWJsZSB0aGF0IGx2bTIgaXMgdHJ5aW5n IHRvIGxvYWQgZm9yIDI1Mzo3IGlzOg0KPiDCoCAwIDIwNDgwMCBsaW5lYXIgMjU5OjAgNjA4ODcw NA0KPiANCj4gKHRoaXMgbGluZWFyIHRhcmdldCB3YXMgcHJldmlvdXNseSBwbWVtLXNuYXAtY293 KQ0KDQpZZXMsIHRoYXQgaXMgY29uc2lzdGVudCB3aXRoIHdoYXQgSSBzYXcuDQoNCj4gPiANCj4g PiBJIHRoaW5rIGl0IGFsc28gZ2VuZXJhbGx5IG1ha2VzIHNlbnNlIHRvIGFsbG93IHRoaXMgY2Fz ZS4NCj4NCj4gWW91J3JlIHByb2JhYmx5IHJpZ2h0IGJ1dCBJIG5lZWQgdG8gdGhpbmsgYWJvdXQg aXQgYSBsaXR0bGUgYml0IG1vcmUuDQoNClNvdW5kcyBnb29kLg0KDQpUaGFua3MhDQotVG9zaGkN Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW52 ZGltbSBtYWlsaW5nIGxpc3QKTGludXgtbnZkaW1tQGxpc3RzLjAxLm9yZwpodHRwczovL2xpc3Rz LjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW52ZGltbQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138AbcF2PTN (ORCPT ); Wed, 29 Jun 2016 11:19:13 -0400 Received: from mail-by2on0134.outbound.protection.outlook.com ([207.46.100.134]:21056 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752725AbcF2PTI (ORCPT ); Wed, 29 Jun 2016 11:19:08 -0400 From: "Kani, Toshimitsu" To: "snitzer@redhat.com" CC: "linux-raid@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dan.j.williams@intel.com" , "dm-devel@redhat.com" , "linux-nvdimm@ml01.01.org" , "agk@redhat.com" Subject: Re: [PATCH 1/2] dm: update table type check for dax Thread-Topic: [PATCH 1/2] dm: update table type check for dax Thread-Index: AQHR0XSKLq06tkq2ZUOWgsP7GEmeG5//TmuAgAAEfACAAEfzgIAA9VoA Date: Wed, 29 Jun 2016 15:19:05 +0000 Message-ID: <1467213538.3504.442.camel@hpe.com> References: <1467142636-21094-1-git-send-email-toshi.kani@hpe.com> <1467142636-21094-2-git-send-email-toshi.kani@hpe.com> <20160628200714.GC8300@redhat.com> <1467145398.3504.439.camel@hpe.com> <20160629004049.GA9721@redhat.com> In-Reply-To: <20160629004049.GA9721@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: fff22dae-b253-41f1-f914-08d3a030b59b x-microsoft-exchange-diagnostics: 1;CS1PR84MB0007;6:WU/z3LfRILjPqTInYrW0po9s6Mh9FVmNRN5nqGJo3rdslM1l/0yLa2F5Lxv+IgB2e2on6TK1o0mnYkPb1IJhg08kGnrRYC9HSnsFBnJcfoplIzVO8SqUZqtJbyAVpxWojXD21vJ4UaClMSwTC69kcWXdukcB0xR2BLSsH5kizbmGYeLZWXSEKEMs8/kOluxQ5Mym3ZCRw0YrRc2oKJ3TQdCiqL98gil08u6EzrOTaAWO54+RzgfV5b1y5Z8tDKFSB7EIfLwqgqw1NUv4QBLUx/cgZi26CqJz7nbXjJXQRsE=;5:B7C+Ov9Idfz6LxcVbWCbI201zwDuRk0Y1sKWqDd5H3Dd2SyBvQikE4UN0bQ3+GoYHwHaIuOK3fO5esBNZGP/NLo1d1LIuL2qVBcR0YrzriwPBJifaLXfSolhcuwNR4/0Bp6AGYllCyG/KqRfZr/WTA==;24:XvzQjpfQUh6XPaKkD7wbsnJM4Zj35ITxh2WePW6eTA1ANOdnaE8oQPWfOwKpwPY4Ojy61BqmgcZehRWEJ+2xjW0Mg4qEcnEkFRySsojn45A=;7:YNKbSR0QRwfxFdCIS27keS68ZyHNLKp9HmEJaw1fzO4x30XDq/nrIuG94fS47ghQZLF6LxDrHjhWCm+Tb5yys8cI9AVRTbXjrVd/WwiK5KRks47nMpfljgtz2L94W4EIVuFVqAyXyaMyAvqEfG/TktrrQr74nUufL2poJ8yaM570JucbosFUAlqBedrlJm1O9TO1EA3nt/IAUeh1Ue2g9BRgeOhADhBTs6SNWpnslFdRn2Kbwau3G44SPadhgEgN x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CS1PR84MB0007;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-forefront-prvs: 09888BC01D x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(377424004)(189002)(199003)(24454002)(11100500001)(87936001)(5002640100001)(8936002)(36756003)(33646002)(3660700001)(102836003)(106116001)(77096005)(3846002)(110136002)(586003)(97736004)(99286002)(122556002)(2900100001)(106356001)(76176999)(2950100001)(6116002)(93886004)(105586002)(305945005)(101416001)(86362001)(8676002)(4326007)(103116003)(189998001)(5640700001)(2501003)(54356999)(81156014)(1730700003)(66066001)(2351001)(81166006)(68736007)(19580405001)(19580395003)(50986999)(92566002)(2906002)(3280700002)(10400500002)(7736002)(7846002);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0007;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <55DC4A9F57B87C4B8A7431721C9D1254@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2016 15:19:05.4263 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0007 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5TFJMGK020695 On Tue, 2016-06-28 at 20:40 -0400, Mike Snitzer wrote: > On Tue, Jun 28 2016 at  4:23pm -0400, > Kani, Toshimitsu wrote: > > > On Tue, 2016-06-28 at 16:07 -0400, Mike Snitzer wrote: > > > > > > On Tue, Jun 28 2016 at  3:37pm -0400, > > > Toshi Kani wrote: > >  : > > > > > > You said in the 0th header: "Patch 1 solves an error when lvremove is > > > made to a snapshot device." > > > > > > I'm not seeing why this patch 1 fixes anything specific to snapshot > > > device removal (but I can see why patch 2 makes snapshot creation > > > "work").  I'll apply your 2nd patch and see if I can see what you mean. > > > > > > I actually see this error, without either of your 2 proposed patches > > > applied, when I try to create a snapshot of a DAX capable LV: > > > > > > # lvcreate -s -n snap -L 100M pmem/lv > > >   device-mapper: reload ioctl on (253:7) failed: Invalid argument > > >   Failed to lock logical volume pmem/lv. > > >   Aborting. Manual intervention required. > > > Jun 28 15:57:28 rhel-storage-02 kernel: device-mapper: ioctl: can't > > > change device type after initial table load. > > > > Yes, patch 2 fixes this error. > > > > I have not looked into why lvremove does this, but lvremove to a snapshot > > device fails to reload DM table of "-lvsnap" device (which is marked > > as DM_TYPE_BIO_BASED) with DM_TYPE_DAX_BIO_BASED.  Patch 1 fixes this > > error. > > It looks like a strange intermediate state that lvm2 uses during > snapshot removal. > > Full listing of snapshot related DM tables (before lvremove): > > pmem-lv-real: 0 6086656 linear 259:0 2048 > pmem-lv: 0 6086656 snapshot-origin 253:5 > pmem-snap-cow: 0 204800 linear 259:0 6088704 > pmem-snap: 0 6086656 snapshot 253:5 253:6 P 8 > > When removing this snapshot we're wanting to be left with: > > pmem-lv: 0 6086656 linear 259:0 2048 > > I augmented the DM core error to be more expressive, resulting in: >   device-mapper: ioctl: 253:7: can't change device type (from 1 to 4) after > initial table load. > > 1 is DM_TYPE_BIO_BASED and 4 is DM_TYPE_DAX_BIO_BASED -- which makes > sense given the linear target is DM_TYPE_DAX_BIO_BASED. > > The previous DM table for 253:7 was: >   pmem-snap: 0 6086656 snapshot 253:5 253:6 P 8 > > The intermediate table that lvm2 is trying to load for 253:7 is: >   0 204800 linear 259:0 6088704 > > (this linear target was previously pmem-snap-cow) Yes, that is consistent with what I saw. > > > > I think it also generally makes sense to allow this case. > > You're probably right but I need to think about it a little bit more. Sounds good. Thanks! -Toshi