Re: [PATCH] python3: correct the multilib support patch

["Randle, William C" <william.c.randle@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1820 bytes --]

On Wed, 2016-06-29 at 07:33 +0100, Richard Purdie wrote:

On Wed, 2016-06-29 at 11:12 +0800, Li Zhou wrote:


When python3 rebased its multilib patch, the hard coded "lib" path
isn't really changed because of the rebasing's error, and cause
phthon3's failure when running on 64bit platforms as below:
Could not find platform independent libraries <prefix>
Could not find platform dependent libraries <exec_prefix>
Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
Fatal Python error: Py_Initialize: Unable to get the locale encoding
ImportError: No module named 'encodings'

Here correct the rebasing error and solve this issue.

Signed-off-by: Li Zhou <li.zhou@windriver.com<mailto:li.zhou@windriver.com>>
---
 ...ython3-correct-the-multilib-support-patch.patch | 47
++++++++++++++++++++++
 meta/recipes-devtools/python/python3_3.5.1.bb      |  1 +
 2 files changed, 48 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3/0001-python3
-correct-the-multilib-support-patch.patch




Don't we want to correct the "bad" patch rather than adding an
additional patch? Or did I misunderstand the problem?

Also, are there some automated tests we should be adding to catch this
kind of problem? I'm a little worried none of our testing caught this.

Cheers,

Richard


I would agree that since the original patch has not been accepted upstream,  it would make the most sense to just regenerate it.

In addition, there are a couple of other places in getpath.c that have a hard coded "lib/". Have you verified those are correct as is? (I.e., ~line 706 'L:lib/pyhton00.zip"' and ~line 718 'L"lib/lib-dynload"'. Seems like the second case should use code similar other palces lib-dynload is used in the file that uses lib_python to build the path.)

    -Bill

[-- Attachment #2: Type: text/html, Size: 2391 bytes --]