From: Joe Perches <joe@perches.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Michal Nazarewicz <mina86@mina86.com>,
zengzhaoxiu@163.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
Borislav Petkov <bp@suse.de>, Michal Hocko <mhocko@suse.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
Horacio Mijail Anton Quiles <hmijail@gmail.com>
Subject: Re: [PATCH 1/2] lib: hexdump: use a look-up table to do hex_to_bin
Date: Thu, 30 Jun 2016 13:06:26 -0700 [thread overview]
Message-ID: <1467317186.24287.164.camel@perches.com> (raw)
In-Reply-To: <CAMuHMdWiqT3xsS9wmEFf3TNWDkCQNCHEe3Bvn7Q9ySgRMwkemQ@mail.gmail.com>
On Thu, 2016-06-30 at 21:42 +0200, Geert Uytterhoeven wrote:
> Hi Joe,
Hi Geert.
> On Thu, Jun 30, 2016 at 9:26 PM, Joe Perches <joe@perches.com> wrote:
[]
> > Perhaps _tolower should be used a bit more in lib
[]
> No, we do care about non-alphabetical characters here.
> Using _tolower is equivalent to ignoring bit 5 in each byte of the string.
Yeah, that can't work.
Rasmus V wrote the same thing to me offline.
next prev parent reply other threads:[~2016-06-30 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 16:15 [PATCH 1/2] lib: hexdump: use a look-up table to do hex_to_bin zengzhaoxiu
2016-06-29 16:22 ` [PATCH 2/2] lib: kstrtox: _parse_integer: use hex_to_bin instead local conversion, and reduce branches zengzhaoxiu
2016-06-29 22:06 ` Alexey Dobriyan
2016-06-30 14:45 ` Zhaoxiu Zeng
2016-06-29 16:22 ` [PATCH 1/2] lib: hexdump: use a look-up table to do hex_to_bin Andy Shevchenko
2016-06-29 16:24 ` Steven Rostedt
2016-06-29 18:31 ` Michal Nazarewicz
2016-06-29 18:52 ` Andy Shevchenko
2016-06-30 19:26 ` Joe Perches
2016-06-30 19:42 ` Geert Uytterhoeven
2016-06-30 20:06 ` Joe Perches [this message]
2016-06-30 20:44 ` Andy Shevchenko
2016-06-30 21:18 ` Michal Nazarewicz
2016-06-30 14:21 ` Zhaoxiu Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467317186.24287.164.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@suse.de \
--cc=geert@linux-m68k.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=hmijail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mhocko@suse.com \
--cc=mina86@mina86.com \
--cc=nicolas.iooss_linux@m4x.org \
--cc=rostedt@goodmis.org \
--cc=zengzhaoxiu@163.com \
--cc=zhaoxiu.zeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.