All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Arbuckle <programmingkidx@gmail.com>
To: eblake@redhat.com, qemu-devel@nongnu.org
Cc: John Arbuckle <programmingkidx@gmail.com>
Subject: [Qemu-devel] [PATCH v2 3/3] hid.c: Add debug support
Date: Fri,  1 Jul 2016 11:59:51 -0400	[thread overview]
Message-ID: <1467388791-1657-4-git-send-email-programmingkidx@gmail.com> (raw)
In-Reply-To: <1467388791-1657-1-git-send-email-programmingkidx@gmail.com>

Add debug macros to the code for easier debugging.

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
---
v2 changes:
- Made DEBUG_HID() always defined

 hw/input/hid.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/hw/input/hid.c b/hw/input/hid.c
index 3e1b46e..b5558cd 100644
--- a/hw/input/hid.c
+++ b/hw/input/hid.c
@@ -37,6 +37,19 @@
 #define RELEASED -1
 #define PUSHED -2
 
+/* #define DEBUG_HID_CODE */
+#ifdef DEBUG_HID_CODE
+    #define DEBUG_HID_PRINT 1
+#else
+    #define DEBUG_HID_PRINT 0
+#endif
+#define DEBUG_HID(fmt, ...)                                 \
+    do {                                                    \
+            if (DEBUG_HID_PRINT) {                          \
+                fprintf(stderr, fmt, ## __VA_ARGS__);       \
+            }                                               \
+        } while (0)                                         \
+
 /* Translates a QKeyCode to USB HID value */
 static const uint8_t qcode_to_usb_hid[] = {
     [Q_KEY_CODE_SHIFT] = USB_HID_LEFT_SHIFT,
@@ -331,6 +344,7 @@ static void hid_keyboard_event(DeviceState *dev, QemuConsole *src,
         return;
     }
     keycode = qcode_to_usb_hid[qcode];
+    DEBUG_HID("keycode = 0x%x qcode:%d\n", keycode, qcode);
 
     count = 2;
     if (evt->u.key.data->down == false) { /* if key up event */
@@ -381,6 +395,9 @@ static void hid_keyboard_process_keycode(HIDState *hs)
     slot = hs->head & QUEUE_MASK; QUEUE_INCR(hs->head); hs->n--;
     keycode = hs->kbd.keycodes[slot];
 
+    DEBUG_HID("keycode:0x%x status:%s\n", keycode, (status == PUSHED ? "Pushed"
+              : "Released"));
+
     /* handle Control, Option, GUI/Windows/Command, and Shift keys */
     if (keycode >= 0xe0) {
         process_modifier_key(status, keycode, &(hs->kbd.modifiers));
-- 
2.7.2

      parent reply	other threads:[~2016-07-01 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-01 15:59 [Qemu-devel] [PATCH v2 0/3] Switch USB HID to QKeyCode John Arbuckle
2016-07-01 15:59 ` [Qemu-devel] [PATCH v2 1/3] usb-keys.h: initial commit John Arbuckle
2016-07-01 15:59 ` [Qemu-devel] [PATCH v2 2/3] hid.c: convert to QKeyCode John Arbuckle
2016-07-01 15:59 ` John Arbuckle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467388791-1657-4-git-send-email-programmingkidx@gmail.com \
    --to=programmingkidx@gmail.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.