All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, pbonzini@redhat.com,
	mst@redhat.com, dgilbert@redhat.com, peter.maydell@linaro.org,
	eblake@redhat.com, rth@twiddle.net, Peter Lieven <pl@kamp.de>
Subject: [Qemu-devel] [PATCH V2 4/6] coroutine-sigaltstack: use helper for allocating stack memory
Date: Mon,  4 Jul 2016 14:31:25 +0200	[thread overview]
Message-ID: <1467635487-9329-5-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1467635487-9329-1-git-send-email-pl@kamp.de>

Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Peter Lieven <pl@kamp.de>
---
 util/coroutine-sigaltstack.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c
index 9c2854c..ccf4861 100644
--- a/util/coroutine-sigaltstack.c
+++ b/util/coroutine-sigaltstack.c
@@ -143,7 +143,6 @@ static void coroutine_trampoline(int signal)
 
 Coroutine *qemu_coroutine_new(void)
 {
-    const size_t stack_size = COROUTINE_STACK_SIZE;
     CoroutineUContext *co;
     CoroutineThreadState *coTS;
     struct sigaction sa;
@@ -164,7 +163,7 @@ Coroutine *qemu_coroutine_new(void)
      */
 
     co = g_malloc0(sizeof(*co));
-    co->stack = g_malloc(stack_size);
+    co->stack = qemu_alloc_stack(COROUTINE_STACK_SIZE);
     co->base.entry_arg = &old_env; /* stash away our jmp_buf */
 
     coTS = coroutine_get_thread_state();
@@ -189,7 +188,7 @@ Coroutine *qemu_coroutine_new(void)
      * Set the new stack.
      */
     ss.ss_sp = co->stack;
-    ss.ss_size = stack_size;
+    ss.ss_size = COROUTINE_STACK_SIZE;
     ss.ss_flags = 0;
     if (sigaltstack(&ss, &oss) < 0) {
         abort();
@@ -253,7 +252,7 @@ void qemu_coroutine_delete(Coroutine *co_)
 {
     CoroutineUContext *co = DO_UPCAST(CoroutineUContext, base, co_);
 
-    g_free(co->stack);
+    qemu_free_stack(co->stack, COROUTINE_STACK_SIZE);
     g_free(co);
 }
 
-- 
1.9.1

  parent reply	other threads:[~2016-07-04 12:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 12:31 [Qemu-devel] [PATCH V2 0/6] coroutine: mmap stack memory and stack size Peter Lieven
2016-07-04 12:31 ` [Qemu-devel] [PATCH V2 1/6] oslib-posix: add helpers for stack alloc and free Peter Lieven
2016-07-06  8:12   ` Markus Armbruster
2016-07-08 17:18   ` Richard Henderson
2016-07-04 12:31 ` [Qemu-devel] [PATCH V2 2/6] coroutine: add a macro for the coroutine stack size Peter Lieven
2016-07-04 12:31 ` [Qemu-devel] [PATCH V2 3/6] coroutine-ucontext: use helper for allocating stack memory Peter Lieven
2016-07-04 12:31 ` Peter Lieven [this message]
2016-07-04 12:31 ` [Qemu-devel] [PATCH V2 5/6] oslib-posix: add a configure switch to debug stack usage Peter Lieven
2016-07-04 12:31 ` [Qemu-devel] [PATCH V2 6/6] coroutine: reduce stack size to 64kB Peter Lieven
2016-07-06  8:13   ` Markus Armbruster
2016-07-04 14:54 ` [Qemu-devel] [PATCH V2 0/6] coroutine: mmap stack memory and stack size Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467635487-9329-5-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.