From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: [PATCH 2/7] gpu: drm: sti_compositor: add missing of_node_put after calling of_parse_phandle Date: Tue, 5 Jul 2016 10:04:49 +0800 Message-ID: <1467684294-20111-3-git-send-email-peter.chen@nxp.com> References: <1467684294-20111-1-git-send-email-peter.chen@nxp.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1467684294-20111-1-git-send-email-peter.chen@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Peter Chen , Benjamin Gaignard , Vincent Abriou List-Id: dri-devel@lists.freedesktop.org of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: Benjamin Gaignard Cc: Vincent Abriou Signed-off-by: Peter Chen --- drivers/gpu/drm/sti/sti_compositor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_compositor.c b/drivers/gpu/drm/sti/sti_compositor.c index 3d2fa3a..064de14 100644 --- a/drivers/gpu/drm/sti/sti_compositor.c +++ b/drivers/gpu/drm/sti/sti_compositor.c @@ -247,10 +247,12 @@ static int sti_compositor_probe(struct platform_device *pdev) vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 0); if (vtg_np) compo->vtg_main = of_vtg_find(vtg_np); + of_node_put(vtg_np); vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 1); if (vtg_np) compo->vtg_aux = of_vtg_find(vtg_np); + of_node_put(vtg_np); platform_set_drvdata(pdev, compo); -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754352AbcGEC21 (ORCPT ); Mon, 4 Jul 2016 22:28:27 -0400 Received: from mail-co1nam03on0054.outbound.protection.outlook.com ([104.47.40.54]:47958 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753632AbcGEC2U (ORCPT ); Mon, 4 Jul 2016 22:28:20 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; st.com; dkim=none (message not signed) header.d=none;st.com; dmarc=fail action=none header.from=nxp.com; From: Peter Chen To: CC: , , "Peter Chen" , Benjamin Gaignard , Vincent Abriou Subject: [PATCH 2/7] gpu: drm: sti_compositor: add missing of_node_put after calling of_parse_phandle Date: Tue, 5 Jul 2016 10:04:49 +0800 Message-ID: <1467684294-20111-3-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1467684294-20111-1-git-send-email-peter.chen@nxp.com> References: <1467684294-20111-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131121583344527788;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(50466002)(68736007)(48376002)(2906002)(110136002)(356003)(8676002)(50986999)(76176999)(189998001)(87936001)(86362001)(81156014)(5003940100001)(81166006)(106466001)(33646002)(229853001)(2351001)(77096005)(105606002)(69596002)(19580405001)(19580395003)(85426001)(11100500001)(97736004)(92566002)(4326007)(36756003)(2950100001)(586003)(47776003)(50226002)(104016004)(7846002)(305945005)(8666005)(6806005)(8936002)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR03MB251;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD046;1:r6kFar5j3e9jhNxqKmB5oAfZulCPZzoZCQx3leti/T9r9T/gJxffkux+Fsca8+sZjaoKWRHRrbE9HodEqBhPIobCSpMJ2bwv1Q3HlO4zA/ZuGigWqFpt7Du/bdoxUi8uqDAyMtiJG69GU9zhDwqSP1bXRvQYZf6865GXsxRLo8Z7NAQcAiNSGsopnIhEqsaKIWHp+r0eojl6Z8pT4uRTjddRTtPmeSsoL5B4s3G+39AocQcSsCzR6gODHX5BFi6eVhvgmc0KoV+Vr1srU/W8Sipd8PDntHajU/Y6a2pGfv1oOm7nRP8Wm8xmtubb1fD9yz79RvoJ18MZMgzrbvUHpTvL8cPSk8pdT5+kzuYVA0b0ls252CKFcq+CypNfI8QvxHcDPPSFNcLAAGc8HUmGoDSkD1t8uZ1WxLD+phf+eZPvr1krr+VTNlt7fl4+JD2ulDVEtM0/x9MW5uI7GxM6R69j+yHLcbh3e/9bbcFZBTHxIJUQGbD3c8r8WgXzovDiCpJsH+Gflmkrs0eRk4PjAY0ahFC1olgSSmWdh/OVpSvVuvfAcsYVkI+B75o3yYiuuDvqXe+TSFeJa9toMWeSkjfWwhl+d1I+JfNuPKXDeD8s7U+k94xeTGIC/ijIIl/aAVRoDbVqrZzHeSYzPZWUiQ== MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 4e0f454a-08df-46c1-c84c-08d3a479c817 X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB251;2:LDpcljdmIp+5IWlAZjgY2sQO7w7c64/OfiyqoVKCJLTUPkeS162Drm0SZFNb6TmiPJvHj7sq0anojjnkjcT/pFz/kkx6mwrBPPDr4D1aJubV8/wwRdqopSCDRSCft9SbrNzp9ao8kz0GcLMgmqGPTk8txVLqZaRJqOL5bMLbG0/8URu2xWI6sJSWkM2ifw9s;3:LLKpMhncjRJdcmSG5RJxI5wjA6e53/gPreuUjBNWfbLVimgjNz8hgLOT1UnL+KSuootud5xte+ToOgtrr0HtwswA/5LQ2AjfLH1jp21RwZ97+zAXNyVpsBUCIvMbgiLS20u5piRk3J0w9WyVEJMaosyZqcY+m3CvlwWVRTF+wCXQYkcR4NQOh8667m2H7mADjcW4CoAasGKjEJJ7WuDB95S6UccCPn98+yinWul3kt8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB251; X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB251;25:pYhqe4EH12Ox+EaqW/HGQdJzPemCpNMCbkiEaAFLIT5egDqNU/6gDQ93LHw3dA0A7bXGxMpZ9DDPOsn1pPIXCjSuGl7uEnDzf2Xwv7s7cy5r5UDbXPIEvFZDuB1C7+wGg3KZQbp8OviOuj/vrP4vo8vRBkLX/nRAbeenBY7RuKAsTQXS2qbLH4FMUQFXJ5PMWq/452ZSTwnkiKAfHZCUN07kZCKEARILvJ/jopQsUAc0vFh7GyjHHJ0wrdWUKz92DyVxUC7F1Gw2TZ2zuFlDeiLjWTl5WWmaJB0gZgLvyeQGkShG+jXQ0mnAMTBh/Pkll6WVLnxxEuQu0gsABrM2ZbGikxKJcPMgKraTgutzaL6jrLgId5poWj3BGBwpz2EzeRGIrs7ayuxilzTPFIhHnW7EXnzu9a8vgz+Z6+G4I3U+e+nHjI0NtmklDjJP8bRXnyJ319pKoQKddXh+kac0v6CLctSv99SnGy7buq0076vyvZ6da6bkvqODJzDOa884Tj/B3H/ghdPNP8Yx9w8iFcwbazKZGJwC45YzbitUL+ktv/VMdha+BEeOaIljx2p7HioPBg4A5TLXntN6io0yY4p7A2rd4sYM3uAodYrbVgqdYZsVBKPOZIglan0OuUpJZzoEwFwtLxEbIWrFZpfuPcNvBcJ2EFdowsVf6gIAJuCUnz5G7YZbCadb47+V9y3XYlJmCi6NksxG5b9dvqg3MA==;31:4kcCJgWWaLv/Ht5JsHVrsBesq560jj3JRrk6aK5IyxujiCvKpbT4n6gAGuErex0FO3D5eda0qUM7ufgcr0if2Pot1I7lgbBYNF3i9sfTgD5smBAbGt2Z41gyfvQU5wrmshpxAJpRjpPsCc4h8Z+h42q2fDNF/vCzoXE8HGYrWwt+hqiYSasTN+h2wTEVMvS/XFLaWcOF5kUzN5HYKYVTYA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13023025)(13024025)(13018025)(13015025)(13017025)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BN1PR03MB251;BCL:0;PCL:0;RULEID:(400006);SRVR:BN1PR03MB251; X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB251;4:9pCRQOmO9m1HluMddne83AWWd+Ch694E13dFl9nt/r6CNow8nmVNFMeLy9P4R5k89RWJ3/iWU0CvLgQReOeFWjdb9q/DC4JbkXo6yDpukAs7BJlYjQ+JEtSkKKBf3Lit/BQXvTvtEjRsoArZYPowmzjR/a2pTn25VIjn8jxKSVmdNWGq0Ui1AoDQS0NvZ2xbH4AGkOMkEX92UQuysY5+s3MZ6BFp2WhKOQMXiaJgT3cka3QdH5D8EiIF4TOE2WNVN58cR7tvTH0v5W1k54UbKrpi8FYJOJOppELf5kvkZ6/HNTPiFRt6UW0Axn/s7NmMhKvtvc+igy1D+Hps2k9PeMgohiKiCwIebKqijIFowYjaiCTBeOzVXnq6TLjyll3hPBLO3R2HL/CQe5/4rcXJdYY8gSPmQjMqn3kNNrSWllS5JUCB96RVv/5ic24WgWHKhths0Hf/Mj09J2JEqVverZxMkefvuusVTxne4g+LP75MUWdxDSE8DgZml3VonZw/12tu/sbmY+hplJqVc+cWhQ== X-Forefront-PRVS: 0994F5E0C5 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1PR03MB251;23:rgAgl0uXPz/0Azb5shoqeSxjwDlySsD75grlT4Jk3R?= =?us-ascii?Q?WmUZiWp0zxNR9oqD5MjbFjRJzVKYAZmpMmYa1LjUuPFEmKkuynolpToQioSL?= =?us-ascii?Q?r0r3l/SJHjQ60qcY6pG8Pa+PZJYGl+BZakP9SUnQ1/3+hYewDnxaEVgbo8T3?= =?us-ascii?Q?1KuMSOtJJYCdFoJs5lPejk8Olide/O1Sv1lmvSJYJN44W2MCz1ixsEnLFb/X?= =?us-ascii?Q?88LX8pT9RbXmByxCMFgJUYpD1GGznABbAWXXAfC41rve/xYRWIfEUEk9Jwso?= =?us-ascii?Q?7q7hd7N+IN5e0Jje/kXwq8Ppn0/fnDFeXEfxsiH3oqds3YA17Tt8fknXw0pg?= =?us-ascii?Q?eGVoumAzMRGgMrA6HEIiHw+Y3pVLLbK0LuxXr8vghHGTyP/08fqBQzpJnVgT?= =?us-ascii?Q?9R6nlD00w0wc+MzxAHseF5Q3PKyMXR3bWNA512FgZxlvKLbTn+r1gvX/g2K0?= =?us-ascii?Q?wBXXM6dBdNn8cc4QZvj/bNUjAo3dIBqKTIDFRizd09L1DeTLZM6mfXHMcSIi?= =?us-ascii?Q?mQzhdkzp4bXQDpCuXH9eSgzgQcMlWl4L7fNxB714kYUHzsvtJ596TmwABpZv?= =?us-ascii?Q?nZj0OnaRnjyJ8Zh+sh1xyRg8tHbU98sZ0aIQLu1VvPhyaPya5VZWFvSgwWKL?= =?us-ascii?Q?rrFGV9UR3HUQb7mDUcPjOCE5WuWVPtDFgrEeTWZoFpV/8QgwesIP8PDklJXZ?= =?us-ascii?Q?AMcTW/3haUZRx1UUoIbjuod2m5uoRhSkFwKvT7AgNNNENRmty91Wm6Nvk5f3?= =?us-ascii?Q?wcKfLXnt2CXvzxnul0cMgkgGg5z9zKEn7pFkhya7iDbsDZd2ncHfjYF5lZoT?= =?us-ascii?Q?5ajcNTtkgo3wcFju/katYLLCPuIhi2H8Gn0hcwOepMt6ZWCah+NBrd7L68Kz?= =?us-ascii?Q?wpfrOB+c+Ohz1A2qCg3vrIY4Bc5mJ7EFwoGtv8AeheHlzVRMYO0rGTb92g5g?= =?us-ascii?Q?jdmj7Uca7gbOSuIxcfp2p8pFsHGbp6pHVL72yfn8dhGUe4HYA3mAZrDnLSXj?= =?us-ascii?Q?JfQppBICAeQcqWlf8rZTGkP+9c1OGsqOYvLOaf80K2gV26mvuU0mhy6PK8pU?= =?us-ascii?Q?32M/uTzRayDtGFr9EnyOqyrUPiHxOpyyXYMrdsuIP4ZM0uiX1usgNu2kHgSn?= =?us-ascii?Q?6BnnZ1UGz/hjE5wy/9A3LfQ/NWVW8QZoKgRLRrlZUpktVSBxx1+A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB251;6:nGPjkmy8NHVAgQNZVsdTZ6QDNVHSNDZrG9Dia5g2jjhxZGiCK+oGnEsz4lVrEgR7SuuCCxUZCHKH0l/DMe88tB4xhQRxsWgkGWWmaLtz08NK0G2nL0jwMdBHnWgPABP1nmBMNqyYuRWAbOMBaQo5/GPB+TNqxkOD/U41KfCw0roKEBAX3kWcyJOWir4QeMDHJvWDKu6MKdU1f2GOt3oPX4v9bYsM3+OAWbnwE+5RwSeSY5eRFQfnOtjAO7LVkBo1U7JfT6MBuVd+GcWZrpAYC8T6BNm8Ae84Dbs2Be4TUuE=;5:guxtvs+TwBf0i3ndqre7zW/V4+/OUxVVXMkckVWRctttCSBJ2KPM/xxfSJbVHVaVyEYIxU0vkShOwYKuvFkS1Gc45Ai+gDCohEfhgmQgasJxmwC+nd8E1HTSbMA+lvVZH5xNK/s7HU8hZebrCnSAKZ7bfhcwEoAG/9wAsjktvkw=;24:rquwAb/FTzaJxlwxDztEKEes7mWu+Tfm2v7sVE2fespD7euOXyvk9QhjAoEnAbxE2VcdbGM2nEef+bYQxMoGNrQUK5HCbgBnG8VZxlsyeAY=;7:zL1noyMKyfJVwqIvAr31hyko0JvQsKx/gEVDNkHyhoF+ILe0+9Sjpt2SlGFH8wv53kII/QKBYDIU/MVjT7cd4CzRbRiYg58EqerZeeqoaeH+XkFWflmy2gdX847FkhVU0VubZ+84z0KegZV62WS5PWwA0tXsZNvg5JPAuAlC3d3K1F3QFGyVu4gZMTb5CLFBF8LNVQ72mhYWRSpvHfCBJNA3bWVhDkrAfN2M4tONJ2hcim+mf8hHDsZwfoLyLE7M SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2016 02:12:14.3435 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB251 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: Benjamin Gaignard Cc: Vincent Abriou Signed-off-by: Peter Chen --- drivers/gpu/drm/sti/sti_compositor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_compositor.c b/drivers/gpu/drm/sti/sti_compositor.c index 3d2fa3a..064de14 100644 --- a/drivers/gpu/drm/sti/sti_compositor.c +++ b/drivers/gpu/drm/sti/sti_compositor.c @@ -247,10 +247,12 @@ static int sti_compositor_probe(struct platform_device *pdev) vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 0); if (vtg_np) compo->vtg_main = of_vtg_find(vtg_np); + of_node_put(vtg_np); vtg_np = of_parse_phandle(pdev->dev.of_node, "st,vtg", 1); if (vtg_np) compo->vtg_aux = of_vtg_find(vtg_np); + of_node_put(vtg_np); platform_set_drvdata(pdev, compo); -- 1.9.1