From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [PATCH v23 04/22] vfs: Make the inode passed to inode_change_ok non-const Date: Tue, 05 Jul 2016 07:12:14 -0400 Message-ID: <1467717134.3800.7.camel@redhat.com> References: <1467294433-3222-1-git-send-email-agruenba@redhat.com> <1467294433-3222-5-git-send-email-agruenba@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1467294433-3222-5-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andreas Gruenbacher , Alexander Viro Cc: Christoph Hellwig , Theodore Ts'o , Andreas Dilger , "J. Bruce Fields" , Trond Myklebust , Anna Schumaker , Dave Chinner , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Thu, 2016-06-30 at 15:46 +0200, Andreas Gruenbacher wrote: > We will need to call iop->permission and iop->get_acl from > inode_change_ok() for additional permission checks, and both take a > non-const inode. >=20 > Signed-off-by: Andreas Gruenbacher > Reviewed-by: J. Bruce Fields > Reviewed-by: Andreas Dilger > Reviewed-by: Steve French > --- > =C2=A0fs/attr.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0| 2 +- > =C2=A0include/linux/fs.h | 2 +- > =C2=A02 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/fs/attr.c b/fs/attr.c > index 25b24d0..7ca7fa0 100644 > --- a/fs/attr.c > +++ b/fs/attr.c > @@ -28,7 +28,7 @@ > =C2=A0 * Should be called as the first thing in ->setattr implementat= ions, > =C2=A0 * possibly after taking additional locks. > =C2=A0 */ > -int inode_change_ok(const struct inode *inode, struct iattr *attr) > +int inode_change_ok(struct inode *inode, struct iattr *attr) > =C2=A0{ > =C2=A0 unsigned int ia_valid =3D attr->ia_valid; > =C2=A0 > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 86bfa10..208f73b 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2993,7 +2993,7 @@ extern int buffer_migrate_page(struct address_s= pace *, > =C2=A0#define buffer_migrate_page NULL > =C2=A0#endif > =C2=A0 > -extern int inode_change_ok(const struct inode *, struct iattr *); > +extern int inode_change_ok(struct inode *, struct iattr *); > =C2=A0extern int inode_newsize_ok(const struct inode *, loff_t offset= ); > =C2=A0extern void setattr_copy(struct inode *inode, const struct iatt= r *attr); > =C2=A0 Yuck. Bummer to lose the "const" there, but it doesn't look like it's possible to make those ops take a const arg. Reviewed-by: Jeff Layton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f173.google.com ([209.85.216.173]:32884 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754484AbcGELMR (ORCPT ); Tue, 5 Jul 2016 07:12:17 -0400 Received: by mail-qt0-f173.google.com with SMTP id c34so98823402qte.0 for ; Tue, 05 Jul 2016 04:12:17 -0700 (PDT) Message-ID: <1467717134.3800.7.camel@redhat.com> Subject: Re: [PATCH v23 04/22] vfs: Make the inode passed to inode_change_ok non-const From: Jeff Layton To: Andreas Gruenbacher , Alexander Viro Cc: Christoph Hellwig , "Theodore Ts'o" , Andreas Dilger , "J. Bruce Fields" , Trond Myklebust , Anna Schumaker , Dave Chinner , linux-ext4@vger.kernel.org, xfs@oss.sgi.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-api@vger.kernel.org Date: Tue, 05 Jul 2016 07:12:14 -0400 In-Reply-To: <1467294433-3222-5-git-send-email-agruenba@redhat.com> References: <1467294433-3222-1-git-send-email-agruenba@redhat.com> <1467294433-3222-5-git-send-email-agruenba@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, 2016-06-30 at 15:46 +0200, Andreas Gruenbacher wrote: > We will need to call iop->permission and iop->get_acl from > inode_change_ok() for additional permission checks, and both take a > non-const inode. > > Signed-off-by: Andreas Gruenbacher > Reviewed-by: J. Bruce Fields > Reviewed-by: Andreas Dilger > Reviewed-by: Steve French > --- >  fs/attr.c          | 2 +- >  include/linux/fs.h | 2 +- >  2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/attr.c b/fs/attr.c > index 25b24d0..7ca7fa0 100644 > --- a/fs/attr.c > +++ b/fs/attr.c > @@ -28,7 +28,7 @@ >   * Should be called as the first thing in ->setattr implementations, >   * possibly after taking additional locks. >   */ > -int inode_change_ok(const struct inode *inode, struct iattr *attr) > +int inode_change_ok(struct inode *inode, struct iattr *attr) >  { >   unsigned int ia_valid = attr->ia_valid; >   > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 86bfa10..208f73b 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2993,7 +2993,7 @@ extern int buffer_migrate_page(struct address_space *, >  #define buffer_migrate_page NULL >  #endif >   > -extern int inode_change_ok(const struct inode *, struct iattr *); > +extern int inode_change_ok(struct inode *, struct iattr *); >  extern int inode_newsize_ok(const struct inode *, loff_t offset); >  extern void setattr_copy(struct inode *inode, const struct iattr *attr); >   Yuck. Bummer to lose the "const" there, but it doesn't look like it's possible to make those ops take a const arg. Reviewed-by: Jeff Layton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 1EE867CC9 for ; Tue, 5 Jul 2016 06:12:20 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 9A66CAC002 for ; Tue, 5 Jul 2016 04:12:19 -0700 (PDT) Received: from mail-qt0-f180.google.com (mail-qt0-f180.google.com [209.85.216.180]) by cuda.sgi.com with ESMTP id CTKHRamLM6AZM5yG (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Tue, 05 Jul 2016 04:12:17 -0700 (PDT) Received: by mail-qt0-f180.google.com with SMTP id f89so98749536qtd.2 for ; Tue, 05 Jul 2016 04:12:17 -0700 (PDT) Message-ID: <1467717134.3800.7.camel@redhat.com> Subject: Re: [PATCH v23 04/22] vfs: Make the inode passed to inode_change_ok non-const From: Jeff Layton Date: Tue, 05 Jul 2016 07:12:14 -0400 In-Reply-To: <1467294433-3222-5-git-send-email-agruenba@redhat.com> References: <1467294433-3222-1-git-send-email-agruenba@redhat.com> <1467294433-3222-5-git-send-email-agruenba@redhat.com> Mime-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Andreas Gruenbacher , Alexander Viro Cc: "J. Bruce Fields" , linux-nfs@vger.kernel.org, Theodore Ts'o , linux-cifs@vger.kernel.org, linux-api@vger.kernel.org, Trond Myklebust , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Christoph Hellwig , Andreas Dilger , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Anna Schumaker T24gVGh1LCAyMDE2LTA2LTMwIGF0IDE1OjQ2ICswMjAwLCBBbmRyZWFzIEdydWVuYmFjaGVyIHdy b3RlOgo+IFdlIHdpbGwgbmVlZCB0byBjYWxsIGlvcC0+cGVybWlzc2lvbiBhbmQgaW9wLT5nZXRf YWNsIGZyb20KPiBpbm9kZV9jaGFuZ2Vfb2soKSBmb3IgYWRkaXRpb25hbCBwZXJtaXNzaW9uIGNo ZWNrcywgYW5kIGJvdGggdGFrZSBhCj4gbm9uLWNvbnN0IGlub2RlLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IEFuZHJlYXMgR3J1ZW5iYWNoZXIgPGFncnVlbmJhQHJlZGhhdC5jb20+Cj4gUmV2aWV3ZWQt Ynk6IEouIEJydWNlIEZpZWxkcyA8YmZpZWxkc0ByZWRoYXQuY29tPgo+IFJldmlld2VkLWJ5OiBB bmRyZWFzIERpbGdlciA8YWRpbGdlckBkaWxnZXIuY2E+Cj4gUmV2aWV3ZWQtYnk6IFN0ZXZlIEZy ZW5jaCA8c3RldmUuZnJlbmNoQHByaW1hcnlkYXRhLmNvbT4KPiAtLS0KPiDCoGZzL2F0dHIuY8Kg wqDCoMKgwqDCoMKgwqDCoMKgfCAyICstCj4gwqBpbmNsdWRlL2xpbnV4L2ZzLmggfCAyICstCj4g wqAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZnMvYXR0ci5jIGIvZnMvYXR0ci5jCj4gaW5kZXggMjViMjRkMC4uN2NhN2Zh MCAxMDA2NDQKPiAtLS0gYS9mcy9hdHRyLmMKPiArKysgYi9mcy9hdHRyLmMKPiBAQCAtMjgsNyAr MjgsNyBAQAo+IMKgICogU2hvdWxkIGJlIGNhbGxlZCBhcyB0aGUgZmlyc3QgdGhpbmcgaW4gLT5z ZXRhdHRyIGltcGxlbWVudGF0aW9ucywKPiDCoCAqIHBvc3NpYmx5IGFmdGVyIHRha2luZyBhZGRp dGlvbmFsIGxvY2tzLgo+IMKgICovCj4gLWludCBpbm9kZV9jaGFuZ2Vfb2soY29uc3Qgc3RydWN0 IGlub2RlICppbm9kZSwgc3RydWN0IGlhdHRyICphdHRyKQo+ICtpbnQgaW5vZGVfY2hhbmdlX29r KHN0cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVjdCBpYXR0ciAqYXR0cikKPiDCoHsKPiDCoAl1bnNp Z25lZCBpbnQgaWFfdmFsaWQgPSBhdHRyLT5pYV92YWxpZDsKPiDCoAo+IGRpZmYgLS1naXQgYS9p bmNsdWRlL2xpbnV4L2ZzLmggYi9pbmNsdWRlL2xpbnV4L2ZzLmgKPiBpbmRleCA4NmJmYTEwLi4y MDhmNzNiIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvZnMuaAo+ICsrKyBiL2luY2x1ZGUv bGludXgvZnMuaAo+IEBAIC0yOTkzLDcgKzI5OTMsNyBAQCBleHRlcm4gaW50IGJ1ZmZlcl9taWdy YXRlX3BhZ2Uoc3RydWN0IGFkZHJlc3Nfc3BhY2UgKiwKPiDCoCNkZWZpbmUgYnVmZmVyX21pZ3Jh dGVfcGFnZSBOVUxMCj4gwqAjZW5kaWYKPiDCoAo+IC1leHRlcm4gaW50IGlub2RlX2NoYW5nZV9v ayhjb25zdCBzdHJ1Y3QgaW5vZGUgKiwgc3RydWN0IGlhdHRyICopOwo+ICtleHRlcm4gaW50IGlu b2RlX2NoYW5nZV9vayhzdHJ1Y3QgaW5vZGUgKiwgc3RydWN0IGlhdHRyICopOwo+IMKgZXh0ZXJu IGludCBpbm9kZV9uZXdzaXplX29rKGNvbnN0IHN0cnVjdCBpbm9kZSAqLCBsb2ZmX3Qgb2Zmc2V0 KTsKPiDCoGV4dGVybiB2b2lkIHNldGF0dHJfY29weShzdHJ1Y3QgaW5vZGUgKmlub2RlLCBjb25z dCBzdHJ1Y3QgaWF0dHIgKmF0dHIpOwo+IMKgCgpZdWNrLiBCdW1tZXIgdG8gbG9zZSB0aGUgImNv bnN0IiB0aGVyZSwgYnV0IGl0IGRvZXNuJ3QgbG9vayBsaWtlIGl0J3MKcG9zc2libGUgdG8gbWFr ZSB0aG9zZSBvcHMgdGFrZSBhIGNvbnN0IGFyZy4KClJldmlld2VkLWJ5OiBKZWZmIExheXRvbiA8 amxheXRvbkByZWRoYXQuY29tPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KeGZzIG1haWxpbmcgbGlzdAp4ZnNAb3NzLnNnaS5jb20KaHR0cDovL29zcy5z Z2kuY29tL21haWxtYW4vbGlzdGluZm8veGZzCg==