From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755448AbcGFSLc (ORCPT ); Wed, 6 Jul 2016 14:11:32 -0400 Received: from smtprelay0243.hostedemail.com ([216.40.44.243]:47213 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752119AbcGFSLa (ORCPT ); Wed, 6 Jul 2016 14:11:30 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2110:2393:2559:2562:2828:2899:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:5007:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13071:13095:13161:13229:13311:13357:13439:13618:14180:14181:14659:21060:21080:21433,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: sun51_639bf829e7218 X-Filterd-Recvd-Size: 1704 Message-ID: <1467828683.8360.36.camel@perches.com> Subject: Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) From: Joe Perches To: Mike Marshall Cc: weiyj_lk@163.com, Wei Yongjun , LKML Date: Wed, 06 Jul 2016 11:11:23 -0700 In-Reply-To: References: <1467811431-2535-1-git-send-email-weiyj_lk@163.com> <1467827385.8360.30.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-07-06 at 14:00 -0400, Mike Marshall wrote: > Hi Joe... Hi Mike. > I looked around at other code to see how they were using vzalloc... > even if it is just the caller of the function that uses vzalloc, most > fs's that use vzalloc print an error message when vzalloc fails... That's incorrect. There are 72 v.alloc calls in fs/ 2 of those calls have a specific OOM message. There's 1 in reiserfs (old and unsupported) and 1 in orangefs > I sure do > like to follow the flow of our kernel module all in one place > with the gossip statements... I don't see how that matters here as there's already an OOM on v.alloc failure. cheers, Joe