All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joe MacDonald <Joe_MacDonald@mentor.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] dpkg-deb: strip virtual/ package prefix in control files
Date: Wed, 06 Jul 2016 22:25:36 +0100	[thread overview]
Message-ID: <1467840336.8590.218.camel@linuxfoundation.org> (raw)
In-Reply-To: <20160706173544.GB5805@mentor.com>

On Wed, 2016-07-06 at 13:35 -0400, Joe MacDonald wrote:
> [Re: [OE-core] [PATCH] dpkg-deb: strip virtual/ package prefix in
> control files] On 16.07.06 (Wed 17:48) Richard Purdie wrote:
> 
> > On Wed, 2016-07-06 at 09:45 -0400, Joe MacDonald wrote:
> > > If a recipe provides a 'virtual/foo', dpkg-deb will fail as '/'
> > > characters
> > > are not allowed in any of the Depends, Recommends, Suggests, etc.
> > > fields.
> > > The intent of these in the Debian package system and the few
> > > cases
> > > where
> > > they are used in Yocto layers seems like throwing away the
> > > 'virtual/'
> > > prefix preserves the intent, while not requiring it to be removed
> > > for
> > > package systems that allow it (eg. opkg and rpm).
> > > 
> > > Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
> > > ---
> > >  meta/classes/package_deb.bbclass | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > Our virtual/ namespace is only used in DEPENDS, not in the runtime
> > package namespaces (RDEPENDS, RRECOMMENDS and friends). We
> > therefore
> > shouldn't need this patch...
> 
> I first encountered this in the meta-selinux layer but it seemed to
> be
> doing a sensible thing there and then found an example here:
> 
> http://cgit.openembedded.org/cgit.cgi/meta-openembedded/tree/meta-oe/
> recipes-core/plymouth/plymouth_0.9.2.bb?h=master#n16
> 
> That said, there's so few examples like this, I can easily see it
> being
> an error in both spots.

It is incorrect in both cases, we don't support virtual/ in the runtime
namespace. We could change insane.bbclass to check for and error on
this...

Cheers,

Richard


      parent reply	other threads:[~2016-07-06 21:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06 13:45 [PATCH] dpkg-deb: strip virtual/ package prefix in control files Joe MacDonald
2016-07-06 16:48 ` Richard Purdie
     [not found]   ` <20160706173544.GB5805@mentor.com>
2016-07-06 21:25     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467840336.8590.218.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Joe_MacDonald@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.