From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Or Gerlitz <gerlitz.or@gmail.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>,
Linux Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
joel@jms.id.au, weixue@trustnetic.com,
Yuval Itkin <yuvali@mellanox.com>
Subject: Re: [PATCH net-next 00/10] NCSI Support
Date: Thu, 07 Jul 2016 19:17:36 +1000 [thread overview]
Message-ID: <1467883056.27157.28.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAJ3xEMgRqa_=MmPyRmOU=hUAF3o6N5A0dToa6hSwSut6QvosKw@mail.gmail.com>
On Thu, 2016-07-07 at 12:12 +0300, Or Gerlitz wrote:
> On Tue, Jul 5, 2016 at 8:44 PM, Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> > On Mon, Jul 04, 2016 at 01:03:06AM +0300, Or Gerlitz wrote:
>
> > Or, since cx4 has ncsi as well, could you do a thorough review of this
> > to make sure that it fits mellanox nics as well?
>
> Hi Alexei, all
>
> Yuval from our team who deals with host management did review on the
> series, SB his feedback.
>
> 1. The initialization uses a single unicast MAC address which hints it
> assumes that the management traffic is IPv4 only. The infrastructure
> does not seem to be ready for IPv6 based management traffic.
You mean the transfer of the MAC address from the BMC to the NIC for
filtering incoming traffic ?
> 2. The code enables AEN messages (all the 3 messages defined by the
> standard are enabled). AEN support mandates readiness on the BMC side
> (running the reviewed code) and mandates support on the NIC. Not every
> NIC can create AEN messages therefore I would recommend that the code
> will only enable AENs which are declared as supported. To query
> support for AEN messages, the BMC shall interpret the response for
> "Get Capabilities" command and based on the returned response it can
> detect which AEN message is supported by the NIC and may be enabled.
Ok.
> 3. When stating support for NC-SI it is important to indicate which
> exact version of NC-SI is supported (or required). From my observation
> this code is based on NC-SI 1.0.0 as it does not use any of the
> features which were introduced in the later versions.
Probably correct, 1.0.1 I think is the only one that was available when
we started that work. I found 1.1.0 on the DMTF web site, are you aware
of anything more recent ?
Gavin, you can get it here:
https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.1.0.pdf
> 4. HW arbitration is disabled in this implementation. It should be
> defined how to add support to system which supports HW arbitration.
>
> 5. The code has an initialization sequence which is clear. Yet there
> shall be a re-initialization sequence needed if a device goes through
> asynchronous entry to initial state, which may happen if the NIC goes
> through reset for any reason.
Ok.
Gavin: We can discuss these tomorrow if you need.
Cheers,
Ben.
next prev parent reply other threads:[~2016-07-07 9:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 5:32 [PATCH net-next 00/10] NCSI Support Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 01/10] net/ncsi: Resource management Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 02/10] net/ncsi: NCSI command packet handler Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 03/10] net/ncsi: NCSI response " Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 04/10] net/ncsi: Package and channel management Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 05/10] net/ncsi: NCSI AEN packet handler Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 06/10] net/farady: Helper functions to create or destroy MDIO interface Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 07/10] net/farady: Read MAC address from chip Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 08/10] net/farady: Support NCSI mode Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 09/10] net/farady: Match driver according to compatible property Gavin Shan
2016-07-03 5:32 ` [PATCH net-next 10/10] net/farady: Mask PHY interrupt with NCSI mode Gavin Shan
2016-07-03 22:03 ` [PATCH net-next 00/10] NCSI Support Or Gerlitz
2016-07-03 22:49 ` Benjamin Herrenschmidt
2016-07-04 0:24 ` Gavin Shan
2016-07-05 17:44 ` Alexei Starovoitov
2016-07-05 21:42 ` Benjamin Herrenschmidt
2016-07-06 2:07 ` Alexei Starovoitov
2016-07-06 2:14 ` Benjamin Herrenschmidt
2016-07-07 9:12 ` Or Gerlitz
2016-07-07 9:17 ` Benjamin Herrenschmidt [this message]
2016-07-07 9:18 ` Benjamin Herrenschmidt
2016-07-07 13:05 ` Gavin Shan
2016-07-07 13:44 ` Or Gerlitz
2016-07-07 16:34 ` Gavin Shan
2016-07-07 17:32 ` Florian Fainelli
2016-07-07 22:05 ` Benjamin Herrenschmidt
2016-07-08 1:10 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467883056.27157.28.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=netdev@vger.kernel.org \
--cc=weixue@trustnetic.com \
--cc=yuvali@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.