From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Thu, 07 Jul 2016 09:55:04 -0700 Message-ID: <1467910504.2322.9.camel@HansenPartnership.com> References: <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160707161425.GO4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx , "Syrjala, Ville" , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMDE2LTA3LTA3IGF0IDE5OjE0ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gVHVlLCBKdW4gMjEsIDIwMTYgYXQgMDY6NDQ6MzRQTSArMDMwMCwgVmlsbGUgU3lyasOk bMOkIHdyb3RlOgo+ID4gT24gVHVlLCBKdW4gMjEsIDIwMTYgYXQgMDk6NTM6MTVBTSAtMDQwMCwg SmFtZXMgQm90dG9tbGV5IHdyb3RlOgo+ID4gPiBPbiBNb24sIDIwMTYtMDYtMjAgYXQgMTE6MDMg KzAzMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4gPiA+IENjOiBWaWxsZQo+ID4gPiA+IAo+ID4g PiA+IE9uIE1vbiwgMjAgSnVuIDIwMTYsIEphbWVzIEJvdHRvbWxleSA8Cj4gPiA+ID4gSmFtZXMu Qm90dG9tbGV5QEhhbnNlblBhcnRuZXJzaGlwLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPiBPSywgbXkg Y2FuZGlkYXRlIGJhZCBjb21taXQgaXMgdGhpcyBvbmU6Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IGNv bW1pdCBhMDU2MjgxOTVhMGQ5ZjMxNzNkZDlhYTc2ZjQ4MmFlZjY5MmU0NmVlCj4gPiA+ID4gPiBB dXRob3I6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g PiA+ID4gPiBEYXRlOiAgIE1vbiBBcHIgMTEgMTA6MjM6NTEgMjAxNiArMDMwMAo+ID4gPiA+ID4g Cj4gPiA+ID4gPiAgICAgZHJtL2k5MTU6IEdldCBwYW5lbF90eXBlIGZyb20gT3BSZWdpb24gcGFu ZWwgZGV0YWlscwo+ID4gPiA+ID4gCj4gPiA+ID4gPiBBZnRlciBiZWluZyBtb3JlIGNhcmVmdWwg YWJvdXQgd2FpdGluZyB0byBpZGVudGlmeSBmbGlja2VyLCAKPiA+ID4gPiA+IHRoaXMgb25lIHNl ZW1zIHRvIGJlIHRoZSBvbmUgdGhlIGJpc2VjdCBmaW5kcy4gIEknbSBub3cgCj4gPiA+ID4gPiBy dW5uaW5nIHY0LjctcmMzIHdpdGggdGhpcyBvbmUgcmV2ZXJ0ZWQgYW5kIGFtIGN1cnJlbnRseSAK PiA+ID4gPiA+IHNlZWluZyBubyBmbGlja2VyIHByb2JsZW1zLiAgIEl0IGlzLCBob3dldmVyLCBl YXJseSBkYXlzIAo+ID4gPiA+ID4gYmVjYXVzZSB0aGUgZmxpY2tlciBjYW4gaGlkZSBmb3IgbG9u ZyBwZXJpb2RzLCBzbyBJICdsbCB3YWl0IAo+ID4gPiA+ID4gdW50aWwgTW9uZGF5IGV2ZW5pbmcg YW5kIGEgZmV3IHJlYm9vdHMgYmVmb3JlIGRlY2xhcmluZwo+ID4gPiA+ID4gdmljdG9yeS4KPiA+ ID4gPiAKPiA+ID4gPiBJZiB0aGF0IHR1cm5zIG91dCB0byBiZSB0aGUgYmFkIGNvbW1pdCwgaXQg ZG9lc24ndCByZWFsbHkgCj4gPiA+ID4gc3VycHJpc2UgbWUsIGFuZCB0aGF0IGluIGl0c2VsZiBp cyBkZXByZXNzaW5nLgo+ID4gPiAKPiA+ID4gQXMgZmFyIGFzIEkgY2FuIHRlbGwsIGFmdGVyIHJ1 bm5pbmcgZm9yIGEgZGF5IHdpdGggdGhpcyByZXZlcnRlZCwgCj4gPiA+IHRoaXMgaXMgdGhlIHBy b2JsZW0uICBUaGUgZmxpY2tlciBoYXNuJ3QgYXBwZWFyZWQgd2l0aCBpdCAKPiA+ID4gcmV2ZXJ0 ZWQuICBJdCdzIHByZXR0eSBub3RpY2VhYmxlIHdpdGggdGhpcyBjb21taXQgaW5jbHVkZWQuCj4g PiAKPiA+IEhtbS4gVGhlIG9ubHkgZGlmZmVyZW5jZSBJIGNhbiBzZWUgaXMgbG93IHZzLiBub3Jt YWwgdnN3aW5nLiBQYW5lbCAKPiA+IDAgaGFzIGxvdywgcGFuZWwgMiBoYXMgbm9ybWFsLiBTbyBl aXRoZXIgdGhlIFZCVCBvciBvcHJlZ2lvbiBpcyAKPiA+IHRlbGxpbmcgdXR0ZXIgbGllcywgb3Ig dGhlcmUncyBzb21lIG90aGVyIGJ1ZyBpbiBvdXIgbG93IHZzd2luZwo+ID4gc3VwcG9ydC4KPiAK PiBJIGRpZCBhIHF1aWNrIG9uY2Ugb3ZlciBvZiBvdXQgRERJIHZzd2luZyBzdHVmZiBhbmQgZGlk bid0IGZpbmQgCj4gYW55dGhpbmcgdG9vIHNlcmlvdXMuIFRoZXJlIHdlcmUgc29tZSBidWdsZXRz IGluIHRoZSBpYm9vc3QgaGFuZGxpbmcsIAo+IGJ1dCBJJ20gbm90IHZlcnkgaG9wZWZ1bCB0aGF0 IGZpeGluZyB0aG9zZSB3b3VsZCBoZWxwIHdpdGggeW91ciAKPiBtYWNoaW5lLiAKPiAKPiBIZXJl J3MgYSBicmFuY2ggYW55d2F5IGluIGNhc2UgeW91IHdhbnQgdG8gZ2l2ZSBpdCBhIGdvOgo+IGdp dDovL2dpdGh1Yi5jb20vdnN5cmphbGEvbGludXguZ2l0IGRkaV9pYm9vc3RfZml4ZXMKPiAKPiBB Y3R1YWxseSwgSSB0aGluayB0aGUgb25seSBwYXRjaCBpbiB0aGVyZSB0aGF0IG1pZ2h0IG1ha2Ug YSAKPiBkaWZmZXJlbmNlIGlzIDE1ZDg4Nzg1NTE4MCAoImRybS9pOTE1OiBGaXggaWJvb3N0IHNl dHRpbmcgZm9yIERESSAKPiB3aXRoIDQgbGFuZXMgb24gU0tMIikKClJ1bm5pbmcgd2l0aCBpdCBu b3cgKHRoZSBlbnRpcmUgYnJhbmNoKS4gIFNvIGZhciBpdCBsb29rcyBPSywgYnV0IEknbGwKZ2l2 ZSBpdCBhIGNvdXBsZSBvZiBkYXlzIHRvIHNlZSBpZiBhbnl0aGluZyBtYW5pZmVzdHMgYmVmb3Jl IGRlY2xhcmluZwp2aWN0b3J5LgoKSmFtZXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752837AbcGGQzS (ORCPT ); Thu, 7 Jul 2016 12:55:18 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:47160 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbcGGQzL (ORCPT ); Thu, 7 Jul 2016 12:55:11 -0400 Message-ID: <1467910504.2322.9.camel@HansenPartnership.com> Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window From: James Bottomley To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: "Syrjala, Ville" , intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi Date: Thu, 07 Jul 2016 09:55:04 -0700 In-Reply-To: <20160707161425.GO4329@intel.com> References: <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-07-07 at 19:14 +0300, Ville Syrjälä wrote: > On Tue, Jun 21, 2016 at 06:44:34PM +0300, Ville Syrjälä wrote: > > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > > Cc: Ville > > > > > > > > On Mon, 20 Jun 2016, James Bottomley < > > > > James.Bottomley@HansenPartnership.com> wrote: > > > > > OK, my candidate bad commit is this one: > > > > > > > > > > commit a05628195a0d9f3173dd9aa76f482aef692e46ee > > > > > Author: Ville Syrjälä > > > > > Date: Mon Apr 11 10:23:51 2016 +0300 > > > > > > > > > > drm/i915: Get panel_type from OpRegion panel details > > > > > > > > > > After being more careful about waiting to identify flicker, > > > > > this one seems to be the one the bisect finds. I'm now > > > > > running v4.7-rc3 with this one reverted and am currently > > > > > seeing no flicker problems. It is, however, early days > > > > > because the flicker can hide for long periods, so I 'll wait > > > > > until Monday evening and a few reboots before declaring > > > > > victory. > > > > > > > > If that turns out to be the bad commit, it doesn't really > > > > surprise me, and that in itself is depressing. > > > > > > As far as I can tell, after running for a day with this reverted, > > > this is the problem. The flicker hasn't appeared with it > > > reverted. It's pretty noticeable with this commit included. > > > > Hmm. The only difference I can see is low vs. normal vswing. Panel > > 0 has low, panel 2 has normal. So either the VBT or opregion is > > telling utter lies, or there's some other bug in our low vswing > > support. > > I did a quick once over of out DDI vswing stuff and didn't find > anything too serious. There were some buglets in the iboost handling, > but I'm not very hopeful that fixing those would help with your > machine. > > Here's a branch anyway in case you want to give it a go: > git://github.com/vsyrjala/linux.git ddi_iboost_fixes > > Actually, I think the only patch in there that might make a > difference is 15d887855180 ("drm/i915: Fix iboost setting for DDI > with 4 lanes on SKL") Running with it now (the entire branch). So far it looks OK, but I'll give it a couple of days to see if anything manifests before declaring victory. James