From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Thu, 07 Jul 2016 12:19:36 -0700 Message-ID: <1467919176.2322.38.camel@HansenPartnership.com> References: <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> <1467910504.2322.9.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1467910504.2322.9.camel@HansenPartnership.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx , "Syrjala, Ville" , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMDE2LTA3LTA3IGF0IDA5OjU1IC0wNzAwLCBKYW1lcyBCb3R0b21sZXkgd3JvdGU6 Cj4gT24gVGh1LCAyMDE2LTA3LTA3IGF0IDE5OjE0ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3Jv dGU6Cj4gPiBPbiBUdWUsIEp1biAyMSwgMjAxNiBhdCAwNjo0NDozNFBNICswMzAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgSnVuIDIxLCAyMDE2IGF0IDA5OjUzOjE1QU0g LTA0MDAsIEphbWVzIEJvdHRvbWxleSB3cm90ZToKPiA+ID4gPiBPbiBNb24sIDIwMTYtMDYtMjAg YXQgMTE6MDMgKzAzMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4gPiA+ID4gQ2M6IFZpbGxlCj4g PiA+ID4gPiAKPiA+ID4gPiA+IE9uIE1vbiwgMjAgSnVuIDIwMTYsIEphbWVzIEJvdHRvbWxleSA8 Cj4gPiA+ID4gPiBKYW1lcy5Cb3R0b21sZXlASGFuc2VuUGFydG5lcnNoaXAuY29tPiB3cm90ZToK PiA+ID4gPiA+ID4gT0ssIG15IGNhbmRpZGF0ZSBiYWQgY29tbWl0IGlzIHRoaXMgb25lOgo+ID4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gY29tbWl0IGEwNTYyODE5NWEwZDlmMzE3M2RkOWFhNzZmNDgy YWVmNjkyZTQ2ZWUKPiA+ID4gPiA+ID4gQXV0aG9yOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiA+ID4gPiBEYXRlOiAgIE1vbiBBcHIgMTEgMTA6 MjM6NTEgMjAxNiArMDMwMAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gICAgIGRybS9pOTE1OiBH ZXQgcGFuZWxfdHlwZSBmcm9tIE9wUmVnaW9uIHBhbmVsIGRldGFpbHMKPiA+ID4gPiA+ID4gCj4g PiA+ID4gPiA+IEFmdGVyIGJlaW5nIG1vcmUgY2FyZWZ1bCBhYm91dCB3YWl0aW5nIHRvIGlkZW50 aWZ5IGZsaWNrZXIsCj4gPiA+ID4gPiA+IHRoaXMgb25lIHNlZW1zIHRvIGJlIHRoZSBvbmUgdGhl IGJpc2VjdCBmaW5kcy4gIEknbSBub3cgCj4gPiA+ID4gPiA+IHJ1bm5pbmcgdjQuNy1yYzMgd2l0 aCB0aGlzIG9uZSByZXZlcnRlZCBhbmQgYW0gY3VycmVudGx5IAo+ID4gPiA+ID4gPiBzZWVpbmcg bm8gZmxpY2tlciBwcm9ibGVtcy4gICBJdCBpcywgaG93ZXZlciwgZWFybHkgZGF5cyAKPiA+ID4g PiA+ID4gYmVjYXVzZSB0aGUgZmxpY2tlciBjYW4gaGlkZSBmb3IgbG9uZyBwZXJpb2RzLCBzbyBJ ICdsbAo+ID4gPiA+ID4gPiB3YWl0IAo+ID4gPiA+ID4gPiB1bnRpbCBNb25kYXkgZXZlbmluZyBh bmQgYSBmZXcgcmVib290cyBiZWZvcmUgZGVjbGFyaW5nCj4gPiA+ID4gPiA+IHZpY3RvcnkuCj4g PiA+ID4gPiAKPiA+ID4gPiA+IElmIHRoYXQgdHVybnMgb3V0IHRvIGJlIHRoZSBiYWQgY29tbWl0 LCBpdCBkb2Vzbid0IHJlYWxseSAKPiA+ID4gPiA+IHN1cnByaXNlIG1lLCBhbmQgdGhhdCBpbiBp dHNlbGYgaXMgZGVwcmVzc2luZy4KPiA+ID4gPiAKPiA+ID4gPiBBcyBmYXIgYXMgSSBjYW4gdGVs bCwgYWZ0ZXIgcnVubmluZyBmb3IgYSBkYXkgd2l0aCB0aGlzCj4gPiA+ID4gcmV2ZXJ0ZWQsIAo+ ID4gPiA+IHRoaXMgaXMgdGhlIHByb2JsZW0uICBUaGUgZmxpY2tlciBoYXNuJ3QgYXBwZWFyZWQg d2l0aCBpdCAKPiA+ID4gPiByZXZlcnRlZC4gIEl0J3MgcHJldHR5IG5vdGljZWFibGUgd2l0aCB0 aGlzIGNvbW1pdCBpbmNsdWRlZC4KPiA+ID4gCj4gPiA+IEhtbS4gVGhlIG9ubHkgZGlmZmVyZW5j ZSBJIGNhbiBzZWUgaXMgbG93IHZzLiBub3JtYWwgdnN3aW5nLgo+ID4gPiBQYW5lbCAKPiA+ID4g MCBoYXMgbG93LCBwYW5lbCAyIGhhcyBub3JtYWwuIFNvIGVpdGhlciB0aGUgVkJUIG9yIG9wcmVn aW9uIGlzIAo+ID4gPiB0ZWxsaW5nIHV0dGVyIGxpZXMsIG9yIHRoZXJlJ3Mgc29tZSBvdGhlciBi dWcgaW4gb3VyIGxvdyB2c3dpbmcKPiA+ID4gc3VwcG9ydC4KPiA+IAo+ID4gSSBkaWQgYSBxdWlj ayBvbmNlIG92ZXIgb2Ygb3V0IERESSB2c3dpbmcgc3R1ZmYgYW5kIGRpZG4ndCBmaW5kIAo+ID4g YW55dGhpbmcgdG9vIHNlcmlvdXMuIFRoZXJlIHdlcmUgc29tZSBidWdsZXRzIGluIHRoZSBpYm9v c3QKPiA+IGhhbmRsaW5nLCAKPiA+IGJ1dCBJJ20gbm90IHZlcnkgaG9wZWZ1bCB0aGF0IGZpeGlu ZyB0aG9zZSB3b3VsZCBoZWxwIHdpdGggeW91ciAKPiA+IG1hY2hpbmUuIAo+ID4gCj4gPiBIZXJl J3MgYSBicmFuY2ggYW55d2F5IGluIGNhc2UgeW91IHdhbnQgdG8gZ2l2ZSBpdCBhIGdvOgo+ID4g Z2l0Oi8vZ2l0aHViLmNvbS92c3lyamFsYS9saW51eC5naXQgZGRpX2lib29zdF9maXhlcwo+ID4g Cj4gPiBBY3R1YWxseSwgSSB0aGluayB0aGUgb25seSBwYXRjaCBpbiB0aGVyZSB0aGF0IG1pZ2h0 IG1ha2UgYSAKPiA+IGRpZmZlcmVuY2UgaXMgMTVkODg3ODU1MTgwICgiZHJtL2k5MTU6IEZpeCBp Ym9vc3Qgc2V0dGluZyBmb3IgRERJIAo+ID4gd2l0aCA0IGxhbmVzIG9uIFNLTCIpCj4gCj4gUnVu bmluZyB3aXRoIGl0IG5vdyAodGhlIGVudGlyZSBicmFuY2gpLiAgU28gZmFyIGl0IGxvb2tzIE9L LCBidXQgCj4gSSdsbCBnaXZlIGl0IGEgY291cGxlIG9mIGRheXMgdG8gc2VlIGlmIGFueXRoaW5n IG1hbmlmZXN0cyBiZWZvcmUKPiBkZWNsYXJpbmcgdmljdG9yeS4KCkJhZCBuZXdzLCBJJ20gYWZy YWlkOiBhZnRlciBhIGNvdXBsZSBvZiBob3VycyBvZiBydW4gdGltZSwgdGhlcmUgaXMgbm93Cm5v dGljZWFibGUgZmxpY2tlciBvbiB0aGUgZGlzcGxheSwgc28gYWx0aG91Z2ggdGhlIGlib29zdCBm aXhlcyBtYXkKaGF2ZSBsZXNzZW5lZCBpdCwgaXQncyBzdGlsbCBwcmVzZW50LgoKSmFtZXMKCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932075AbcGGTTo (ORCPT ); Thu, 7 Jul 2016 15:19:44 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:48064 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbcGGTTi (ORCPT ); Thu, 7 Jul 2016 15:19:38 -0400 Message-ID: <1467919176.2322.38.camel@HansenPartnership.com> Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window From: James Bottomley To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: "Syrjala, Ville" , intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi Date: Thu, 07 Jul 2016 12:19:36 -0700 In-Reply-To: <1467910504.2322.9.camel@HansenPartnership.com> References: <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> <1467910504.2322.9.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-07-07 at 09:55 -0700, James Bottomley wrote: > On Thu, 2016-07-07 at 19:14 +0300, Ville Syrjälä wrote: > > On Tue, Jun 21, 2016 at 06:44:34PM +0300, Ville Syrjälä wrote: > > > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > > > Cc: Ville > > > > > > > > > > On Mon, 20 Jun 2016, James Bottomley < > > > > > James.Bottomley@HansenPartnership.com> wrote: > > > > > > OK, my candidate bad commit is this one: > > > > > > > > > > > > commit a05628195a0d9f3173dd9aa76f482aef692e46ee > > > > > > Author: Ville Syrjälä > > > > > > Date: Mon Apr 11 10:23:51 2016 +0300 > > > > > > > > > > > > drm/i915: Get panel_type from OpRegion panel details > > > > > > > > > > > > After being more careful about waiting to identify flicker, > > > > > > this one seems to be the one the bisect finds. I'm now > > > > > > running v4.7-rc3 with this one reverted and am currently > > > > > > seeing no flicker problems. It is, however, early days > > > > > > because the flicker can hide for long periods, so I 'll > > > > > > wait > > > > > > until Monday evening and a few reboots before declaring > > > > > > victory. > > > > > > > > > > If that turns out to be the bad commit, it doesn't really > > > > > surprise me, and that in itself is depressing. > > > > > > > > As far as I can tell, after running for a day with this > > > > reverted, > > > > this is the problem. The flicker hasn't appeared with it > > > > reverted. It's pretty noticeable with this commit included. > > > > > > Hmm. The only difference I can see is low vs. normal vswing. > > > Panel > > > 0 has low, panel 2 has normal. So either the VBT or opregion is > > > telling utter lies, or there's some other bug in our low vswing > > > support. > > > > I did a quick once over of out DDI vswing stuff and didn't find > > anything too serious. There were some buglets in the iboost > > handling, > > but I'm not very hopeful that fixing those would help with your > > machine. > > > > Here's a branch anyway in case you want to give it a go: > > git://github.com/vsyrjala/linux.git ddi_iboost_fixes > > > > Actually, I think the only patch in there that might make a > > difference is 15d887855180 ("drm/i915: Fix iboost setting for DDI > > with 4 lanes on SKL") > > Running with it now (the entire branch). So far it looks OK, but > I'll give it a couple of days to see if anything manifests before > declaring victory. Bad news, I'm afraid: after a couple of hours of run time, there is now noticeable flicker on the display, so although the iboost fixes may have lessened it, it's still present. James