From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Alex Lemberg <alex.lemberg@sandisk.com>,
Mateusz Nowak <mateusz.nowak@intel.com>,
Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Dong Aisheng <dongas86@gmail.com>,
Das Asutosh <asutoshd@codeaurora.org>,
Zhangfei Gao <zhangfei.gao@gmail.com>,
Dorfman Konstantin <kdorfman@codeaurora.org>,
David Griego <david.griego@linaro.org>,
Sahitya Tummala <stummala@codeaurora.org>,
Harjani Ritesh <riteshh@codeaurora.org>,
Venu Byravarasu <vbyravarasu@nvidia.com>
Subject: [PATCH V3 03/30] mmc: sdhci: Support cap_cmd_during_tfr requests
Date: Fri, 8 Jul 2016 13:22:44 +0300 [thread overview]
Message-ID: <1467973391-29221-4-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1467973391-29221-1-git-send-email-adrian.hunter@intel.com>
Now SDHCI supports commands during transfer, enable support for the core
API.
There are 3 small changes needed:
First, auto-CMD12 cannot be used with a cap_cmd_during_tfr request because
the host controller cannot expect the command line to be available.
Secondly, a cap_cmd_during_tfr request must not send a stop command, again
because the host controller cannot expect the command line to be available.
Thirdly, when a cap_cmd_during_tfr command completes, use
mmc_command_complete() to notify the upper layers that the command line is
now available for further commands.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
drivers/mmc/host/sdhci.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 2ee8bfa77116..d60149203083 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -884,7 +884,8 @@ static void sdhci_prepare_data(struct sdhci_host *host, struct mmc_command *cmd)
static inline bool sdhci_auto_cmd12(struct sdhci_host *host,
struct mmc_request *mrq)
{
- return !mrq->sbc && (host->flags & SDHCI_AUTO_CMD12);
+ return !mrq->sbc && (host->flags & SDHCI_AUTO_CMD12) &&
+ !mrq->cap_cmd_during_tfr;
}
static void sdhci_set_transfer_mode(struct sdhci_host *host,
@@ -1027,9 +1028,18 @@ static void sdhci_finish_data(struct sdhci_host *host)
sdhci_do_reset(host, SDHCI_RESET_DATA);
}
- /* Avoid triggering warning in sdhci_send_command() */
- host->cmd = NULL;
- sdhci_send_command(host, data->stop);
+ /*
+ * 'cap_cmd_during_tfr' request must not use the command line
+ * after mmc_command_done() has been called. It is upper layer's
+ * responsibility to send the stop command if required.
+ */
+ if (data->mrq->cap_cmd_during_tfr) {
+ sdhci_finish_mrq(host, data->mrq);
+ } else {
+ /* Avoid triggering warning in sdhci_send_command() */
+ host->cmd = NULL;
+ sdhci_send_command(host, data->stop);
+ }
} else {
sdhci_finish_mrq(host, data->mrq);
}
@@ -1161,6 +1171,9 @@ static void sdhci_finish_command(struct sdhci_host *host)
}
}
+ if (cmd->mrq->cap_cmd_during_tfr && cmd == cmd->mrq->cmd)
+ mmc_command_done(host->mmc, cmd->mrq);
+
/*
* The host can send and interrupt when the busy state has
* ended, allowing us to wait without wasting CPU cycles.
--
1.9.1
next prev parent reply other threads:[~2016-07-08 10:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 10:22 [PATCH V3 00/30] mmc: mmc: Add Software Command Queuing Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 01/30] mmc: core: Add support for sending commands during data transfer Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 02/30] mmc: mmc_test: Add tests for sending commands during transfer Adrian Hunter
2016-07-08 10:22 ` Adrian Hunter [this message]
2016-07-08 10:22 ` [PATCH V3 04/30] mmc: sdhci-pci: Set MMC_CAP_CMD_DURING_TFR for Intel eMMC controllers Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 05/30] mmc: sdhci-acpi: " Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 06/30] mmc: queue: Fix queue thread wake-up Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 07/30] mmc: queue: Factor out mmc_queue_alloc_bounce_bufs() Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 08/30] mmc: queue: Factor out mmc_queue_alloc_bounce_sgs() Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 09/30] mmc: queue: Factor out mmc_queue_alloc_sgs() Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 10/30] mmc: queue: Factor out mmc_queue_reqs_free_bufs() Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 11/30] mmc: queue: Introduce queue depth Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 12/30] mmc: queue: Use queue depth to allocate and free Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 13/30] mmc: queue: Allocate queue of size qdepth Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 14/30] mmc: mmc: Add Command Queue definitions Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 15/30] mmc: mmc: Add functions to enable / disable the Command Queue Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 16/30] mmc: mmc_test: Disable Command Queue while mmc_test is used Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 17/30] mmc: block: Disable Command Queue while RPMB " Adrian Hunter
2016-07-08 10:22 ` [PATCH V3 18/30] mmc: core: Do not prepare a new request twice Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 19/30] mmc: core: Export mmc_retune_hold() and mmc_retune_release() Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 20/30] mmc: block: Factor out mmc_blk_requeue() Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 21/30] mmc: block: Fix 4K native sector check Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 22/30] mmc: block: Use local var for mqrq_cur Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 23/30] mmc: block: Pass mqrq to mmc_blk_prep_packed_list() Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 24/30] mmc: block: Introduce queue semantics Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 25/30] mmc: queue: Share mmc request array between partitions Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 26/30] mmc: queue: Add a function to control wake-up on new requests Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 27/30] mmc: block: Add Software Command Queuing Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 28/30] mmc: mmc: Enable " Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 29/30] mmc: sdhci-pci: Enable Software Command Queuing for some Intel controllers Adrian Hunter
2016-07-08 10:46 ` Venu Byravarasu
2016-07-08 10:59 ` Adrian Hunter
2016-07-08 10:23 ` [PATCH V3 30/30] mmc: sdhci-acpi: " Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467973391-29221-4-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=Yuliy.Izrailov@sandisk.com \
--cc=alex.lemberg@sandisk.com \
--cc=asutoshd@codeaurora.org \
--cc=david.griego@linaro.org \
--cc=dongas86@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=kdorfman@codeaurora.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mateusz.nowak@intel.com \
--cc=riteshh@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbyravarasu@nvidia.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.