From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Fri, 08 Jul 2016 07:48:29 -0700 Message-ID: <1467989309.2245.2.camel@HansenPartnership.com> References: <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> <1467910504.2322.9.camel@HansenPartnership.com> <1467919176.2322.38.camel@HansenPartnership.com> <20160708101934.GQ4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160708101934.GQ4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx , "Syrjala, Ville" , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyMDE2LTA3LTA4IGF0IDEzOjE5ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gVGh1LCBKdWwgMDcsIDIwMTYgYXQgMTI6MTk6MzZQTSAtMDcwMCwgSmFtZXMgQm90dG9t bGV5IHdyb3RlOgo+ID4gT24gVGh1LCAyMDE2LTA3LTA3IGF0IDA5OjU1IC0wNzAwLCBKYW1lcyBC b3R0b21sZXkgd3JvdGU6Cj4gPiA+IE9uIFRodSwgMjAxNi0wNy0wNyBhdCAxOToxNCArMDMwMCwg VmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgSnVuIDIxLCAyMDE2IGF0IDA2 OjQ0OjM0UE0gKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ID4gPiA+IE9uIFR1ZSwg SnVuIDIxLCAyMDE2IGF0IDA5OjUzOjE1QU0gLTA0MDAsIEphbWVzIEJvdHRvbWxleQo+ID4gPiA+ ID4gd3JvdGU6Cj4gPiA+ID4gPiA+IE9uIE1vbiwgMjAxNi0wNi0yMCBhdCAxMTowMyArMDMwMCwg SmFuaSBOaWt1bGEgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gQ2M6IFZpbGxlCj4gPiA+ID4gPiA+ID4g Cj4gPiA+ID4gPiA+ID4gT24gTW9uLCAyMCBKdW4gMjAxNiwgSmFtZXMgQm90dG9tbGV5IDwKPiA+ ID4gPiA+ID4gPiBKYW1lcy5Cb3R0b21sZXlASGFuc2VuUGFydG5lcnNoaXAuY29tPiB3cm90ZToK PiA+ID4gPiA+ID4gPiA+IE9LLCBteSBjYW5kaWRhdGUgYmFkIGNvbW1pdCBpcyB0aGlzIG9uZToK PiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gY29tbWl0IGEwNTYyODE5NWEwZDlmMzE3 M2RkOWFhNzZmNDgyYWVmNjkyZTQ2ZWUKPiA+ID4gPiA+ID4gPiA+IEF1dGhvcjogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gPiA+ID4gPiA+IERh dGU6ICAgTW9uIEFwciAxMSAxMDoyMzo1MSAyMDE2ICswMzAwCj4gPiA+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gPiA+ICAgICBkcm0vaTkxNTogR2V0IHBhbmVsX3R5cGUgZnJvbSBPcFJlZ2lvbiBw YW5lbAo+ID4gPiA+ID4gPiA+ID4gZGV0YWlscwo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ ID4gPiBBZnRlciBiZWluZyBtb3JlIGNhcmVmdWwgYWJvdXQgd2FpdGluZyB0byBpZGVudGlmeQo+ ID4gPiA+ID4gPiA+ID4gZmxpY2tlciwKPiA+ID4gPiA+ID4gPiA+IHRoaXMgb25lIHNlZW1zIHRv IGJlIHRoZSBvbmUgdGhlIGJpc2VjdCBmaW5kcy4gIEknbSBub3cKPiA+ID4gPiA+ID4gPiA+IHJ1 bm5pbmcgdjQuNy1yYzMgd2l0aCB0aGlzIG9uZSByZXZlcnRlZCBhbmQgYW0KPiA+ID4gPiA+ID4g PiA+IGN1cnJlbnRseSAKPiA+ID4gPiA+ID4gPiA+IHNlZWluZyBubyBmbGlja2VyIHByb2JsZW1z LiAgIEl0IGlzLCBob3dldmVyLCBlYXJseQo+ID4gPiA+ID4gPiA+ID4gZGF5cyAKPiA+ID4gPiA+ ID4gPiA+IGJlY2F1c2UgdGhlIGZsaWNrZXIgY2FuIGhpZGUgZm9yIGxvbmcgcGVyaW9kcywgc28g SSAnbGwKPiA+ID4gPiA+ID4gPiA+IHdhaXQgCj4gPiA+ID4gPiA+ID4gPiB1bnRpbCBNb25kYXkg ZXZlbmluZyBhbmQgYSBmZXcgcmVib290cyBiZWZvcmUgZGVjbGFyaW5nCj4gPiA+ID4gPiA+ID4g PiB2aWN0b3J5Lgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IElmIHRoYXQgdHVybnMgb3V0 IHRvIGJlIHRoZSBiYWQgY29tbWl0LCBpdCBkb2Vzbid0IHJlYWxseQo+ID4gPiA+ID4gPiA+IHN1 cnByaXNlIG1lLCBhbmQgdGhhdCBpbiBpdHNlbGYgaXMgZGVwcmVzc2luZy4KPiA+ID4gPiA+ID4g Cj4gPiA+ID4gPiA+IEFzIGZhciBhcyBJIGNhbiB0ZWxsLCBhZnRlciBydW5uaW5nIGZvciBhIGRh eSB3aXRoIHRoaXMKPiA+ID4gPiA+ID4gcmV2ZXJ0ZWQsIAo+ID4gPiA+ID4gPiB0aGlzIGlzIHRo ZSBwcm9ibGVtLiAgVGhlIGZsaWNrZXIgaGFzbid0IGFwcGVhcmVkIHdpdGggaXQgCj4gPiA+ID4g PiA+IHJldmVydGVkLiAgSXQncyBwcmV0dHkgbm90aWNlYWJsZSB3aXRoIHRoaXMgY29tbWl0Cj4g PiA+ID4gPiA+IGluY2x1ZGVkLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBIbW0uIFRoZSBvbmx5IGRp ZmZlcmVuY2UgSSBjYW4gc2VlIGlzIGxvdyB2cy4gbm9ybWFsIHZzd2luZy4KPiA+ID4gPiA+IFBh bmVsIAo+ID4gPiA+ID4gMCBoYXMgbG93LCBwYW5lbCAyIGhhcyBub3JtYWwuIFNvIGVpdGhlciB0 aGUgVkJUIG9yIG9wcmVnaW9uCj4gPiA+ID4gPiBpcyAKPiA+ID4gPiA+IHRlbGxpbmcgdXR0ZXIg bGllcywgb3IgdGhlcmUncyBzb21lIG90aGVyIGJ1ZyBpbiBvdXIgbG93Cj4gPiA+ID4gPiB2c3dp bmcKPiA+ID4gPiA+IHN1cHBvcnQuCj4gPiA+ID4gCj4gPiA+ID4gSSBkaWQgYSBxdWljayBvbmNl IG92ZXIgb2Ygb3V0IERESSB2c3dpbmcgc3R1ZmYgYW5kIGRpZG4ndCBmaW5kCj4gPiA+ID4gYW55 dGhpbmcgdG9vIHNlcmlvdXMuIFRoZXJlIHdlcmUgc29tZSBidWdsZXRzIGluIHRoZSBpYm9vc3QK PiA+ID4gPiBoYW5kbGluZywgCj4gPiA+ID4gYnV0IEknbSBub3QgdmVyeSBob3BlZnVsIHRoYXQg Zml4aW5nIHRob3NlIHdvdWxkIGhlbHAgd2l0aCB5b3VyCj4gPiA+ID4gbWFjaGluZS4gCj4gPiA+ ID4gCj4gPiA+ID4gSGVyZSdzIGEgYnJhbmNoIGFueXdheSBpbiBjYXNlIHlvdSB3YW50IHRvIGdp dmUgaXQgYSBnbzoKPiA+ID4gPiBnaXQ6Ly9naXRodWIuY29tL3ZzeXJqYWxhL2xpbnV4LmdpdCBk ZGlfaWJvb3N0X2ZpeGVzCj4gPiA+ID4gCj4gPiA+ID4gQWN0dWFsbHksIEkgdGhpbmsgdGhlIG9u bHkgcGF0Y2ggaW4gdGhlcmUgdGhhdCBtaWdodCBtYWtlIGEgCj4gPiA+ID4gZGlmZmVyZW5jZSBp cyAxNWQ4ODc4NTUxODAgKCJkcm0vaTkxNTogRml4IGlib29zdCBzZXR0aW5nIGZvcgo+ID4gPiA+ IERESSAKPiA+ID4gPiB3aXRoIDQgbGFuZXMgb24gU0tMIikKPiA+ID4gCj4gPiA+IFJ1bm5pbmcg d2l0aCBpdCBub3cgKHRoZSBlbnRpcmUgYnJhbmNoKS4gIFNvIGZhciBpdCBsb29rcyBPSywgYnV0 Cj4gPiA+IEknbGwgZ2l2ZSBpdCBhIGNvdXBsZSBvZiBkYXlzIHRvIHNlZSBpZiBhbnl0aGluZyBt YW5pZmVzdHMgYmVmb3JlCj4gPiA+IGRlY2xhcmluZyB2aWN0b3J5Lgo+ID4gCj4gPiBCYWQgbmV3 cywgSSdtIGFmcmFpZDogYWZ0ZXIgYSBjb3VwbGUgb2YgaG91cnMgb2YgcnVuIHRpbWUsIHRoZXJl IGlzCj4gPiBub3cKPiA+IG5vdGljZWFibGUgZmxpY2tlciBvbiB0aGUgZGlzcGxheSwgc28gYWx0 aG91Z2ggdGhlIGlib29zdCBmaXhlcyBtYXkKPiA+IGhhdmUgbGVzc2VuZWQgaXQsIGl0J3Mgc3Rp bGwgcHJlc2VudC4KPiAKPiBPaCB3ZWxsLCBJIHN1c3BlY3RlZCBhcyBtdWNoLiBXaGljaCBCSU9T IHZlcnNpb24gZGlkIHlvdSBoYXZlIAo+IGV4YWN0bHk/CgpBcyBtZW50aW9uZWQgdXB0aHJlYWQs IG5vdyAxLjQuMyBzaW5jZSBza3lsYWtlIG1pY3JvY29kZSB3YXMKcG90ZW50aWFsbHkgaW1wbGlj YXRlZCBpbiB0aGUgcHJvYmxlbToKCmh0dHA6Ly9taWQuZ21hbmUub3JnLzE0NjYxNzk3MjkuMjI3 MS4zMy5jYW1lbEBIYW5zZW5QYXJ0bmVyc2hpcC5jb20KCj4gSWYgSSdtIHJlYWRpbmcgdGhlIERl bGwgd2Vic2l0ZSBjb3JyZWN0bHkgdGhlcmUncyBhIG5ldyBvbmUgKDEuNC40KQo+IHJlbGVhc2Vk IG9uIEp1biAzMCwgd2hpY2ggaXMgYWZ0ZXIgeW91IHJlcG9ydGVkIHRoZSBpc3N1ZS4gTWlnaHQg YmUKPiBJJ20gcmVhZGluZyB0aGUgd3JvbmcgdGhpbmcgdGhvdWdoLiBDYW4geW91IGRvdWJsZSBj aGVjayB0aGlzPwoKTmV3IGJpb3MgZG9lc24ndCBjaGFuZ2UgdGhlIG1pY3JvY29kZToKClsgICAg Mi4zOTAxNzJdIG1pY3JvY29kZTogQ1BVMCBzaWc9MHg0MDZlMywgcGY9MHg4MCwgcmV2aXNpb249 MHg4YQoKQW5kIHRoZSBmbGlja2VyIGlzIHN0aWxsIHByZXNlbnQuCgpKYW1lcwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932371AbcGHOuU (ORCPT ); Fri, 8 Jul 2016 10:50:20 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:53476 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755165AbcGHOsi (ORCPT ); Fri, 8 Jul 2016 10:48:38 -0400 Message-ID: <1467989309.2245.2.camel@HansenPartnership.com> Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window From: James Bottomley To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: "Syrjala, Ville" , intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi Date: Fri, 08 Jul 2016 07:48:29 -0700 In-Reply-To: <20160708101934.GQ4329@intel.com> References: <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> <1467910504.2322.9.camel@HansenPartnership.com> <1467919176.2322.38.camel@HansenPartnership.com> <20160708101934.GQ4329@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-07-08 at 13:19 +0300, Ville Syrjälä wrote: > On Thu, Jul 07, 2016 at 12:19:36PM -0700, James Bottomley wrote: > > On Thu, 2016-07-07 at 09:55 -0700, James Bottomley wrote: > > > On Thu, 2016-07-07 at 19:14 +0300, Ville Syrjälä wrote: > > > > On Tue, Jun 21, 2016 at 06:44:34PM +0300, Ville Syrjälä wrote: > > > > > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley > > > > > wrote: > > > > > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > > > > > Cc: Ville > > > > > > > > > > > > > > On Mon, 20 Jun 2016, James Bottomley < > > > > > > > James.Bottomley@HansenPartnership.com> wrote: > > > > > > > > OK, my candidate bad commit is this one: > > > > > > > > > > > > > > > > commit a05628195a0d9f3173dd9aa76f482aef692e46ee > > > > > > > > Author: Ville Syrjälä > > > > > > > > Date: Mon Apr 11 10:23:51 2016 +0300 > > > > > > > > > > > > > > > > drm/i915: Get panel_type from OpRegion panel > > > > > > > > details > > > > > > > > > > > > > > > > After being more careful about waiting to identify > > > > > > > > flicker, > > > > > > > > this one seems to be the one the bisect finds. I'm now > > > > > > > > running v4.7-rc3 with this one reverted and am > > > > > > > > currently > > > > > > > > seeing no flicker problems. It is, however, early > > > > > > > > days > > > > > > > > because the flicker can hide for long periods, so I 'll > > > > > > > > wait > > > > > > > > until Monday evening and a few reboots before declaring > > > > > > > > victory. > > > > > > > > > > > > > > If that turns out to be the bad commit, it doesn't really > > > > > > > surprise me, and that in itself is depressing. > > > > > > > > > > > > As far as I can tell, after running for a day with this > > > > > > reverted, > > > > > > this is the problem. The flicker hasn't appeared with it > > > > > > reverted. It's pretty noticeable with this commit > > > > > > included. > > > > > > > > > > Hmm. The only difference I can see is low vs. normal vswing. > > > > > Panel > > > > > 0 has low, panel 2 has normal. So either the VBT or opregion > > > > > is > > > > > telling utter lies, or there's some other bug in our low > > > > > vswing > > > > > support. > > > > > > > > I did a quick once over of out DDI vswing stuff and didn't find > > > > anything too serious. There were some buglets in the iboost > > > > handling, > > > > but I'm not very hopeful that fixing those would help with your > > > > machine. > > > > > > > > Here's a branch anyway in case you want to give it a go: > > > > git://github.com/vsyrjala/linux.git ddi_iboost_fixes > > > > > > > > Actually, I think the only patch in there that might make a > > > > difference is 15d887855180 ("drm/i915: Fix iboost setting for > > > > DDI > > > > with 4 lanes on SKL") > > > > > > Running with it now (the entire branch). So far it looks OK, but > > > I'll give it a couple of days to see if anything manifests before > > > declaring victory. > > > > Bad news, I'm afraid: after a couple of hours of run time, there is > > now > > noticeable flicker on the display, so although the iboost fixes may > > have lessened it, it's still present. > > Oh well, I suspected as much. Which BIOS version did you have > exactly? As mentioned upthread, now 1.4.3 since skylake microcode was potentially implicated in the problem: http://mid.gmane.org/1466179729.2271.33.camel@HansenPartnership.com > If I'm reading the Dell website correctly there's a new one (1.4.4) > released on Jun 30, which is after you reported the issue. Might be > I'm reading the wrong thing though. Can you double check this? New bios doesn't change the microcode: [ 2.390172] microcode: CPU0 sig=0x406e3, pf=0x80, revision=0x8a And the flicker is still present. James