From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/5] Improve wireless netdev detection
Date: Fri, 08 Jul 2016 17:26:33 +0200 [thread overview]
Message-ID: <1467991593.4837.7.camel@sipsolutions.net> (raw)
In-Reply-To: <577FC51E.7010901@gmail.com> (sfid-20160708_172209_534342_D9E86FEB)
On Fri, 2016-07-08 at 10:22 -0500, Denis Kenzior wrote:
>
> Apologies, I've only been looking at the kernel side for several
> days, so my understanding is still incomplete.
>
> I was looking at mac80211/iface.c: ieee80211_if_add() which seems to
> handle NL80211_IFTYPE_P2P_DEVICE specially by not
> creating/registering a
> net_device object. For some reason I thought that this object was
> registered somewhere later, but my understanding was incorrect. So
> the entire 'side effect' paragraph above does not apply.
Ok, makes sense.
> Are you okay with the general approach?
I see no issues with sending these events out. I'd like them to
actually be reliable (if present) though, not double as you'd implied -
but I didn't really understand in which cases you were expecting
issues, was it only P2P-Device?
> Are there any locking issues I
> might be overlooking?
Not that I'm aware of. All of the netdev/wdev handling should be
protected by RTNL.
johannes
next prev parent reply other threads:[~2016-07-08 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:08 [PATCH 0/5] Improve wireless netdev detection Denis Kenzior
2016-07-07 7:08 ` [PATCH 1/5] nl80211: Add nl80211_notify_iface Denis Kenzior
2016-07-07 7:08 ` [PATCH 2/5] core: Notify of new wireless netdevs Denis Kenzior
2016-07-07 7:08 ` [PATCH 3/5] nl80211: Emit NEW_INTERFACE only in special cases Denis Kenzior
2016-07-07 7:08 ` [PATCH 4/5] core: Notify when wireless netdev is removed Denis Kenzior
2016-07-07 7:08 ` [PATCH 5/5] nl80211: Emit DEL_INTERFACE only in special cases Denis Kenzior
2016-07-08 10:32 ` [PATCH 0/5] Improve wireless netdev detection Johannes Berg
2016-07-08 15:22 ` Denis Kenzior
2016-07-08 15:26 ` Johannes Berg [this message]
2016-07-08 15:31 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467991593.4837.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.