From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756172AbcGHTdL (ORCPT ); Fri, 8 Jul 2016 15:33:11 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33936 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbcGHTdI (ORCPT ); Fri, 8 Jul 2016 15:33:08 -0400 Date: Fri, 08 Jul 2016 21:32:53 +0200 From: Samuele Baisi Subject: Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue. To: Luis de Bethencourt Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Message-Id: <1468006373.12580.0@smtp.gmail.com> In-Reply-To: <577FEE45.5070509@osg.samsung.com> References: <1467718439-13271-1-git-send-email-ciccio87@gmail.com> <577FEE45.5070509@osg.samsung.com> X-Mailer: geary/0.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il giorno ven 8 lug 2016 alle 20:17, Luis de Bethencourt ha scritto: > On 05/07/16 12:33, Samuele Baisi wrote: >> Removed a blankline after an opening bracket. >> >> Signed-off-by: Samuele Baisi >> --- >> drivers/staging/gdm724x/gdm_tty.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/staging/gdm724x/gdm_tty.c >> b/drivers/staging/gdm724x/gdm_tty.c >> index eb7e252..ae39663 100644 >> --- a/drivers/staging/gdm724x/gdm_tty.c >> +++ b/drivers/staging/gdm724x/gdm_tty.c >> @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev >> *tty_dev, struct device *device) >> int j; >> >> for (i = 0; i < TTY_MAX_COUNT; i++) { >> - >> gdm = kmalloc(sizeof(*gdm), GFP_KERNEL); >> if (!gdm) >> return -ENOMEM; >> > > Patch applies cleanly and removes the checkpath issue. > > Acked-by: Luis de Bethencourt > > Samuele, > > It is a good idea to include the issue you are solving in the commit > message, in this case it would be: > > Removed a blankline after an opening bracket. > > CHECK: Blank lines aren't necessary after an open brace '{' > #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228: > + for (i = 0; i < TTY_MAX_COUNT; i++) { > + > > Signed-off-by: > --- > > Thanks :) > Luis Ok, next time I'll try to be more clear. Thank you very much and best regards. Samuele