From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: Re: [PATCH] v4l: Clarify RGB666 pixel format definition
Date: Tue, 09 Sep 2014 16:18:15 +0300 [thread overview]
Message-ID: <1468017.Vb1L5kusHW@avalon> (raw)
In-Reply-To: <53CD97D2.1010408@xs4all.nl>
On Tuesday 22 July 2014 00:44:34 Hans Verkuil wrote:
> On 07/22/2014 12:30 AM, Laurent Pinchart wrote:
> > On Monday 21 July 2014 23:43:16 Hans Verkuil wrote:
> >> On 07/21/2014 10:39 PM, Laurent Pinchart wrote:
> >>> The RGB666 pixel format doesn't include an alpha channel. Document it as
> >>> such.
> >>>
> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >>> ---
> >>>
> >>> .../DocBook/media/v4l/pixfmt-packed-rgb.xml | 20
> >>> +++++----------
> >>>
> >>> 1 file changed, 6 insertions(+), 14 deletions(-)
> >>>
> >>> diff --git a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> >>> b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml index
> >>> 32feac9..c47692a 100644
> >>> --- a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> >>> +++ b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> >>> @@ -330,20 +330,12 @@ colorspace
> >>> <constant>V4L2_COLORSPACE_SRGB</constant>.</para>>
> >>> <entry></entry>
> >>> <entry>r<subscript>1</subscript></entry>
> >>> <entry>r<subscript>0</subscript></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> - <entry></entry>
> >>> + <entry>-</entry>
> >>> + <entry>-</entry>
> >>> + <entry>-</entry>
> >>> + <entry>-</entry>
> >>> + <entry>-</entry>
> >>> + <entry>-</entry>
> >>
> >> Just to clarify: BGR666 is a three byte format, not a four byte format?
> >
> > Well... :-)
> >
> > Three drivers seem to support the BGR666 in mainline : sh_veu, s3c-camif
> > and exynos4-is. Further investigation shows that the sh_veu driver lists
> > the BGR666 format internally but doesn't expose it to userspace and
> > doesn't actually support it, so we're down to two drivers.
> >
> > Looking at the S3C6410 datasheet, it's unclear how the hardware stores
> > RGB666 pixels in memory. It could be either
> >
> > Byte 0 Byte 1 Byte 2 Byte 3
> >
> > -------- ------RR RRRRGGGG GGBBBBBB
> >
> > or
> >
> > GGBBBBBB RRRRGGGG ------RR --------
> >
> > None of those correspond to the RGB666 format defined in the spec.
> >
> > The Exynos4 FIMC isn't documented in the public datasheet, so I can't
> > check how the format is defined.
> >
> > Furthermore, various Renesas video-related IP cores support many different
> > RGB666 variants, on either 32 or 24 bits per pixel, with and without
> > alpha.
> >
> > Beside a loud *sigh*, any comment ? :-)
>
> You'll have to check with Samsung then. Sylwester, can you shed any light on
> what this format *really* is?
Ping ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-09-09 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 20:39 [PATCH] v4l: Clarify RGB666 pixel format definition Laurent Pinchart
2014-07-21 21:43 ` Hans Verkuil
2014-07-21 22:30 ` Laurent Pinchart
2014-07-21 22:44 ` Hans Verkuil
2014-09-09 13:18 ` Laurent Pinchart [this message]
2014-09-09 14:45 ` Sylwester Nawrocki
2014-10-29 11:45 ` Laurent Pinchart
2015-11-09 22:21 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468017.Vb1L5kusHW@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.