From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Mayer Subject: [PATCH v3 2/7] drm/nouveau/core: make use of new strlcpytolower() function Date: Fri, 8 Jul 2016 15:43:09 -0700 Message-ID: <1468017794-4818-3-git-send-email-mmayer@broadcom.com> References: <1468017794-4818-1-git-send-email-mmayer@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1468017794-4818-1-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Ben Skeggs , David Airlie , Alexandre Courbot Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: nouveau.vger.kernel.org Q2FsbCBzdHJsY3B5dG9sb3dlcigpIHJhdGhlciB0aGFuIGNvcHlpbmcgdGhlIHN0cmluZyBleHBs aWNpdGx5IGFuZAp0aGVuIHdhbGtpbmcgaXQgdG8gY29udmVydCBpdCB0byBsb3dlcmNhc2UuCgpT aWduZWQtb2ZmLWJ5OiBNYXJrdXMgTWF5ZXIgPG1tYXllckBicm9hZGNvbS5jb20+Ci0tLQoKVGhl IHNlbWFudGljcyBvZiB0aGUgbmV3IGZ1bmN0aW9uIGhhcyBjaGFuZ2VkLCBzbyB0aGlzIHBhdGNo IGhhcyBiZWVuCnVwZGF0ZWQgc2luY2UgdjIgdG8gbWF0Y2ggdGhlIG5ldyBzdHJsY3B5KCkgc2Vt YW50aWNzIChubyBleHBsaWNpdCBOVUxMCnRlcm1pbmF0aW5nIGlzIHJlcXVpcmVkKS4KClNlZSBo dHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzkyMTUyMDcvIGZvciB0aGUgcHJldmlv dXMgdmVyc2lvbi4KCgogZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9jb3JlL2Zpcm13YXJl LmMgfCA5ICstLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA4IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vY29yZS9m aXJtd2FyZS5jIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9jb3JlL2Zpcm13YXJlLmMK aW5kZXggMzRlY2Q0YS4uOTgyNjAxZSAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL25vdXZl YXUvbnZrbS9jb3JlL2Zpcm13YXJlLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZr bS9jb3JlL2Zpcm13YXJlLmMKQEAgLTM2LDE2ICszNiw5IEBAIG52a21fZmlybXdhcmVfZ2V0KHN0 cnVjdCBudmttX2RldmljZSAqZGV2aWNlLCBjb25zdCBjaGFyICpmd25hbWUsCiB7CiAJY2hhciBm WzY0XTsKIAljaGFyIGNuYW1lWzE2XTsKLQlpbnQgaTsKIAogCS8qIENvbnZlcnQgZGV2aWNlIG5h bWUgdG8gbG93ZXJjYXNlICovCi0Jc3RybmNweShjbmFtZSwgZGV2aWNlLT5jaGlwLT5uYW1lLCBz aXplb2YoY25hbWUpKTsKLQljbmFtZVtzaXplb2YoY25hbWUpIC0gMV0gPSAnXDAnOwotCWkgPSBz dHJsZW4oY25hbWUpOwotCXdoaWxlIChpKSB7Ci0JCS0taTsKLQkJY25hbWVbaV0gPSB0b2xvd2Vy KGNuYW1lW2ldKTsKLQl9CisJc3RybGNweXRvbG93ZXIoY25hbWUsIGRldmljZS0+Y2hpcC0+bmFt ZSwgc2l6ZW9mKGNuYW1lKSk7CiAKIAlzbnByaW50ZihmLCBzaXplb2YoZiksICJudmlkaWEvJXMv JXMuYmluIiwgY25hbWUsIGZ3bmFtZSk7CiAJcmV0dXJuIHJlcXVlc3RfZmlybXdhcmUoZncsIGYs IGRldmljZS0+ZGV2KTsKLS0gCjIuNy40CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpOb3V2ZWF1IG1haWxpbmcgbGlzdApOb3V2ZWF1QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L25vdXZlYXUK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932998AbcGHWpQ (ORCPT ); Fri, 8 Jul 2016 18:45:16 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35665 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932768AbcGHWoJ (ORCPT ); Fri, 8 Jul 2016 18:44:09 -0400 From: Markus Mayer To: Ben Skeggs , David Airlie , Alexandre Courbot Cc: Markus Mayer , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/7] drm/nouveau/core: make use of new strlcpytolower() function Date: Fri, 8 Jul 2016 15:43:09 -0700 Message-Id: <1468017794-4818-3-git-send-email-mmayer@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468017794-4818-1-git-send-email-mmayer@broadcom.com> References: <1468017794-4818-1-git-send-email-mmayer@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Call strlcpytolower() rather than copying the string explicitly and then walking it to convert it to lowercase. Signed-off-by: Markus Mayer --- The semantics of the new function has changed, so this patch has been updated since v2 to match the new strlcpy() semantics (no explicit NULL terminating is required). See https://patchwork.kernel.org/patch/9215207/ for the previous version. drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c index 34ecd4a..982601e 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c @@ -36,16 +36,9 @@ nvkm_firmware_get(struct nvkm_device *device, const char *fwname, { char f[64]; char cname[16]; - int i; /* Convert device name to lowercase */ - strncpy(cname, device->chip->name, sizeof(cname)); - cname[sizeof(cname) - 1] = '\0'; - i = strlen(cname); - while (i) { - --i; - cname[i] = tolower(cname[i]); - } + strlcpytolower(cname, device->chip->name, sizeof(cname)); snprintf(f, sizeof(f), "nvidia/%s/%s.bin", cname, fwname); return request_firmware(fw, f, device->dev); -- 2.7.4