All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ritesh Raj Sarraf <rrs@debian.org>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: Dragan@redhat.com,
	Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>,
	Stancevic <dragan.stancevic@canonical.com>,
	device-mapper development <dm-devel@redhat.com>,
	Louis Bouchard <louis.bouchard@canonical.com>
Subject: Re: [PATCH 2/3] multipath-tools: merge OPTFLAGS into CFLAGS
Date: Sat, 09 Jul 2016 11:19:31 +0200	[thread overview]
Message-ID: <1468055971.5895.0.camel@debian.org> (raw)
In-Reply-To: <1467995301-14226-3-git-send-email-xose.vazquez@gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Thanks Xose.

These changes are good with Debian.


Ritesh

On Fri, 2016-07-08 at 18:28 +0200, Xose Vazquez Perez wrote:
> OPTFLAGS is not used anywhere, but maybe it's intrusive for distributions.
> 
> Cc: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
> Cc: Dragan Stancevic <dragan.stancevic@canonical.com>
> Cc: Louis Bouchard <louis.bouchard@canonical.com>
> Cc: Ritesh Raj Sarraf <rrs@debian.org>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  Makefile.inc | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile.inc b/Makefile.inc
> index 01d743c..b7077fc 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -60,10 +60,9 @@ RM          = rm -f
>  LN          = ln -sf
>  INSTALL_PROGRAM = install
>  
> -OPTFLAGS     = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security
> -Wall \
> -		-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --
> param=ssp-buffer-size=4
> -
> -CFLAGS	     = $(OPTFLAGS) -fPIC -DLIB_STRING=\"${LIB}\"
> -DRUN_DIR=\"${RUN}\"
> +CFLAGS      = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security
> -Wall \
> +		-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --
> param=ssp-buffer-size=4 \
> +		-fPIC -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\"
>  SHARED_FLAGS = -shared
>  
>  %.o:	%.c
- -- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJXgMGjAAoJEKY6WKPy4XVps3IP/i8WjCdrGN/bhfpQgrt9wE09
JzYcLtqHMoUv3tT+YqJW3vpNgAn5UIujKkMogYbp5krvfG9MP4YFL0Vn4wI3EBTm
XXRnaBumHzE+QYhec7WnlTLEcv1RExyvyx8V1cqX7fFCzZfQGmjmoFQDL1CPN82Z
XbY0QfZWHBbpkNn57P7oCNGqnbL0IyqvVnNcTxmczALgySmp59w8WIS72kSiwMEH
mAgfYZ1Feql8Q1mQu1cQN8pPcFZgK0M4r2RtZ0SiQcQVtXVCDuhWCMQzV1eEvhPL
tAg78AJjnLFMDR8k9spKaGdLoyef7lTtxxUxyM6hEs08IpqxgedYD2lZvjqLNQmG
QTkkDfqDRnf+qeLuJMTxRCJavAXVO1f29ukynJ2Tm98LElxDEuW9UP10hGUHGA5U
KyBt/fCW9AUr0uTqO95+SCcHhNMyLuqDP5rZVJ7hCcbUtzGTbrAlQ8LIbX6BYDAc
tTTn27ZqGtQkV4h49YjIzhX8csCzrYejyI6ltIuKiePIPba2QnjaRp65C0zsR4IM
Gy7hvmugVIY7vMTFev9nk3qIgzu5kY6tA15Mw39o7Fc8uRyrFytmfX6Pzsv/OKCx
WKNpUYf3C5rU8OOdQ73fT2dEmb++rS99SB7Z0jEAAT9OCeDp+ffB+FVtm7rhohSF
lUrdul6jSduwV2pSlA5s
=NVXI
-----END PGP SIGNATURE-----

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2016-07-09  9:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 16:28 [PATCH 0/3] Makefiles housekeeping III Xose Vazquez Perez
2016-07-08 16:28 ` [PATCH 1/3] multipath-tools: install libs in a standard way Xose Vazquez Perez
2016-07-08 16:28 ` [PATCH 2/3] multipath-tools: merge OPTFLAGS into CFLAGS Xose Vazquez Perez
2016-07-09  9:19   ` Ritesh Raj Sarraf [this message]
2016-07-15 10:19   ` Hannes Reinecke
2016-07-22  9:43     ` Christophe Varoqui
2016-07-08 16:28 ` [PATCH 3/3] multipath-tools: delete INSTALL_PROGRAM from libmpathpersist/Makefile Xose Vazquez Perez
2016-07-09  8:04 ` [PATCH 0/3] Makefiles housekeeping III Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468055971.5895.0.camel@debian.org \
    --to=rrs@debian.org \
    --cc=Dragan@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=dragan.stancevic@canonical.com \
    --cc=louis.bouchard@canonical.com \
    --cc=mathieu.trudel-lapierre@canonical.com \
    --cc=xose.vazquez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.