From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] sunxi: Add support for multiple ethadrr-esses
Date: Sun, 10 Jul 2016 09:15:20 +0100 [thread overview]
Message-ID: <1468138520.10653.2.camel@hellion.org.uk> (raw)
In-Reply-To: <1468069935-1212-1-git-send-email-hdegoede@redhat.com>
On Sat, 2016-07-09 at 15:12 +0200, Hans de Goede wrote:
> Currently we fill ethaddr with a fixed unique address based on the
> SoCs
> serial (from the sid) to make sure that boards which use the
> integrated
> emac / gmac get a fixed mac rather then a random one.
>
> On some boards the wifi does not come with a fixed mac either, so we
> need
> to also set eth1addr.
>
> This commit changes the ethaddr setting code to check for ethernet%d
> aliases (as fdt_fixup_ethernet does) and set an ethaddr variable for
> all present aliases.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
> [...]
> +static void setup_environment(const void *fdt)
It might be worth adding a commit to this function noting that it must
remain idempotent.
Ian.
next prev parent reply other threads:[~2016-07-10 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 13:12 [U-Boot] [PATCH v2] sunxi: Add support for multiple ethadrr-esses Hans de Goede
2016-07-10 8:15 ` Ian Campbell [this message]
2016-07-11 9:02 ` Hans de Goede
2016-07-11 13:08 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468138520.10653.2.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.