From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933358AbcGJMdr (ORCPT ); Sun, 10 Jul 2016 08:33:47 -0400 Received: from smtprelay0015.hostedemail.com ([216.40.44.15]:36085 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932411AbcGJMdq (ORCPT ); Sun, 10 Jul 2016 08:33:46 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:901:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3167:3352:3622:3657:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:6691:6742:9025:9388:10004:10400:10848:11232:11257:11658:11854:11914:12043:12296:12438:12517:12519:12555:12740:13069:13141:13230:13311:13357:13439:13894:14181:14659:14721:21063:21080:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: soup86_344c011a243f X-Filterd-Recvd-Size: 2017 Message-ID: <1468154020.8360.114.camel@perches.com> Subject: Re: [tip:x86/debug] printk: Make the printk*once() variants return a value From: Joe Perches To: Borislav Petkov Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, luto@kernel.org, hpa@zytor.com, peterz@infradead.org, brgerst@gmail.com, torvalds@linux-foundation.org, tglx@linutronix.de, luto@amacapital.net, dvlasenk@redhat.com, fweisbec@gmail.com, jpoimboe@redhat.com, bp@suse.de, linux-tip-commits@vger.kernel.org Date: Sun, 10 Jul 2016 05:33:40 -0700 In-Reply-To: <20160710120631.GA5553@nazgul.tnic> References: <1467671487-10344-3-git-send-email-bp@alien8.de> <1468032048.8360.85.camel@perches.com> <20160709075003.GA3822@pd.tnic> <1468087015.8360.103.camel@perches.com> <20160710064958.GA4690@nazgul.tnic> <1468139031.8360.105.camel@perches.com> <20160710120631.GA5553@nazgul.tnic> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-07-10 at 14:06 +0200, Borislav Petkov wrote: > On Sun, Jul 10, 2016 at 01:23:51AM -0700, Joe Perches wrote: > > > > Assuming tip is included in linux-next as of july 8, yes. > Try one which has http://git.kernel.org/tip/81c2949f7fdcf8ff681326669a > fde24962232670 That commit isn't in -next and this change to add a return value to no_printk in _this_ patch is, as I wrote, not required here. It's fine that no_printk return a 0 value, but it should be introduced in a separate patch that introduces that requirement or at least mentioned in the changelog of this patch _why_ it's it to be changed.  Otherwise, the change just appears spurious.