From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: [PATCH v1 1/6] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Date: Mon, 11 Jul 2016 19:05:36 +0800 Message-ID: <1468235136-29417-1-git-send-email-ykk@rock-chips.com> References: <1468235079-29152-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1468235079-29152-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao , Heiko Stuebner , Rob Herring , Russell King , Philipp Zabel , Andy Yan Cc: devicetree@vger.kernel.org, Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Douglas Anderson , linux-rockchip@lists.infradead.org, Kumar Gala , xhc@rock-chips.com, linux-arm-kernel@lists.infradead.org, Zheng Yang List-Id: linux-rockchip.vger.kernel.org RnJvbTogRG91Z2xhcyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3JnPgoKSml0dGVyIHdh cyBpbXByb3ZlZCBieSBsb3dlcmluZyB0aGUgTVBMTCBiYW5kd2lkdGggdG8gYWNjb3VudCBmb3Ig aGlnaApmcmVxdWVuY3kgbm9pc2UgaW4gdGhlIHJrMzI4OCBQTEwuICBJbiBlYWNoIGNhc2UgTVBM TCBiYW5kd2lkdGggd2FzCmxvd2VyZWQgb25seSBlbm91Z2ggdG8gZ2V0IHVzIGEgY29tZm9ydGFi bGUgbWFyZ2luLiAgV2UgYmVsaWV2ZSB0aGF0Cmxvd2VyaW5nIHRoZSBiYW5kd2lkdGggbGlrZSB0 aGlzIGlzIHNhZmUgZ2l2ZW4gc3VmZmljaWVudCB0ZXN0aW5nLgoKU2lnbmVkLW9mZi1ieTogRG91 Z2xhcyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3JnPgpTaWduZWQtb2ZmLWJ5OiBZYWtp ciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlw L2R3X2hkbWktcm9ja2NoaXAuYyB8IDE2ICsrLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9kd19oZG1pLXJvY2tjaGlwLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvZHdfaGRtaS1yb2NrY2hpcC5jCmluZGV4IDgwMTExMGYuLmE2MjExMTggMTAwNjQ0Ci0t LSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kd19oZG1pLXJvY2tjaGlwLmMKKysrIGIvZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3X2hkbWktcm9ja2NoaXAuYwpAQCAtMTE1LDIwICsxMTUs OCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGR3X2hkbWlfbXBsbF9jb25maWcgcm9ja2NoaXBfbXBs bF9jZmdbXSA9IHsKIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHdfaGRtaV9jdXJyX2N0cmwgcm9ja2No aXBfY3VyX2N0cltdID0gewogCS8qICAgICAgcGl4ZWxjbGsgICAgYnBwOCAgICBicHAxMCAgIGJw cDEyICovCiAJewotCQk0MDAwMDAwMCwgIHsgMHgwMDE4LCAweDAwMTgsIDB4MDAxOCB9LAotCX0s IHsKLQkJNjUwMDAwMDAsICB7IDB4MDAyOCwgMHgwMDI4LCAweDAwMjggfSwKLQl9LCB7Ci0JCTY2 MDAwMDAwLCAgeyAweDAwMzgsIDB4MDAzOCwgMHgwMDM4IH0sCi0JfSwgewotCQk3NDI1MDAwMCwg IHsgMHgwMDI4LCAweDAwMzgsIDB4MDAzOCB9LAotCX0sIHsKLQkJODM1MDAwMDAsICB7IDB4MDAy OCwgMHgwMDM4LCAweDAwMzggfSwKLQl9LCB7Ci0JCTE0NjI1MDAwMCwgeyAweDAwMzgsIDB4MDAz OCwgMHgwMDM4IH0sCi0JfSwgewotCQkxNDg1MDAwMDAsIHsgMHgwMDAwLCAweDAwMzgsIDB4MDAz OCB9LAotCX0sIHsKKwkJNjAwMDAwMDAwLCB7IDB4MDAwMCwgMHgwMDAwLCAweDAwMDAgfSwKKwl9 LCAgewogCQl+MFVMLCAgICAgIHsgMHgwMDAwLCAweDAwMDAsIDB4MDAwMH0sCiAJfQogfTsKLS0g CjEuOS4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Mon, 11 Jul 2016 19:05:36 +0800 Subject: [PATCH v1 1/6] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always In-Reply-To: <1468235079-29152-1-git-send-email-ykk@rock-chips.com> References: <1468235079-29152-1-git-send-email-ykk@rock-chips.com> Message-ID: <1468235136-29417-1-git-send-email-ykk@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Douglas Anderson Jitter was improved by lowering the MPLL bandwidth to account for high frequency noise in the rk3288 PLL. In each case MPLL bandwidth was lowered only enough to get us a comfortable margin. We believe that lowering the bandwidth like this is safe given sufficient testing. Signed-off-by: Douglas Anderson Signed-off-by: Yakir Yang --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 801110f..a621118 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -115,20 +115,8 @@ static const struct dw_hdmi_mpll_config rockchip_mpll_cfg[] = { static const struct dw_hdmi_curr_ctrl rockchip_cur_ctr[] = { /* pixelclk bpp8 bpp10 bpp12 */ { - 40000000, { 0x0018, 0x0018, 0x0018 }, - }, { - 65000000, { 0x0028, 0x0028, 0x0028 }, - }, { - 66000000, { 0x0038, 0x0038, 0x0038 }, - }, { - 74250000, { 0x0028, 0x0038, 0x0038 }, - }, { - 83500000, { 0x0028, 0x0038, 0x0038 }, - }, { - 146250000, { 0x0038, 0x0038, 0x0038 }, - }, { - 148500000, { 0x0000, 0x0038, 0x0038 }, - }, { + 600000000, { 0x0000, 0x0000, 0x0000 }, + }, { ~0UL, { 0x0000, 0x0000, 0x0000}, } }; -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758667AbcGKLFt (ORCPT ); Mon, 11 Jul 2016 07:05:49 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:58656 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753501AbcGKLFr (ORCPT ); Mon, 11 Jul 2016 07:05:47 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: mark.yao@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Yakir Yang To: Mark Yao , Heiko Stuebner , Rob Herring , Russell King , Philipp Zabel , Andy Yan Cc: David Airlie , Daniel Vetter , Kumar Gala , Zheng Yang , xhc@rock-chips.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Douglas Anderson , Yakir Yang Subject: [PATCH v1 1/6] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Date: Mon, 11 Jul 2016 19:05:36 +0800 Message-Id: <1468235136-29417-1-git-send-email-ykk@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1468235079-29152-1-git-send-email-ykk@rock-chips.com> References: <1468235079-29152-1-git-send-email-ykk@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Douglas Anderson Jitter was improved by lowering the MPLL bandwidth to account for high frequency noise in the rk3288 PLL. In each case MPLL bandwidth was lowered only enough to get us a comfortable margin. We believe that lowering the bandwidth like this is safe given sufficient testing. Signed-off-by: Douglas Anderson Signed-off-by: Yakir Yang --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 801110f..a621118 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -115,20 +115,8 @@ static const struct dw_hdmi_mpll_config rockchip_mpll_cfg[] = { static const struct dw_hdmi_curr_ctrl rockchip_cur_ctr[] = { /* pixelclk bpp8 bpp10 bpp12 */ { - 40000000, { 0x0018, 0x0018, 0x0018 }, - }, { - 65000000, { 0x0028, 0x0028, 0x0028 }, - }, { - 66000000, { 0x0038, 0x0038, 0x0038 }, - }, { - 74250000, { 0x0028, 0x0038, 0x0038 }, - }, { - 83500000, { 0x0028, 0x0038, 0x0038 }, - }, { - 146250000, { 0x0038, 0x0038, 0x0038 }, - }, { - 148500000, { 0x0000, 0x0038, 0x0038 }, - }, { + 600000000, { 0x0000, 0x0000, 0x0000 }, + }, { ~0UL, { 0x0000, 0x0000, 0x0000}, } }; -- 1.9.1