diff for duplicates of <1468332418.8745.11.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index a2a3196..370a8c4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,16 +5,16 @@ On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote: > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c [] > @@ -775,11 +775,11 @@ static int vidioc_g_crop(struct file *file, void *priv, -> ? u32 left, right, top, bottom; -> ? -> ? if (ctx->state != MFCINST_HEAD_PARSED && +> u32 left, right, top, bottom; +> +> if (ctx->state != MFCINST_HEAD_PARSED && > - ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING > - && ctx->state != MFCINST_FINISHED) { > - mfc_err("Cannont set crop\n"); > - return -EINVAL; > - } -> + ????ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING -> + ????&& ctx->state != MFCINST_FINISHED) { +> + ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING +> + && ctx->state != MFCINST_FINISHED) { > + mfc_err("Can not get crop information\n"); > + return -EINVAL; > + } @@ -23,10 +23,10 @@ is it a set or a get? It'd be nicer for humans to read if the alignment was consistent - if (ctx->state !=?MFCINST_HEAD_PARSED && - ? ? ctx->state !=?MFCINST_RUNNING && - ? ? ctx->state !=?MFCINST_FINISHING && - ? ? ctx->state !=?MFCINST_FINISHED) { + if (ctx->state != MFCINST_HEAD_PARSED && + ctx->state != MFCINST_RUNNING && + ctx->state != MFCINST_FINISHING && + ctx->state != MFCINST_FINISHED) { mfc_err("Can not get crop information\n"); return -EINVAL; } diff --git a/a/content_digest b/N1/content_digest index 14d88bd..dc31e11 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,16 @@ "ref\01468276740-1591-1-git-send-email-shuahkh@osg.samsung.com\0" - "From\0joe@perches.com (Joe Perches)\0" - "Subject\0[PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors\0" + "From\0Joe Perches <joe@perches.com>\0" + "Subject\0Re: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors\0" "Date\0Tue, 12 Jul 2016 07:06:58 -0700\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Shuah Khan <shuahkh@osg.samsung.com>" + kyungmin.park@samsung.com + k.debski@samsung.com + jtp.park@samsung.com + mchehab@kernel.org + " javier@osg.samsung.com\0" + "Cc\0linux-arm-kernel@lists.infradead.org" + linux-media@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote:\n" @@ -12,16 +20,16 @@ "> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c\n" "[]\n" "> @@ -775,11 +775,11 @@ static int vidioc_g_crop(struct file *file, void *priv,\n" - "> ?\tu32 left, right, top, bottom;\n" - "> ?\n" - "> ?\tif (ctx->state != MFCINST_HEAD_PARSED &&\n" + "> \302\240\tu32 left, right, top, bottom;\n" + "> \302\240\n" + "> \302\240\tif (ctx->state != MFCINST_HEAD_PARSED &&\n" "> -\tctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING\n" "> -\t\t\t\t\t&& ctx->state != MFCINST_FINISHED) {\n" "> -\t\t\tmfc_err(\"Cannont set crop\\n\");\n" "> -\t\t\treturn -EINVAL;\n" "> -\t\t}\n" - "> +\t????ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING\n" - "> +\t????&& ctx->state != MFCINST_FINISHED) {\n" + "> +\t\302\240\302\240\302\240\302\240ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING\n" + "> +\t\302\240\302\240\302\240\302\240&& ctx->state != MFCINST_FINISHED) {\n" "> +\t\tmfc_err(\"Can not get crop information\\n\");\n" "> +\t\treturn -EINVAL;\n" "> +\t}\n" @@ -30,12 +38,12 @@ "\n" "It'd be nicer for humans to read if the alignment was consistent\n" "\n" - "\tif (ctx->state !=?MFCINST_HEAD_PARSED &&\n" - "\t? ? ctx->state !=?MFCINST_RUNNING &&\n" - "\t? ? ctx->state !=?MFCINST_FINISHING &&\n" - "\t? ? ctx->state !=?MFCINST_FINISHED) {\n" + "\tif (ctx->state !=\302\240MFCINST_HEAD_PARSED &&\n" + "\t\302\240 \302\240 ctx->state !=\302\240MFCINST_RUNNING &&\n" + "\t\302\240 \302\240 ctx->state !=\302\240MFCINST_FINISHING &&\n" + "\t\302\240 \302\240 ctx->state !=\302\240MFCINST_FINISHED) {\n" "\t\tmfc_err(\"Can not get crop information\\n\");\n" "\t\treturn -EINVAL;\n" "\t}" -0820fd464bfc5d4fa8618de437e7395796983e9250f7b41b901f778d417f4fb4 +143c4d555623486dce9f9dcf8e58fcb716970142c569b40a7e77ec6cd00092f0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.