From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kani, Toshimitsu" Subject: Re: [PATCH v3] libnvdimm, pmem: use REQ_FUA, REQ_FLUSH for nvdimm_flush() Date: Wed, 13 Jul 2016 19:46:56 +0000 Message-ID: <1468439194.8908.55.camel@hpe.com> References: <146812112233.32932.5962348391051315694.stgit@dwillia2-desk3.amr.corp.intel.com> <146836238217.14676.14154640837011539657.stgit@dwillia2-desk3.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <146836238217.14676.14154640837011539657.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Content-Language: en-US Content-ID: <8D9730C05FEFEA4F845150793B721D1F-mmYPd6ayCNGroOM5E8FhRbjFIynDaujOfM0AETQt39g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" Cc: "linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "hch-jcswGhMUV9g@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-acpi@vger.kernel.org On Tue, 2016-07-12 at 15:26 -0700, Dan Williams wrote: > Given that nvdimm_flush() has higher overhead than wmb_pmem() (pointer > chasing through nd_region), and that we otherwise assume a platform has > ADR capability when flush hints are not present, move nvdimm_flush() to > REQ_FLUSH context. > > Note that we still arrange for nvdimm_flush() to be called even in the > ADR case. We need at least once wmb() fence to push buffered writes in > the cpu out to the ADR protected domain. > > Cc: Toshi Kani > Cc: Ross Zwisler > Signed-off-by: Dan Williams This looks good to me. Reviewed-by: Toshi Kani Thanks, -Toshi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0730.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe44::730]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2E71A1A1EDE for ; Wed, 13 Jul 2016 12:47:44 -0700 (PDT) From: "Kani, Toshimitsu" Subject: Re: [PATCH v3] libnvdimm, pmem: use REQ_FUA, REQ_FLUSH for nvdimm_flush() Date: Wed, 13 Jul 2016 19:46:56 +0000 Message-ID: <1468439194.8908.55.camel@hpe.com> References: <146812112233.32932.5962348391051315694.stgit@dwillia2-desk3.amr.corp.intel.com> <146836238217.14676.14154640837011539657.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <146836238217.14676.14154640837011539657.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Language: en-US Content-ID: <8D9730C05FEFEA4F845150793B721D1F@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "dan.j.williams@intel.com" , "linux-nvdimm@lists.01.org" Cc: "linux-fsdevel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "hch@lst.de" , "linux-kernel@vger.kernel.org" List-ID: On Tue, 2016-07-12 at 15:26 -0700, Dan Williams wrote: > Given that nvdimm_flush() has higher overhead than wmb_pmem() (pointer > chasing through nd_region), and that we otherwise assume a platform has > ADR capability when flush hints are not present, move nvdimm_flush() to > REQ_FLUSH context. > > Note that we still arrange for nvdimm_flush() to be called even in the > ADR case. We need at least once wmb() fence to push buffered writes in > the cpu out to the ADR protected domain. > > Cc: Toshi Kani > Cc: Ross Zwisler > Signed-off-by: Dan Williams This looks good to me. Reviewed-by: Toshi Kani Thanks, -Toshi _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" , "linux-nvdimm@lists.01.org" CC: "hch@lst.de" , "linux-kernel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "linux-acpi@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH v3] libnvdimm, pmem: use REQ_FUA, REQ_FLUSH for nvdimm_flush() Date: Wed, 13 Jul 2016 19:46:56 +0000 Message-ID: <1468439194.8908.55.camel@hpe.com> References: <146812112233.32932.5962348391051315694.stgit@dwillia2-desk3.amr.corp.intel.com> <146836238217.14676.14154640837011539657.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <146836238217.14676.14154640837011539657.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <8D9730C05FEFEA4F845150793B721D1F@NAMPRD84.PROD.OUTLOOK.COM> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDE2LTA3LTEyIGF0IDE1OjI2IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IEdpdmVuIHRoYXQgbnZkaW1tX2ZsdXNoKCkgaGFzIGhpZ2hlciBvdmVyaGVhZCB0aGFuIHdtYl9w bWVtKCkgKHBvaW50ZXINCj4gY2hhc2luZyB0aHJvdWdoIG5kX3JlZ2lvbiksIGFuZCB0aGF0IHdl IG90aGVyd2lzZSBhc3N1bWUgYSBwbGF0Zm9ybSBoYXMNCj4gQURSIGNhcGFiaWxpdHkgd2hlbiBm bHVzaCBoaW50cyBhcmUgbm90IHByZXNlbnQsIG1vdmUgbnZkaW1tX2ZsdXNoKCkgdG8NCj4gUkVR X0ZMVVNIIGNvbnRleHQuDQo+IA0KPiBOb3RlIHRoYXQgd2Ugc3RpbGwgYXJyYW5nZSBmb3IgbnZk aW1tX2ZsdXNoKCkgdG8gYmUgY2FsbGVkIGV2ZW4gaW4gdGhlDQo+IEFEUiBjYXNlLiBXZSBuZWVk IGF0IGxlYXN0IG9uY2Ugd21iKCkgZmVuY2UgdG8gcHVzaCBidWZmZXJlZCB3cml0ZXMgaW4NCj4g dGhlIGNwdSBvdXQgdG8gdGhlIEFEUiBwcm90ZWN0ZWQgZG9tYWluLg0KPiANCj4gQ2M6IFRvc2hp IEthbmkgPHRvc2hpLmthbmlAaHBlLmNvbT4NCj4gQ2M6IFJvc3MgWndpc2xlciA8cm9zcy56d2lz bGVyQGxpbnV4LmludGVsLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogRGFuIFdpbGxpYW1zIDxkYW4u ai53aWxsaWFtc0BpbnRlbC5jb20+DQoNClRoaXMgbG9va3MgZ29vZCB0byBtZS4NCg0KUmV2aWV3 ZWQtYnk6IFRvc2hpIEthbmkgPHRvc2hpLmthbmlAaHBlLmNvbT4NCg0KVGhhbmtzLA0KLVRvc2hp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbcGMTrZ (ORCPT ); Wed, 13 Jul 2016 15:47:25 -0400 Received: from mail-sn1nam02on0110.outbound.protection.outlook.com ([104.47.36.110]:44744 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750941AbcGMTrR (ORCPT ); Wed, 13 Jul 2016 15:47:17 -0400 X-Greylist: delayed 16962 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Jul 2016 15:47:17 EDT From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" , "linux-nvdimm@lists.01.org" CC: "hch@lst.de" , "linux-kernel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "linux-acpi@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH v3] libnvdimm, pmem: use REQ_FUA, REQ_FLUSH for nvdimm_flush() Thread-Topic: [PATCH v3] libnvdimm, pmem: use REQ_FUA, REQ_FLUSH for nvdimm_flush() Thread-Index: AQHR3Iza53ISBtF990ePofemD/t+zqAWxWsA Date: Wed, 13 Jul 2016 19:46:56 +0000 Message-ID: <1468439194.8908.55.camel@hpe.com> References: <146812112233.32932.5962348391051315694.stgit@dwillia2-desk3.amr.corp.intel.com> <146836238217.14676.14154640837011539657.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <146836238217.14676.14154640837011539657.stgit@dwillia2-desk3.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: a2eb41f0-31b0-4d2e-8895-08d3ab56727d x-microsoft-exchange-diagnostics: 1;CS1PR84MB0008;6:xvSUPrjYgjIk3oBoat+kp0KE5k29P2eLtybQmJV1WuLTc2M0SbL4yu2CscsQ1AbQ9XxldNjju8hemt4dURLXOvW0jv0x/OLojVaQI39Q3+doaVOQ8kG7xZd4jER8PvvsJRaXdrKV5nkLQffjnT0a7vMkPg2qYMEi534KYYfGDxcZVpfcjANircLMa2JKhAQAxJx2Q/Bmrr5WcwGfmmO2zNE1uC+4NVmueIIPcnAaWtD8kwRc78qWoK4dWtVom3QJrZI7ktfF3LGpy0NzIrjyKPcJBGIGeXdsPDLVPumtvRWyuCL7ilvaX87oyzrkdgPTOXv4HkpqPk9/yIT3a4SoaA==;5:0VWySzOvP5YVHD4h16KFiWgMIzIXp6gzTXHuLYHVFWXRvOZYYOXIWotBJ4erghUnUapwArq85efcjb86InYL1H4d8Mco8TV6VE2SEuDbSTvGPexp8kjZSsJX5lgAurIYCOk7IyrCEBImt4Kc+oljfw==;24:oERmH2y/XARPc7trtGWjBhKZlt7gIcfm7YnjAj/9n7TwStDjK3O1VQ0UxfKCM++PHDjgy550PsRxkd9CLCEY8igslvOoCTjROcp0/racpmk=;7:NzrfD6jEtXAJCv/iZRgwAsEbPfq03u2n0lQ5uSW6ji+e/me69pLTcsVyIlVJjaFy0aZdvxGZhmO5SJm/i6shEKFTu2OTAWD2hTebmRxBwHn2OwnoRz1axgdb1g+OI5/4hDdojwck9jTA2gLwpBhn/q/Ht1sgpwolCZ+YFITPFzw7qkqRCVzsK/HyMML72dog9CjK6TXFGt635kUrw6lUT1Een7s6XF+or2TpoFn5ZT8EOpf/DEYixx/I8byST8yO x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0008; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:CS1PR84MB0008;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0008; x-forefront-prvs: 000227DA0C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(199003)(377424004)(189002)(24454002)(81166006)(8936002)(103116003)(586003)(87936001)(6116002)(102836003)(3846002)(81156014)(99286002)(97736004)(7736002)(305945005)(5001770100001)(105586002)(7846002)(4326007)(86362001)(68736007)(92566002)(11100500001)(2501003)(189998001)(3280700002)(19580405001)(36756003)(33646002)(5002640100001)(76176999)(101416001)(50986999)(54356999)(66066001)(106116001)(77096005)(122556002)(106356001)(3660700001)(2950100001)(2906002)(10400500002)(2900100001)(19580395003)(8676002);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0008;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <8D9730C05FEFEA4F845150793B721D1F@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2016 19:46:56.4777 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0008 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u6DJlTrt006161 On Tue, 2016-07-12 at 15:26 -0700, Dan Williams wrote: > Given that nvdimm_flush() has higher overhead than wmb_pmem() (pointer > chasing through nd_region), and that we otherwise assume a platform has > ADR capability when flush hints are not present, move nvdimm_flush() to > REQ_FLUSH context. > > Note that we still arrange for nvdimm_flush() to be called even in the > ADR case. We need at least once wmb() fence to push buffered writes in > the cpu out to the ADR protected domain. > > Cc: Toshi Kani > Cc: Ross Zwisler > Signed-off-by: Dan Williams This looks good to me. Reviewed-by: Toshi Kani Thanks, -Toshi