From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNhiQ-0005eR-OI for qemu-devel@nongnu.org; Thu, 14 Jul 2016 10:34:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNhiK-0005Ul-OK for qemu-devel@nongnu.org; Thu, 14 Jul 2016 10:34:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNhiK-0005Ua-GK for qemu-devel@nongnu.org; Thu, 14 Jul 2016 10:34:08 -0400 Message-ID: <1468506844.26657.21.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 14 Jul 2016 16:34:04 +0200 In-Reply-To: <20160714114956.GA5245@gmail.com> References: <20160714114956.GA5245@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] usb-mtp: added support for files larger than 4gb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaac Lozano <109lozanoi@gmail.com> Cc: qemu-devel@nongnu.org, bsd@redhat.com On Do, 2016-07-14 at 04:49 -0700, Isaac Lozano wrote: > Added support for sending data larger than 4gb. > Also implemented > object properties so that Windows can receive >4gb files. Can you please split those into two separate patches? > + case PROP_PERSISTENT_UNIQUE_OBJECT_IDENTIFIER: > + /* Should be persistant between sessions, > + * but using our objedt ID is "good enough" > + * for now */ > + usb_mtp_add_u64(d, 0x0000000000000000); > + usb_mtp_add_u64(d, o->handle); > + break; Maybe use the inode number here? cheers, Gerd