From: Gerd Hoffmann <kraxel@redhat.com>
To: "Herongguang (Stephen)" <herongguang.he@huawei.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
weidong.huang@huawei.com,
"peter.huangpeng@huawei.com >> Huangpeng (Peter)"
<peter.huangpeng@huawei.com>
Subject: Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix off-by-one bug
Date: Fri, 15 Jul 2016 12:10:47 +0200 [thread overview]
Message-ID: <1468577447.22036.7.camel@redhat.com> (raw)
In-Reply-To: <5784B8EB.7010008@huawei.com>
On Di, 2016-07-12 at 17:31 +0800, Herongguang (Stephen) wrote:
> In tight_encode_indexed_rect32, buf(or src)’s size is count. In for loop,
> the logic is supposed to be that i is an index into src, i should be
> incremented when incrementing src.
>
> This is broken when src is incremented but i is not before while loop,
> resulting in off-by-one bug in while loop.
>
> Signed-off-by: He Rongguang <herongguang.he@huawei.com>
Added to vnc queue.
Patch is whitespace mangled, had to use "patch --ignore-whitespace" to
get it applied. Can you please use 'git send-email' to send patches in
the future? That is the best way to avoid your mail client breaking
patches.
thanks,
Gerd
prev parent reply other threads:[~2016-07-15 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 9:31 [Qemu-devel] [PATCH] vnc-enc-tight: fix off-by-one bug Herongguang (Stephen)
2016-07-15 10:10 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468577447.22036.7.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=herongguang.he@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.