From: Chas Williams <3chas3@gmail.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>, dev@dpdk.org
Cc: thomas.monjalon@6wind.com, Dept-EngDPDKDev@qlogic.com
Subject: Re: [PATCH 1/2] bnx2x: disable fast path interrupts
Date: Fri, 15 Jul 2016 06:34:50 -0400 [thread overview]
Message-ID: <1468578890.1732.0.camel@gmail.com> (raw)
In-Reply-To: <1468515827-24865-1-git-send-email-rasesh.mody@qlogic.com>
On Thu, 2016-07-14 at 10:03 -0700, Rasesh Mody wrote:
> Disable fastpath interrupts and remove unneeded delay in
> bnx2x_interrupt_action(). This patch fixes and prevents performance
> degradation for BNX2X PMD.
>
> Fixes: 540a2110 ("bnx2x: driver core")
>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
>
> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
> index c8d2bf2..f97dd5b 100644
> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
> @@ -107,8 +107,8 @@ bnx2x_interrupt_action(struct rte_eth_dev *dev)
>
> PMD_DEBUG_PERIODIC_LOG(INFO, "Interrupt handled");
>
> - if (bnx2x_intr_legacy(sc, 0))
> - DELAY_MS(250);
> + bnx2x_intr_legacy(sc, 0)
> +
Trailing semicolon?
next prev parent reply other threads:[~2016-07-15 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 17:03 [PATCH 1/2] bnx2x: disable fast path interrupts Rasesh Mody
2016-07-14 17:03 ` [PATCH 2/2] bnx2x: fix fw mempool name length Rasesh Mody
2016-07-15 10:34 ` Chas Williams [this message]
2016-07-15 16:40 ` [PATCH 1/2] bnx2x: disable fast path interrupts Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468578890.1732.0.camel@gmail.com \
--to=3chas3@gmail.com \
--cc=Dept-EngDPDKDev@qlogic.com \
--cc=dev@dpdk.org \
--cc=rasesh.mody@qlogic.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.