From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chas Williams <3chas3@gmail.com> Subject: Re: [PATCH 1/2] bnx2x: disable fast path interrupts Date: Fri, 15 Jul 2016 06:34:50 -0400 Message-ID: <1468578890.1732.0.camel@gmail.com> References: <1468515827-24865-1-git-send-email-rasesh.mody@qlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: thomas.monjalon@6wind.com, Dept-EngDPDKDev@qlogic.com To: Rasesh Mody , dev@dpdk.org Return-path: Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by dpdk.org (Postfix) with ESMTP id 2CDDA39EA for ; Fri, 15 Jul 2016 12:34:52 +0200 (CEST) Received: by mail-qt0-f195.google.com with SMTP id j37so3708992qta.0 for ; Fri, 15 Jul 2016 03:34:52 -0700 (PDT) In-Reply-To: <1468515827-24865-1-git-send-email-rasesh.mody@qlogic.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2016-07-14 at 10:03 -0700, Rasesh Mody wrote: > Disable fastpath interrupts and remove unneeded delay in > bnx2x_interrupt_action(). This patch fixes and prevents performance > degradation for BNX2X PMD. >=20 > Fixes: 540a2110 ("bnx2x: driver core") >=20 > Signed-off-by: Rasesh Mody >=C2=A0 > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x= _ethdev.c > index c8d2bf2..f97dd5b 100644 > --- a/drivers/net/bnx2x/bnx2x_ethdev.c > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > @@ -107,8 +107,8 @@ bnx2x_interrupt_action(struct rte_eth_dev *dev) > =C2=A0 > =C2=A0 PMD_DEBUG_PERIODIC_LOG(INFO, "Interrupt handled"); > =C2=A0 > - if (bnx2x_intr_legacy(sc, 0)) > - DELAY_MS(250); > + bnx2x_intr_legacy(sc, 0) > + Trailing semicolon?