From: Karl-Heinz Schneider <karl-heinz@schneider-inet.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Peter Rosin <peda@axentia.se>,
Phil Reid <preid@electromag.com.au>
Subject: Re: [PATCH v3 2/2] power: Adds support for Smart Battery System Manager
Date: Tue, 19 Jul 2016 20:51:05 +0200 [thread overview]
Message-ID: <1468954265.3053.3.camel@amnesix> (raw)
In-Reply-To: <20160719041729.GC1640@katana>
Hi Wolfram,
Am Dienstag, den 19.07.2016, 06:17 +0200 schrieb Wolfram Sang:
> > + data->muxc = i2c_mux_alloc(adapter, dev, SBSM_MAX_BATS, 0,
> > + I2C_MUX_LOCKED, &sbsm_select, NULL);
> > + if (!data->muxc) {
> > + dev_err(dev, "failed to alloc i2c mux\n");
>
> Don't print errors on ENOMEM.
Will be fixed on next revision.
>
> Other than that, looks good to me, yet Peter has more insight to
> i2c-muxes these days.
>
Tanks for review.
Will wait another few days before sending a new revision, hence changes
are rather small.
--
Karl-Heinz
next prev parent reply other threads:[~2016-07-19 18:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1bIiDr-0004G1-0P>
2016-07-12 18:48 ` [PATCH v3 0/2] Add support for Smart Battery System Manager Karl-Heinz Schneider
2016-07-12 18:48 ` [PATCH v3 1/2] Documentation: Add sbs-manager device tree node documentation Karl-Heinz Schneider
2016-07-16 22:05 ` Rob Herring
2016-07-17 21:15 ` Karl-Heinz Schneider
2016-07-19 4:14 ` Wolfram Sang
2016-07-25 10:33 ` Peter Rosin
2016-07-25 11:24 ` Wolfram Sang
2016-07-12 18:48 ` [PATCH v3 2/2] power: Adds support for Smart Battery System Manager Karl-Heinz Schneider
2016-07-12 20:06 ` kbuild test robot
2016-07-12 20:06 ` [PATCH] power: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-07-19 4:17 ` [PATCH v3 2/2] power: Adds support for Smart Battery System Manager Wolfram Sang
2016-07-19 18:51 ` Karl-Heinz Schneider [this message]
2016-07-25 10:44 ` Peter Rosin
2016-07-25 19:49 ` Karl-Heinz Schneider
2016-08-25 20:20 ` [PATCH v4 0/2] Add " Karl-Heinz Schneider
2016-08-25 20:21 ` [PATCH v4 1/2] Documentation: Add sbs-manager device tree node documentation Karl-Heinz Schneider
2016-08-31 14:43 ` Rob Herring
2016-08-31 19:52 ` Karl-Heinz Schneider
[not found] ` <1472673151.5102.12.camel-X5L7DgJ4l23oE99TX8zNy7NAH6kLmebB@public.gmane.org>
2016-09-01 9:00 ` Phil Reid
2016-08-31 22:34 ` Karl-Heinz Schneider
2016-09-01 9:37 ` Phil Reid
2016-08-25 20:21 ` [PATCH v4 2/2] power: Adds support for Smart Battery System Manager Karl-Heinz Schneider
2016-08-31 15:10 ` [PATCH v4 0/2] Add " Sebastian Reichel
2016-08-31 19:54 ` Karl-Heinz Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468954265.3053.3.camel@amnesix \
--to=karl-heinz@schneider-inet.de \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=preid@electromag.com.au \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.